Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 2/2] gpio: axp209: add pinctrl support
Date: Fri, 25 Nov 2016 16:17:04 +0100	[thread overview]
Message-ID: <20161125151704.3am7wyqrlz767dvc@lukather> (raw)
In-Reply-To: <20161123141151.25315-3-quentin.schulz@free-electrons.com>

Hi,

On Wed, Nov 23, 2016 at 03:11:51PM +0100, Quentin Schulz wrote:
> The GPIOs present in the AXP209 PMIC have multiple functions. They
> typically allow a pin to be used as GPIO input or output and can also be
> used as ADC or regulator for example.[1]
> 
> This adds the possibility to use all functions of the GPIOs present in
> the AXP209 PMIC thanks to pinctrl subsystem.
> 
> [1] see registers 90H, 92H and 93H at
>     http://dl.linux-sunxi.org/AXP/AXP209_Datasheet_v1.0en.pdf
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

I've said it already face to face, but ideally you should split that
patch into logical changes.

I can see here at least three:
  - Adding the pinctrl features
  - Renaming the structure and functions
  - Removal of a few functions

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161125/3ba59778/attachment.sig>

      parent reply	other threads:[~2016-11-25 15:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 14:11 [PATCH RESEND 0/2] add support for AXP209 GPIOs functions Quentin Schulz
2016-11-23 14:11 ` [PATCH RESEND 1/2] gpio: axp209: use correct register for GPIO input status Quentin Schulz
2016-11-24 14:13   ` Linus Walleij
2016-11-23 14:11 ` [PATCH RESEND 2/2] gpio: axp209: add pinctrl support Quentin Schulz
2016-11-24  0:00   ` kbuild test robot
2016-11-24 14:17   ` Linus Walleij
2016-11-29 22:13     ` Quentin Schulz
2016-12-02 12:30       ` Linus Walleij
2016-11-24 16:08   ` Chen-Yu Tsai
2016-11-25 15:17   ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161125151704.3am7wyqrlz767dvc@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox