From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up Turris Omnia
Date: Mon, 28 Nov 2016 10:58:36 +0000 [thread overview]
Message-ID: <20161128105836.GU14217@n2100.armlinux.org.uk> (raw)
In-Reply-To: <4ad1108a-43c4-46f8-4683-1c4b89996036@suse.de>
On Mon, Nov 28, 2016 at 11:52:26AM +0100, Andreas F?rber wrote:
> Hi Russell,
>
> Am 28.11.2016 um 11:37 schrieb Russell King - ARM Linux:
> > On Sun, Nov 27, 2016 at 07:51:39PM +0100, Andreas F?rber wrote:
> >> To more consistently reference nodes by label, add labels for sata,
> >> usb2, sdhci and usb3 nodes.
> >>
> >> Convert all other 38x boards for consistency. Add labels for nfc and rtc.
> >
> > Please don't do this for clearfog - there's changes in the pipeline which
> > completely replace armada-388-clearfog.dts because there's a "base" and
> > "pro" versions of this hardware now, and making such a huge change will
> > effectively mean we have to start over with the DT files.
>
> Would it help to split it back up into a series of add-labels,
> use-labels like I had originally? Then you could start using them in
> your refactoring as soon as the add-labels patch gets applied. Or are
> you completely against this style?
What I mentioned is not a case of a work in progress, it's already out
in the wild, and completely changing the clearfog dts file by changing
the style of DT references will make applying the changes _much_ more
difficult - not only obviously impossible to apply the original patch,
but also quite impossible to identify the changes made downstream.
So, I'd rather armada-388-clearfog.dts is not touched at all as it _will_
cause conflicts, but I have nothing against the new style (and I actually
prefer it.)
What I'm asking is that you don't make other people's lives harder than
they need to be.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-11-28 10:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 14:26 [PATCH v5 0/2] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-25 14:26 ` [PATCH v5 1/2] devicetree: Add vendor prefix for CZ.NIC Uwe Kleine-König
2016-11-25 16:15 ` Gregory CLEMENT
2016-11-25 14:26 ` [PATCH v5 2/2] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-25 14:32 ` Andrew Lunn
2016-11-25 16:16 ` Gregory CLEMENT
2016-11-27 16:00 ` Andreas Färber
2016-11-27 16:05 ` Uwe Kleine-König
2016-11-27 16:10 ` Andreas Färber
2016-11-27 16:14 ` Andrew Lunn
2016-11-27 18:51 ` [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up " Andreas Färber
2016-11-27 18:57 ` Andreas Färber
2016-11-28 10:37 ` Russell King - ARM Linux
2016-11-28 10:52 ` Andreas Färber
2016-11-28 10:54 ` Uwe Kleine-König
2016-11-28 10:58 ` Andreas Färber
2016-11-28 10:58 ` Russell King - ARM Linux [this message]
2016-11-27 19:02 ` [PATCH v5 2/2] ARM: dts: add support for " Andreas Färber
2016-11-27 16:07 ` Andrew Lunn
2016-11-27 16:20 ` Andreas Färber
2016-11-27 21:22 ` Andreas Färber
2016-11-27 19:22 ` Andreas Färber
2016-11-27 19:37 ` [PATCH] ARM: dts: mvebu: Fix armada-385-turris-omnia stdout-path Andreas Färber
2016-11-27 21:10 ` Andrew Lunn
2016-11-27 21:25 ` Uwe Kleine-König
2016-11-27 22:14 ` Andreas Färber
2016-11-27 22:30 ` Uwe Kleine-König
2016-11-27 19:39 ` [PATCH v5 2/2] ARM: dts: add support for Turris Omnia Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128105836.GU14217@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).