From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v2] net: thunderx: Fix transmit queue timeout issue
Date: Fri, 02 Dec 2016 13:33:11 -0500 (EST) [thread overview]
Message-ID: <20161202.133311.494383963195952738.davem@davemloft.net> (raw)
In-Reply-To: <1480596868-17693-1-git-send-email-sunil.kovvuri@gmail.com>
From: sunil.kovvuri@gmail.com
Date: Thu, 1 Dec 2016 18:24:28 +0530
> From: Sunil Goutham <sgoutham@cavium.com>
>
> Transmit queue timeout issue is seen in two cases
> - Due to a race condition btw setting stop_queue at xmit()
> and checking for stopped_queue in NAPI poll routine, at times
> transmission from a SQ comes to a halt. This is fixed
> by using barriers and also added a check for SQ free descriptors,
> incase SQ is stopped and there are only CQE_RX i.e no CQE_TX.
> - Contrary to an assumption, a HW errata where HW doesn't stop transmission
> even though there are not enough CQEs available for a CQE_TX is
> not fixed in T88 pass 2.x. This results in a Qset error with
> 'CQ_WR_FULL' stalling transmission. This is fixed by adjusting
> RXQ's RED levels for CQ level such that there is always enough
> space left for CQE_TXs.
>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> ---
> v2: As suggested by David, replaced netif_tx_start_queue with
> netif_tx_wake_queue.
Applied, thanks.
prev parent reply other threads:[~2016-12-02 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 12:54 [PATCH net-next v2] net: thunderx: Fix transmit queue timeout issue sunil.kovvuri at gmail.com
2016-12-02 18:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202.133311.494383963195952738.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).