From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] rtc: armada38x: Prepare for being use on 64 bits
Date: Thu, 8 Dec 2016 18:09:08 +0000 [thread overview]
Message-ID: <20161208180908.GL14217@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20161208171010.29446-4-gregory.clement@free-electrons.com>
On Thu, Dec 08, 2016 at 06:10:10PM +0100, Gregory CLEMENT wrote:
> The drivers are supposed to be portable, however there are few assumption
> done here about the unsigned long size. Make sure we use the accurate
> width for the variable.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> drivers/rtc/rtc-armada38x.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c
> index b8a74ffaae80..c4138130febf 100644
> --- a/drivers/rtc/rtc-armada38x.c
> +++ b/drivers/rtc/rtc-armada38x.c
> @@ -84,14 +84,14 @@ static void rtc_update_mbus_timing_params(struct armada38x_rtc *rtc)
> }
>
> struct str_value_to_freq {
> - unsigned long value;
> + u32 value;
> u8 freq;
> } __packed;
>
> -static unsigned long read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg)
> +static u32 read_rtc_register_wa(struct armada38x_rtc *rtc, u8 rtc_reg)
> {
> - unsigned long value_array[SAMPLE_NR], i, j, value;
> - unsigned long max = 0, index_max = SAMPLE_NR - 1;
> + int i, j, index_max = SAMPLE_NR - 1;
> + u32 value_array[SAMPLE_NR], value, max = 0;
Ah, I see my comments on patch 1 got addressed in patch 3... :)
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
prev parent reply other threads:[~2016-12-08 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 17:10 [PATCH 0/3] rtc: armada38x: Few improvement and cleanup Gregory CLEMENT
2016-12-08 17:10 ` [PATCH 1/3] rtc: armada38x: improve RTC errata implementation Gregory CLEMENT
2016-12-08 17:29 ` Andrew Lunn
2016-12-09 16:19 ` Gregory CLEMENT
2016-12-09 16:33 ` Andrew Lunn
2016-12-08 17:37 ` Russell King - ARM Linux
2016-12-09 16:37 ` Gregory CLEMENT
2016-12-08 17:10 ` [PATCH 2/3] rtc: armada38x: Convert to time64_t Gregory CLEMENT
2016-12-08 18:08 ` Russell King - ARM Linux
2016-12-08 17:10 ` [PATCH 3/3] rtc: armada38x: Prepare for being use on 64 bits Gregory CLEMENT
2016-12-08 18:09 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208180908.GL14217@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).