From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 9 Dec 2016 15:04:58 -0800 Subject: [PATCH] usb: dwc3: omap: remove devm_request_threaded_irq In-Reply-To: References: <20161209205508.6456-1-grygorii.strashko@ti.com> <20161209215958.GN4920@atomide.com> Message-ID: <20161209230457.GO4920@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Grygorii Strashko [161209 14:46]: > > > On 12/09/2016 03:59 PM, Tony Lindgren wrote: > > * Grygorii Strashko [161209 12:55]: > > > Switch back from devm_request_threaded_irq() to request_threaded_irq() to > > > avoid races between interrupt handler execution and PM runtime in error > > > handling code path in probe and in dwc3_omap_remove(): > > > > Can't you just call disable_irq() on the exit path instead of removing > > devm? > > > > I can. But what will be the benefit from using devm then? Hmm good point. Probably the least number of code would be to just do NOAUTOEN before devm_request_irq(), then only do enable_irq() just before returning from the probe. After all, we don't really want the irq running until the probe is done. I think that would leave out the extra handling from the error path? Regards, Tony