From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Re-enable PAN on uaccess_enable
Date: Mon, 12 Dec 2016 15:14:32 +0000 [thread overview]
Message-ID: <20161212151432.GB3203@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20161212150636.GA7070@cbox>
On Mon, Dec 12, 2016 at 04:06:36PM +0100, Christoffer Dall wrote:
> On Mon, Dec 12, 2016 at 01:50:26PM +0000, Marc Zyngier wrote:
> > Commit 4b65a5db3627 ("arm64: Introduce uaccess_{disable,enable}
> > functionality based on TTBR0_EL1") added conditional PAN
> > enable/disable. Unfortunately, a typo prevents PAN from being
> > re-enabled once it has been disabled.
> >
> > Restore the PAN functionnality by adding the missing '!'.
> >
> > Fixes: b65a5db3627 ("arm64: Introduce uaccess_{disable,enable} functionality based on TTBR0_EL1")
> > Reported-by: Christoffer Dall <christoffer.dall@linaro.org>
> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> > ---
> > Christoffer, any chance you could give this a go and let me know
> > if that fixes your issues?
>
> Yep, fixes the issue. Thanks!
Thanks for confirming. I merged this with a slightly updated commit log:
------8<-----------------
Commit 4b65a5db3627 ("arm64: Introduce uaccess_{disable,enable}
functionality based on TTBR0_EL1") added conditional user access
enable/disable. Unfortunately, a typo prevents the PAN bit from being
cleared for user access functions.
--
Catalin
next prev parent reply other threads:[~2016-12-12 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 13:50 [PATCH] arm64: Re-enable PAN on uaccess_enable Marc Zyngier
2016-12-12 15:06 ` Christoffer Dall
2016-12-12 15:14 ` Catalin Marinas [this message]
2016-12-12 15:25 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212151432.GB3203@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).