From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] usb: dwc3: omap: fix race of pm runtime with irq handler in probe
Date: Mon, 12 Dec 2016 13:10:12 -0800 [thread overview]
Message-ID: <20161212211012.GQ4920@atomide.com> (raw)
In-Reply-To: <20161212193752.32029-1-grygorii.strashko@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [161212 11:38]:
> Now races can happen between interrupt handler execution and PM runtime in
> error handling code path in probe and in dwc3_omap_remove() which will lead
> to system crash:
>
> in probe:
> ...
> err1:
> pm_runtime_put_sync(dev);
> ^^ PM runtime can race with IRQ handler when deferred probing happening
> due to extcon
> pm_runtime_disable(dev);
>
> return ret;
>
> in dwc3_omap_remove:
> ...
> dwc3_omap_disable_irqs(omap);
> ^^ IRQs are disabled in HW, but handler may still run
> of_platform_depopulate(omap->dev);
> pm_runtime_put_sync(&pdev->dev);
> ^^ PM runtime can race with IRQ handler
> pm_runtime_disable(&pdev->dev);
>
> return 0;
>
> So, OMAP DWC3 IRQ need to be disabled before calling
> pm_runtime_put() in probe and in dwc3_omap_remove().
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2016-12-12 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 19:37 [PATCH v2] usb: dwc3: omap: fix race of pm runtime with irq handler in probe Grygorii Strashko
2016-12-12 21:10 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212211012.GQ4920@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).