From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v3 PATCH 20/25] ARM: i.MX: remove map_io callback
Date: Fri, 16 Dec 2016 09:39:36 +0800 [thread overview]
Message-ID: <20161216013934.GA8787@dragon> (raw)
In-Reply-To: <1480691143-19845-21-git-send-email-vladimir.murzin@arm.com>
On Fri, Dec 02, 2016 at 03:05:38PM +0000, Vladimir Murzin wrote:
> There is no need to define map_io only for debug_ll_io_init() since it
> is already called in devicemaps_init() if map_io is NULL.
>
> Apart from that, for NOMMU build debug_ll_io_init() is a nop which
> leads to following error:
>
> CC arch/arm/mach-imx/mach-imx1.o
> arch/arm/mach-imx/mach-imx1.c:40:13: error: 'debug_ll_io_init' undeclared here (not in a function)
> .map_io = debug_ll_io_init,
> ^
> make[1]: *** [arch/arm/mach-imx/mach-imx1.o] Error 1
>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
It looks like a cleanup which can be applied separately.
Applied, thanks.
Shawn
> ---
> arch/arm/mach-imx/mach-imx1.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/mach-imx1.c b/arch/arm/mach-imx/mach-imx1.c
> index de5ab8d..3a8406e 100644
> --- a/arch/arm/mach-imx/mach-imx1.c
> +++ b/arch/arm/mach-imx/mach-imx1.c
> @@ -37,7 +37,6 @@ static void __init imx1_init_irq(void)
> };
>
> DT_MACHINE_START(IMX1_DT, "Freescale i.MX1 (Device Tree Support)")
> - .map_io = debug_ll_io_init,
> .init_early = imx1_init_early,
> .init_irq = imx1_init_irq,
> .dt_compat = imx1_dt_board_compat,
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2016-12-16 1:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 15:05 [RFC v3 PATCH 00/25] Allow NOMMU for MULTIPLATFORM Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 01/25] ARM: NOMMU: define stubs for fixup Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 02/25] ARM: NOMMU: define debug_ll_io_ini Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 03/25] ARM: debug: allow debug_ll_addr for NOMMU Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 04/25] ARM: NOMMU: define SECTION_xxx macros Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 05/25] ARM: NOMMU: define dummy user structure for feroceon Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 06/25] ARM: NOMMU: define __arm_ioremap_exec and pci_ioremap functions Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 07/25] ARM: NOMMU: relax restriction on MPU existence Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 08/25] ARM: NOMMU: fix head-nommu build for pre-ARMv7 CPUs Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 09/25] ARM: NOMMU: fix load of CONFIG_VECTORS_BASE Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 10/25] ARM: NOMMU: implement secondary_startup_arm Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 11/25] ARM: move arm_heavy_mb to MMU/noMMU neutral place Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 12/25] ARM: tlbflush: drop dependency on CONFIG_SMP Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 13/25] ARM: sleep: allow it to be build for R-class Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 14/25] ARM: setup: move call to erratum_a15_798181_init under CONFIG_MMU Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 15/25] ARM: kexec: disallow kexec for NOMMU builds Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 16/25] ARM: ep93xx: select ARM_PATCH_PHYS_VIRT for MMU builds only Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 17/25] ARM: omap: do not select HIGHMEM explicitly Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 18/25] ARM: sa1100: move CPU specific copy code under its own config Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 19/25] ARM: sa11x0: assabet: add dependency on MMU Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 20/25] ARM: i.MX: remove map_io callback Vladimir Murzin
2016-12-16 1:39 ` Shawn Guo [this message]
2016-12-02 15:05 ` [RFC v3 PATCH 21/25] PCI: tegra: limit to MMU build only Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 22/25] IB: add dependency on MMU Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 23/25] cnic: " Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 24/25] scsi: bnx2i: bnx2fc: " Vladimir Murzin
2016-12-02 15:05 ` [RFC v3 PATCH 25/25] ARM: Allow ARCH_MULTIPLATFORM to be selected for NOMMU Vladimir Murzin
2016-12-10 18:16 ` [RFC v3 PATCH 00/25] Allow NOMMU for MULTIPLATFORM Afzal Mohammed
2016-12-10 19:19 ` Arnd Bergmann
2016-12-11 6:33 ` Afzal Mohammed
2016-12-10 21:15 ` Peter Korsgaard
2016-12-11 7:01 ` Afzal Mohammed
2016-12-11 20:01 ` Peter Korsgaard
2016-12-12 7:07 ` mickael guene
2016-12-12 9:28 ` Vladimir Murzin
2016-12-12 9:44 ` mickael guene
2016-12-12 18:15 ` Afzal Mohammed
2016-12-13 17:10 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216013934.GA8787@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).