From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Fri, 16 Dec 2016 09:39:36 +0800 Subject: [RFC v3 PATCH 20/25] ARM: i.MX: remove map_io callback In-Reply-To: <1480691143-19845-21-git-send-email-vladimir.murzin@arm.com> References: <1480691143-19845-1-git-send-email-vladimir.murzin@arm.com> <1480691143-19845-21-git-send-email-vladimir.murzin@arm.com> Message-ID: <20161216013934.GA8787@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Dec 02, 2016 at 03:05:38PM +0000, Vladimir Murzin wrote: > There is no need to define map_io only for debug_ll_io_init() since it > is already called in devicemaps_init() if map_io is NULL. > > Apart from that, for NOMMU build debug_ll_io_init() is a nop which > leads to following error: > > CC arch/arm/mach-imx/mach-imx1.o > arch/arm/mach-imx/mach-imx1.c:40:13: error: 'debug_ll_io_init' undeclared here (not in a function) > .map_io = debug_ll_io_init, > ^ > make[1]: *** [arch/arm/mach-imx/mach-imx1.o] Error 1 > > Cc: Alexander Shiyan > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Fabio Estevam > Signed-off-by: Vladimir Murzin It looks like a cleanup which can be applied separately. Applied, thanks. Shawn > --- > arch/arm/mach-imx/mach-imx1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-imx/mach-imx1.c b/arch/arm/mach-imx/mach-imx1.c > index de5ab8d..3a8406e 100644 > --- a/arch/arm/mach-imx/mach-imx1.c > +++ b/arch/arm/mach-imx/mach-imx1.c > @@ -37,7 +37,6 @@ static void __init imx1_init_irq(void) > }; > > DT_MACHINE_START(IMX1_DT, "Freescale i.MX1 (Device Tree Support)") > - .map_io = debug_ll_io_init, > .init_early = imx1_init_early, > .init_irq = imx1_init_irq, > .dt_compat = imx1_dt_board_compat, > -- > 1.7.9.5 >