From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: zte: add overlay plane support
Date: Tue, 20 Dec 2016 20:04:52 +0800 [thread overview]
Message-ID: <20161220120451.GC8787@dragon> (raw)
In-Reply-To: <20161208155755.GY31595@intel.com>
Hi Ville,
On Thu, Dec 08, 2016 at 05:57:55PM +0200, Ville Syrj?l? wrote:
> On Thu, Dec 08, 2016 at 11:12:41AM +0800, Shawn Guo wrote:
> <snip>
> > +static void zx_vl_plane_atomic_update(struct drm_plane *plane,
> > + struct drm_plane_state *old_state)
> > +{
> > + struct zx_plane *zplane = to_zx_plane(plane);
> > + struct drm_framebuffer *fb = plane->state->fb;
> > + struct drm_gem_cma_object *cma_obj;
> > + void __iomem *layer = zplane->layer;
> > + void __iomem *hbsc = zplane->hbsc;
> > + void __iomem *paddr_reg;
> > + dma_addr_t paddr;
> > + u32 src_x, src_y, src_w, src_h;
> > + u32 dst_x, dst_y, dst_w, dst_h;
> > + uint32_t format;
> > + u32 fmt;
> > + int num_planes;
> > + int i;
> > +
> > + if (!fb)
> > + return;
> > +
> > + format = fb->pixel_format;
> > +
> > + src_x = plane->state->src_x >> 16;
> > + src_y = plane->state->src_y >> 16;
> > + src_w = plane->state->src_w >> 16;
> > + src_h = plane->state->src_h >> 16;
> > +
> > + dst_x = plane->state->crtc_x;
> > + dst_y = plane->state->crtc_y;
> > + dst_w = plane->state->crtc_w;
> > + dst_h = plane->state->crtc_h;
>
> This shouls use the clipped coordiantes.
Thanks for spotting this. I will fix it in v2.
Shawn
prev parent reply other threads:[~2016-12-20 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 3:12 [PATCH] drm: zte: add overlay plane support Shawn Guo
2016-12-08 15:57 ` Ville Syrjälä
2016-12-20 12:04 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220120451.GC8787@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).