From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Thu, 22 Dec 2016 11:47:47 +0100 Subject: [PATCH v4 11/12] arm64: dts: marvell: add sdhci support for Armada 7K/8K In-Reply-To: <20161222104502.GV14217@n2100.armlinux.org.uk> References: <2564fe18eb9cc8a0a1a3311cdf7e7141f35211bd.1481651244.git-series.gregory.clement@free-electrons.com> <20161222104502.GV14217@n2100.armlinux.org.uk> Message-ID: <20161222114747.734faa50@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Thu, 22 Dec 2016 10:45:02 +0000, Russell King - ARM Linux wrote: > On Tue, Dec 13, 2016 at 06:48:40PM +0100, Gregory CLEMENT wrote: > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > > index 7b6136182ad0..181e8c5de3bf 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > > @@ -229,6 +229,15 @@ > > > > }; > > > > + ap_sdhci0: sdhci at 6e0000 { > > + compatible = "marvell,armada-7000-sdhci"; > > + reg = <0x6e0000 0x300>; > > + interrupts = ; > > + clock-names = "core"; > > + clocks = <&cpm_syscon0 1 4>; > > This seems to be the wrong clock - how can the AP SDHCI core be connected > to the CPM syscon (which is on a different die.) Agreed. This cannot be the right clock. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com