* [PATCH v1] mtd: nand: tango: Update DT binding description
@ 2016-12-19 14:30 Marc Gonzalez
2016-12-29 18:23 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Marc Gonzalez @ 2016-12-19 14:30 UTC (permalink / raw)
To: linux-arm-kernel
Visually separate register ranges (address/size pairs) in reg prop.
Change DMA channel name, for consistency with other drivers.
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
Documentation/devicetree/bindings/mtd/tango-nand.txt | 6 +++---
drivers/mtd/nand/tango_nand.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt
index ad5a02f2ac8c..cd1bf2ac9055 100644
--- a/Documentation/devicetree/bindings/mtd/tango-nand.txt
+++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt
@@ -5,7 +5,7 @@ Required properties:
- compatible: "sigma,smp8758-nand"
- reg: address/size of nfc_reg, nfc_mem, and pbus_reg
- dmas: reference to the DMA channel used by the controller
-- dma-names: "nfc_sbox"
+- dma-names: "rxtx"
- clocks: reference to the system clock
- #address-cells: <1>
- #size-cells: <0>
@@ -17,9 +17,9 @@ Example:
nandc: nand-controller at 2c000 {
compatible = "sigma,smp8758-nand";
- reg = <0x2c000 0x30 0x2d000 0x800 0x20000 0x1000>;
+ reg = <0x2c000 0x30>, <0x2d000 0x800>, <0x20000 0x1000>;
dmas = <&dma0 3>;
- dma-names = "nfc_sbox";
+ dma-names = "rxtx";
clocks = <&clkgen SYS_CLK>;
#address-cells = <1>;
#size-cells = <0>;
diff --git a/drivers/mtd/nand/tango_nand.c b/drivers/mtd/nand/tango_nand.c
index cc23db64f0ca..51dc88d6b8da 100644
--- a/drivers/mtd/nand/tango_nand.c
+++ b/drivers/mtd/nand/tango_nand.c
@@ -629,7 +629,7 @@ static int tango_nand_probe(struct platform_device *pdev)
if (IS_ERR(clk))
return PTR_ERR(clk);
- nfc->chan = dma_request_chan(&pdev->dev, "nfc_sbox");
+ nfc->chan = dma_request_chan(&pdev->dev, "rxtx");
if (IS_ERR(nfc->chan))
return PTR_ERR(nfc->chan);
--
2.10.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1] mtd: nand: tango: Update DT binding description
2016-12-19 14:30 [PATCH v1] mtd: nand: tango: Update DT binding description Marc Gonzalez
@ 2016-12-29 18:23 ` Boris Brezillon
2017-01-03 8:34 ` Marc Gonzalez
0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2016-12-29 18:23 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 19 Dec 2016 15:30:12 +0100
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> wrote:
> Visually separate register ranges (address/size pairs) in reg prop.
> Change DMA channel name, for consistency with other drivers.
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
> Documentation/devicetree/bindings/mtd/tango-nand.txt | 6 +++---
> drivers/mtd/nand/tango_nand.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt
> index ad5a02f2ac8c..cd1bf2ac9055 100644
> --- a/Documentation/devicetree/bindings/mtd/tango-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt
> @@ -5,7 +5,7 @@ Required properties:
> - compatible: "sigma,smp8758-nand"
> - reg: address/size of nfc_reg, nfc_mem, and pbus_reg
> - dmas: reference to the DMA channel used by the controller
> -- dma-names: "nfc_sbox"
> +- dma-names: "rxtx"
You probably want to fix the driver accordingly ;-).
> - clocks: reference to the system clock
> - #address-cells: <1>
> - #size-cells: <0>
> @@ -17,9 +17,9 @@ Example:
>
> nandc: nand-controller at 2c000 {
> compatible = "sigma,smp8758-nand";
> - reg = <0x2c000 0x30 0x2d000 0x800 0x20000 0x1000>;
> + reg = <0x2c000 0x30>, <0x2d000 0x800>, <0x20000 0x1000>;
> dmas = <&dma0 3>;
> - dma-names = "nfc_sbox";
> + dma-names = "rxtx";
> clocks = <&clkgen SYS_CLK>;
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/drivers/mtd/nand/tango_nand.c b/drivers/mtd/nand/tango_nand.c
> index cc23db64f0ca..51dc88d6b8da 100644
> --- a/drivers/mtd/nand/tango_nand.c
> +++ b/drivers/mtd/nand/tango_nand.c
> @@ -629,7 +629,7 @@ static int tango_nand_probe(struct platform_device *pdev)
> if (IS_ERR(clk))
> return PTR_ERR(clk);
>
> - nfc->chan = dma_request_chan(&pdev->dev, "nfc_sbox");
> + nfc->chan = dma_request_chan(&pdev->dev, "rxtx");
> if (IS_ERR(nfc->chan))
> return PTR_ERR(nfc->chan);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] mtd: nand: tango: Update DT binding description
2016-12-29 18:23 ` Boris Brezillon
@ 2017-01-03 8:34 ` Marc Gonzalez
2017-01-03 8:48 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Marc Gonzalez @ 2017-01-03 8:34 UTC (permalink / raw)
To: linux-arm-kernel
On 29/12/2016 19:23, Boris Brezillon wrote:
> On Mon, 19 Dec 2016 15:30:12 +0100
> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> wrote:
>
>> Visually separate register ranges (address/size pairs) in reg prop.
>> Change DMA channel name, for consistency with other drivers.
>>
>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>> ---
>> Documentation/devicetree/bindings/mtd/tango-nand.txt | 6 +++---
>> drivers/mtd/nand/tango_nand.c | 2 +-
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt
>> index ad5a02f2ac8c..cd1bf2ac9055 100644
>> --- a/Documentation/devicetree/bindings/mtd/tango-nand.txt
>> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt
>> @@ -5,7 +5,7 @@ Required properties:
>> - compatible: "sigma,smp8758-nand"
>> - reg: address/size of nfc_reg, nfc_mem, and pbus_reg
>> - dmas: reference to the DMA channel used by the controller
>> -- dma-names: "nfc_sbox"
>> +- dma-names: "rxtx"
>
> You probably want to fix the driver accordingly ;-).
I'm confused...
Did you miss the change (below) to drivers/mtd/nand/tango_nand.c
fixing the driver as well as the documentation?
>> - clocks: reference to the system clock
>> - #address-cells: <1>
>> - #size-cells: <0>
>> @@ -17,9 +17,9 @@ Example:
>>
>> nandc: nand-controller at 2c000 {
>> compatible = "sigma,smp8758-nand";
>> - reg = <0x2c000 0x30 0x2d000 0x800 0x20000 0x1000>;
>> + reg = <0x2c000 0x30>, <0x2d000 0x800>, <0x20000 0x1000>;
>> dmas = <&dma0 3>;
>> - dma-names = "nfc_sbox";
>> + dma-names = "rxtx";
>> clocks = <&clkgen SYS_CLK>;
>> #address-cells = <1>;
>> #size-cells = <0>;
>> diff --git a/drivers/mtd/nand/tango_nand.c b/drivers/mtd/nand/tango_nand.c
>> index cc23db64f0ca..51dc88d6b8da 100644
>> --- a/drivers/mtd/nand/tango_nand.c
>> +++ b/drivers/mtd/nand/tango_nand.c
>> @@ -629,7 +629,7 @@ static int tango_nand_probe(struct platform_device *pdev)
>> if (IS_ERR(clk))
>> return PTR_ERR(clk);
>>
>> - nfc->chan = dma_request_chan(&pdev->dev, "nfc_sbox");
>> + nfc->chan = dma_request_chan(&pdev->dev, "rxtx");
>> if (IS_ERR(nfc->chan))
>> return PTR_ERR(nfc->chan);
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] mtd: nand: tango: Update DT binding description
2017-01-03 8:34 ` Marc Gonzalez
@ 2017-01-03 8:48 ` Boris Brezillon
0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2017-01-03 8:48 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 3 Jan 2017 09:34:59 +0100
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> wrote:
> On 29/12/2016 19:23, Boris Brezillon wrote:
> > On Mon, 19 Dec 2016 15:30:12 +0100
> > Marc Gonzalez <marc_gonzalez@sigmadesigns.com> wrote:
> >
> >> Visually separate register ranges (address/size pairs) in reg prop.
> >> Change DMA channel name, for consistency with other drivers.
> >>
> >> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> >> ---
> >> Documentation/devicetree/bindings/mtd/tango-nand.txt | 6 +++---
> >> drivers/mtd/nand/tango_nand.c | 2 +-
> >> 2 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt
> >> index ad5a02f2ac8c..cd1bf2ac9055 100644
> >> --- a/Documentation/devicetree/bindings/mtd/tango-nand.txt
> >> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt
> >> @@ -5,7 +5,7 @@ Required properties:
> >> - compatible: "sigma,smp8758-nand"
> >> - reg: address/size of nfc_reg, nfc_mem, and pbus_reg
> >> - dmas: reference to the DMA channel used by the controller
> >> -- dma-names: "nfc_sbox"
> >> +- dma-names: "rxtx"
> >
> > You probably want to fix the driver accordingly ;-).
>
> I'm confused...
>
> Did you miss the change (below) to drivers/mtd/nand/tango_nand.c
> fixing the driver as well as the documentation?
Indeed, I missed it. The patch is fine, I'll queue it for 4.10-rcX.
Sorry for the noise.
BTW, I heard you had some fixes for 4.10. Feel free to send them.
Regards,
Boris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-03 8:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-19 14:30 [PATCH v1] mtd: nand: tango: Update DT binding description Marc Gonzalez
2016-12-29 18:23 ` Boris Brezillon
2017-01-03 8:34 ` Marc Gonzalez
2017-01-03 8:48 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).