From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v5 1/3] ARM: mxs: add saif clkmux functions
Date: Fri, 18 Nov 2011 09:29:55 +0100 [thread overview]
Message-ID: <20166.6019.921262.50184@ipc1.ka-ro> (raw)
In-Reply-To: <65EE16ACC360FA4D99C96DC085B3F7722E47BC@039-SN1MPN1-002.039d.mgd.msft.net>
Hi,
Dong Aisheng-B29396 writes:
[...]
> > > +#define HW_DIGCTL_CTRL 0x0
> > > +#define BP_DIGCTL_CTRL_SAIF_CLKMUX (10)
> >
> > Do you need the parenthesis above ?
> >
> I'm not sure about his.
> HW_DIGCTL_CTRL is the register offset.
> Do we have to do this?
>
You need parens around macro parameters that are used in an expression
inside the macro. But you never ever need to enclose a bare number in
parens!
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2011-11-18 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 9:30 [PATCH v5 0/3] ARM: mxs: add recording support for saif Dong Aisheng
2011-11-11 9:30 ` [PATCH v5 1/3] ARM: mxs: add saif clkmux functions Dong Aisheng
2011-11-18 4:54 ` [alsa-devel] " Marek Vasut
2011-11-18 6:28 ` Dong Aisheng-B29396
2011-11-18 8:29 ` Lothar Waßmann [this message]
2011-11-18 8:57 ` Dong Aisheng-B29396
2011-11-11 9:30 ` [PATCH v5 2/3] ARM: mx28evk: add platform data for saif Dong Aisheng
2011-11-18 4:58 ` [alsa-devel] " Marek Vasut
2011-11-18 6:40 ` Dong Aisheng-B29396
2011-11-11 9:30 ` [PATCH v5 3/3] ARM: mx28evk: set a initial clock rate " Dong Aisheng
2011-11-18 3:51 ` [PATCH v5 0/3] ARM: mxs: add recording support " Dong Aisheng-B29396
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20166.6019.921262.50184@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox