From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] sched: Remove set_task_state()
Date: Tue, 3 Jan 2017 10:24:59 +0100 [thread overview]
Message-ID: <20170103092459.GB3093@worktop> (raw)
In-Reply-To: <1483121873-21528-1-git-send-email-dave@stgolabs.net>
On Fri, Dec 30, 2016 at 10:17:53AM -0800, Davidlohr Bueso wrote:
> - set_task_state(current, TASK_RUNNING);
> + set_current_state(TASK_RUNNING);
Obviously good.
> - set_task_state(tsk, TASK_UNINTERRUPTIBLE);
> + set_current_state(TASK_UNINTERRUPTIBLE);
Not so much..
So while I fully support this move, should we not first clean up the
code and also remove all the local 'tsk = current' variables such that
all replacements end up being obvious?
In any case, would be good to hear from arm64 folks.
next prev parent reply other threads:[~2017-01-03 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 18:17 [RFC PATCH] sched: Remove set_task_state() Davidlohr Bueso
2017-01-03 9:24 ` Peter Zijlstra [this message]
2017-01-03 10:04 ` Mark Rutland
2017-01-03 18:06 ` Davidlohr Bueso
2017-01-03 18:13 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103092459.GB3093@worktop \
--to=peterz@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).