public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for TM2
Date: Tue, 3 Jan 2017 18:59:20 +0200	[thread overview]
Message-ID: <20170103165920.4tmpr3skgzb2dfah@kozik-lap> (raw)
In-Reply-To: <1483430237-26823-3-git-send-email-jcsing.lee@samsung.com>

On Tue, Jan 03, 2017 at 04:57:15PM +0900, Jaechul Lee wrote:
> This patch adds support for the TM2 touch key and led
> functionlity.
> 
> The driver interfaces with userspace through an input device and
> reports KEY_PHONE and KEY_BACK event types. LED brightness can be
> controlled by "/sys/class/leds/tm2-touchkey/brightness".
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
>  drivers/input/keyboard/Kconfig        |  11 ++
>  drivers/input/keyboard/Makefile       |   1 +
>  drivers/input/keyboard/tm2-touchkey.c | 326 ++++++++++++++++++++++++++++++++++
>  3 files changed, 338 insertions(+)
>  create mode 100644 drivers/input/keyboard/tm2-touchkey.c
> 
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index cbd75cf..72c0ba1 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -666,6 +666,17 @@ config KEYBOARD_TC3589X
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called tc3589x-keypad.
>  
> +config KEYBOARD_TM2_TOUCHKEY
> +	tristate "tm2-touchkey support"
> +	depends on I2C
> +	help
> +	  Say Y here to enable the tm2-touchkey.

The ending full stop is not needed.

> +	  touchkey driver for tm2. This driver can enable
> +	  the interrupt and make input events and control led brightness.

This sentence needs improvements. How about just:
"Beside input device, this driver provides also brightness control for
LEDs on touch keys."

Best regards,
Krzysztof

  parent reply	other threads:[~2017-01-03 16:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170103075733epcas5p48985c789a816f1f2eae84c52e070cc14@epcas5p4.samsung.com>
2017-01-03  7:57 ` [PATCH 0/4] Add touch key driver support for TM2 Jaechul Lee
2017-01-03  7:57   ` [PATCH 1/4] input: Add support for the tm2 touchkey device driver Jaechul Lee
2017-01-03 12:26     ` Javier Martinez Canillas
2017-01-04 14:15     ` Rob Herring
2017-01-03  7:57   ` [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for TM2 Jaechul Lee
2017-01-03 13:11     ` Javier Martinez Canillas
2017-01-03 18:56       ` Dmitry Torokhov
2017-01-03 16:59     ` Krzysztof Kozlowski [this message]
2017-01-03  7:57   ` [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other Jaechul Lee
2017-01-03  8:16     ` Andi Shyti
2017-01-03  8:27     ` Krzysztof Kozlowski
2017-01-03  9:58       ` Andi Shyti
2017-01-03 10:01         ` Krzysztof Kozlowski
2017-01-03 10:25           ` Andi Shyti
2017-01-03 11:47             ` Chanwoo Choi
2017-01-03 11:55               ` Andi Shyti
2017-01-03 12:15                 ` Javier Martinez Canillas
2017-01-03 14:40                   ` Andi Shyti
2017-01-03 14:57                     ` Javier Martinez Canillas
2017-01-03 15:29                     ` Chanwoo Choi
2017-01-03 16:31                       ` Krzysztof Kozlowski
2017-01-03 16:41             ` Krzysztof Kozlowski
2017-01-03  7:57   ` [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node Jaechul Lee
2017-01-03 13:14     ` Javier Martinez Canillas
2017-01-03 16:49     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170103165920.4tmpr3skgzb2dfah@kozik-lap \
    --to=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox