From mboxrd@z Thu Jan 1 00:00:00 1970 From: krzk@kernel.org (Krzysztof Kozlowski) Date: Tue, 3 Jan 2017 21:20:08 +0200 Subject: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation In-Reply-To: References: <20161216090625.2235668-1-arnd@arndb.de> <20170102070903.GC8588@vireshk-i7> <20170102173651.hvsfalhcmisv4mtv@kozik-lap> Message-ID: <20170103192008.3taowqq4kjggv6fh@kozik-lap> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 02, 2017 at 10:19:29PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 2, 2017 at 6:36 PM, Krzysztof Kozlowski wrote: > > On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote: > >> On 16-12-16, 10:06, Arnd Bergmann wrote: > >> > s3c64xx_cpufreq_config_regulator is incorrectly annotated > >> > as __init, since the caller is also not init: > >> > > >> > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() > >> > > >> > With modern gcc versions, the function gets inline, so we don't > >> > see the warning, this only happens with gcc-4.6 and older. > >> > > >> > Signed-off-by: Arnd Bergmann > >> > --- > >> > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c > >> > index 176e84cc3991..0cb9040eca49 100644 > >> > --- a/drivers/cpufreq/s3c64xx-cpufreq.c > >> > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c > >> > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy, > >> > } > >> > > >> > #ifdef CONFIG_REGULATOR > >> > -static void __init s3c64xx_cpufreq_config_regulator(void) > >> > +static void s3c64xx_cpufreq_config_regulator(void) > >> > { > >> > int count, v, i, found; > >> > struct cpufreq_frequency_table *freq; > >> > >> Acked-by: Viresh Kumar > > > > Rafael, > > Are you going to pick it up? > > I thought I did, didn't I? Right, you did. I missed that. Thanks! Best regards, Krzysztof