From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other
Date: Thu, 05 Jan 2017 18:33:08 +0900 [thread overview]
Message-ID: <20170105093308.ixefvxrfhhu2u2ir@gangnam.samsung> (raw)
In-Reply-To: <586E11FF.9080707@samsung.com>
Hi Chanwoo,
> >> I add the some comment as following:
> >> - ldo23/25/31/38 have the different value between tm2 and tm2e.
> >
> > Thanks for pointing this out. I planned to do this already in a
> > following patch as for now I think it's out from the scope of this
> > particular patch.
>
> I think it is very simple work. If you want to make the common.dtsi,
> I think that you have to separate the different thing on each exynos5433-tm2X.dts.
>
> >
> >> - The patch[1] was alread posted. I think you better to rebase this patch on patch[1].
> >> [1] https://patchwork.kernel.org/patch/9491769/
> >> - ("ARM64: dts: TM2: comply to the samsung pinctrl naming convention")
> >
> > Yes, I also thought about this, but I didn't know whether it was
> > already picked by anyone. I didn't want to stop Jaechul that's
> > why I was planning to rebase the other rather than this.
> > But you are right, because some bits of the other patches I know
> > that have been merged. Thank you!
> >
> > Krzysztof, do you mind if I send patch 3 as a reply to this
> > e-mail? The changes should not affect patch 4, anyway.
>
> No, If exynos5433-tm2.dts includes the different value of regulator,
> patch4 might be implemented based on patch3.
OK, I will re-work the patch 3 with the regulators and generate
again patch 4.
Thanks,
Andi
next prev parent reply other threads:[~2017-01-05 9:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170105082715epcas1p10e0820a792ba9d89cd165299d6602654@epcas1p1.samsung.com>
2017-01-05 8:27 ` [PATCH v2 0/4] Add touch key driver support for TM2 Jaechul Lee
2017-01-05 8:27 ` [PATCH v2 1/4] input: Add support for the tm2 touchkey device driver Jaechul Lee
2017-01-05 8:27 ` [PATCH v2 2/4] input: tm2-touchkey: Add touchkey driver support for TM2 Jaechul Lee
2017-01-05 8:27 ` [PATCH v2 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other Jaechul Lee
2017-01-05 9:13 ` Chanwoo Choi
2017-01-05 9:23 ` Andi Shyti
2017-01-05 9:29 ` Chanwoo Choi
2017-01-05 9:33 ` Andi Shyti [this message]
2017-01-05 18:37 ` Krzysztof Kozlowski
2017-01-05 9:45 ` Chanwoo Choi
2017-01-05 8:27 ` [PATCH v2 4/4] arm64: dts: exynos: Add tm2 touchkey node Jaechul Lee
2017-01-05 18:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105093308.ixefvxrfhhu2u2ir@gangnam.samsung \
--to=andi.shyti@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox