From mboxrd@z Thu Jan 1 00:00:00 1970 From: joro@8bytes.org (Joerg Roedel) Date: Fri, 6 Jan 2017 11:59:45 +0100 Subject: [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies In-Reply-To: <1483643086-2883-2-git-send-email-eric.auger@redhat.com> References: <1483643086-2883-1-git-send-email-eric.auger@redhat.com> <1483643086-2883-2-git-send-email-eric.auger@redhat.com> Message-ID: <20170106105945.GK17255@8bytes.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 05, 2017 at 07:04:29PM +0000, Eric Auger wrote: > struct iommu_dma_cookie { > - struct iova_domain iovad; > - struct list_head msi_page_list; > - spinlock_t msi_lock; > + union { > + struct iova_domain iovad; > + dma_addr_t msi_iova; > + }; > + struct list_head msi_page_list; > + spinlock_t msi_lock; > + enum iommu_dma_cookie_type type; Please move the type to the beginning of the struct and add a comment how the type relates to the union. Joerg