* [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
@ 2017-01-07 8:41 Krzysztof Kozlowski
2017-01-07 8:41 ` [PATCH 2/2] usb: host: ohci-exynos: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-07 8:41 UTC (permalink / raw)
To: linux-arm-kernel
Returning from for_each_available_child_of_node() loop requires cleaning
up node refcount. Error paths lacked it so for example in case of
deferred probe, the refcount of phy node was left increased.
Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/usb/host/ehci-exynos.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index 42e5b66353ef..7a603f66a9bc 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -77,10 +77,12 @@ static int exynos_ehci_get_phy(struct device *dev,
if (IS_ERR(phy)) {
ret = PTR_ERR(phy);
if (ret == -EPROBE_DEFER) {
+ of_node_put(child);
return ret;
} else if (ret != -ENOSYS && ret != -ENODEV) {
dev_err(dev,
"Error retrieving usb2 phy: %d\n", ret);
+ of_node_put(child);
return ret;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] usb: host: ohci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
2017-01-07 8:41 [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths Krzysztof Kozlowski
@ 2017-01-07 8:41 ` Krzysztof Kozlowski
2017-01-09 15:40 ` Javier Martinez Canillas
2017-01-09 16:05 ` Alan Stern
2017-01-09 15:39 ` [PATCH 1/2] usb: host: ehci-exynos: " Javier Martinez Canillas
2017-01-09 16:05 ` Alan Stern
2 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-07 8:41 UTC (permalink / raw)
To: linux-arm-kernel
Returning from for_each_available_child_of_node() loop requires cleaning
up node refcount. Error paths lacked it so for example in case of
deferred probe, the refcount of phy node was left increased.
Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/usb/host/ohci-exynos.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
index 2cd105be7319..6865b919403f 100644
--- a/drivers/usb/host/ohci-exynos.c
+++ b/drivers/usb/host/ohci-exynos.c
@@ -66,10 +66,12 @@ static int exynos_ohci_get_phy(struct device *dev,
if (IS_ERR(phy)) {
ret = PTR_ERR(phy);
if (ret == -EPROBE_DEFER) {
+ of_node_put(child);
return ret;
} else if (ret != -ENOSYS && ret != -ENODEV) {
dev_err(dev,
"Error retrieving usb2 phy: %d\n", ret);
+ of_node_put(child);
return ret;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] usb: host: ohci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
2017-01-07 8:41 ` [PATCH 2/2] usb: host: ohci-exynos: " Krzysztof Kozlowski
@ 2017-01-09 15:40 ` Javier Martinez Canillas
2017-01-09 16:05 ` Alan Stern
1 sibling, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-01-09 15:40 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 01/07/2017 05:41 AM, Krzysztof Kozlowski wrote:
> Returning from for_each_available_child_of_node() loop requires cleaning
> up node refcount. Error paths lacked it so for example in case of
> deferred probe, the refcount of phy node was left increased.
>
> Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/2] usb: host: ohci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
2017-01-07 8:41 ` [PATCH 2/2] usb: host: ohci-exynos: " Krzysztof Kozlowski
2017-01-09 15:40 ` Javier Martinez Canillas
@ 2017-01-09 16:05 ` Alan Stern
1 sibling, 0 replies; 6+ messages in thread
From: Alan Stern @ 2017-01-09 16:05 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 7 Jan 2017, Krzysztof Kozlowski wrote:
> Returning from for_each_available_child_of_node() loop requires cleaning
> up node refcount. Error paths lacked it so for example in case of
> deferred probe, the refcount of phy node was left increased.
>
> Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/usb/host/ohci-exynos.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
> index 2cd105be7319..6865b919403f 100644
> --- a/drivers/usb/host/ohci-exynos.c
> +++ b/drivers/usb/host/ohci-exynos.c
> @@ -66,10 +66,12 @@ static int exynos_ohci_get_phy(struct device *dev,
> if (IS_ERR(phy)) {
> ret = PTR_ERR(phy);
> if (ret == -EPROBE_DEFER) {
> + of_node_put(child);
> return ret;
> } else if (ret != -ENOSYS && ret != -ENODEV) {
> dev_err(dev,
> "Error retrieving usb2 phy: %d\n", ret);
> + of_node_put(child);
> return ret;
> }
> }
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
2017-01-07 8:41 [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths Krzysztof Kozlowski
2017-01-07 8:41 ` [PATCH 2/2] usb: host: ohci-exynos: " Krzysztof Kozlowski
@ 2017-01-09 15:39 ` Javier Martinez Canillas
2017-01-09 16:05 ` Alan Stern
2 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-01-09 15:39 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 01/07/2017 05:41 AM, Krzysztof Kozlowski wrote:
> Returning from for_each_available_child_of_node() loop requires cleaning
> up node refcount. Error paths lacked it so for example in case of
> deferred probe, the refcount of phy node was left increased.
>
> Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
2017-01-07 8:41 [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths Krzysztof Kozlowski
2017-01-07 8:41 ` [PATCH 2/2] usb: host: ohci-exynos: " Krzysztof Kozlowski
2017-01-09 15:39 ` [PATCH 1/2] usb: host: ehci-exynos: " Javier Martinez Canillas
@ 2017-01-09 16:05 ` Alan Stern
2 siblings, 0 replies; 6+ messages in thread
From: Alan Stern @ 2017-01-09 16:05 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 7 Jan 2017, Krzysztof Kozlowski wrote:
> Returning from for_each_available_child_of_node() loop requires cleaning
> up node refcount. Error paths lacked it so for example in case of
> deferred probe, the refcount of phy node was left increased.
>
> Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/usb/host/ehci-exynos.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> index 42e5b66353ef..7a603f66a9bc 100644
> --- a/drivers/usb/host/ehci-exynos.c
> +++ b/drivers/usb/host/ehci-exynos.c
> @@ -77,10 +77,12 @@ static int exynos_ehci_get_phy(struct device *dev,
> if (IS_ERR(phy)) {
> ret = PTR_ERR(phy);
> if (ret == -EPROBE_DEFER) {
> + of_node_put(child);
> return ret;
> } else if (ret != -ENOSYS && ret != -ENODEV) {
> dev_err(dev,
> "Error retrieving usb2 phy: %d\n", ret);
> + of_node_put(child);
> return ret;
> }
> }
>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-09 16:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-07 8:41 [PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths Krzysztof Kozlowski
2017-01-07 8:41 ` [PATCH 2/2] usb: host: ohci-exynos: " Krzysztof Kozlowski
2017-01-09 15:40 ` Javier Martinez Canillas
2017-01-09 16:05 ` Alan Stern
2017-01-09 15:39 ` [PATCH 1/2] usb: host: ehci-exynos: " Javier Martinez Canillas
2017-01-09 16:05 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).