linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] Allwinner conversion to generic pin properties
@ 2016-12-26  7:42 Maxime Ripard
  2017-01-10  3:21 ` Olof Johansson
  0 siblings, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2016-12-26  7:42 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Arnd, Olof,

Like we discussed it last time, here is a pull request with the
convertion patches to the generic pin properties for 4.10.

Thanks,
Maxime

The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

  Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

are available in the git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-generic-pinconf-for-4.10

for you to fetch changes up to 1edcd36fcb48fe841bcc62eda36c105037d9583c:

  ARM: sunxi: Convert pinctrl nodes to generic bindings (2016-12-26 08:27:11 +0100)

----------------------------------------------------------------
Allwinner conversion to generic pin muxing properties

Here is a list of patches that converts the current DT to the generic pin
control and muxing properties, now that the pinctrl driver supports it.

----------------------------------------------------------------
Maxime Ripard (3):
      ARM: sunxi: Remove useless allwinner,drive property
      ARM: sunxi: Remove useless allwinner,pull property
      ARM: sunxi: Convert pinctrl nodes to generic bindings

 arch/arm/boot/dts/sun4i-a10-a1000.dts              |  12 +-
 arch/arm/boot/dts/sun4i-a10-ba10-tvbox.dts         |   2 +-
 arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts    |  14 +-
 arch/arm/boot/dts/sun4i-a10-cubieboard.dts         |  14 +-
 arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts   |  38 ++-
 arch/arm/boot/dts/sun4i-a10-gemei-g9.dts           |   6 +-
 arch/arm/boot/dts/sun4i-a10-hackberry.dts          |  12 +-
 arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts       |  16 +-
 arch/arm/boot/dts/sun4i-a10-inet1.dts              |  26 +-
 arch/arm/boot/dts/sun4i-a10-inet97fv2.dts          |  14 +-
 arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts       |  29 +--
 arch/arm/boot/dts/sun4i-a10-jesurun-q5.dts         |  12 +-
 arch/arm/boot/dts/sun4i-a10-marsboard.dts          |  13 +-
 arch/arm/boot/dts/sun4i-a10-mini-xplus.dts         |   2 +-
 arch/arm/boot/dts/sun4i-a10-mk802.dts              |  18 +-
 arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts     |  27 +-
 arch/arm/boot/dts/sun4i-a10-pcduino.dts            |  19 +-
 arch/arm/boot/dts/sun4i-a10-pcduino2.dts           |   6 +-
 arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts   |  32 +--
 arch/arm/boot/dts/sun4i-a10.dtsi                   | 169 +++++--------
 arch/arm/boot/dts/sun5i-a10s-auxtek-t003.dts       |  18 +-
 arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts       |  29 +--
 arch/arm/boot/dts/sun5i-a10s-mk802.dts             |  19 +-
 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts   |  36 ++-
 arch/arm/boot/dts/sun5i-a10s-r7-tv-dongle.dts      |  20 +-
 arch/arm/boot/dts/sun5i-a10s-wobo-i5.dts           |  21 +-
 arch/arm/boot/dts/sun5i-a10s.dtsi                  |  43 ++--
 .../boot/dts/sun5i-a13-empire-electronix-d709.dts  |  23 +-
 arch/arm/boot/dts/sun5i-a13-hsg-h702.dts           |  22 +-
 arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts    |  40 ++-
 arch/arm/boot/dts/sun5i-a13-olinuxino.dts          |  36 ++-
 arch/arm/boot/dts/sun5i-a13-utoo-p66.dts           |  11 +-
 arch/arm/boot/dts/sun5i-a13.dtsi                   |  24 +-
 arch/arm/boot/dts/sun5i-gr8-chip-pro.dts           |  12 +-
 arch/arm/boot/dts/sun5i-gr8-evb.dts                |  24 +-
 arch/arm/boot/dts/sun5i-gr8.dtsi                   | 122 ++++-----
 arch/arm/boot/dts/sun5i-r8-chip.dts                |  27 +-
 .../boot/dts/sun5i-reference-design-tablet.dtsi    |  33 +--
 arch/arm/boot/dts/sun5i.dtsi                       |  75 +++---
 arch/arm/boot/dts/sun6i-a31-app4-evb1.dts          |   6 +-
 arch/arm/boot/dts/sun6i-a31-colombus.dts           |  22 +-
 arch/arm/boot/dts/sun6i-a31-hummingbird.dts        |  23 +-
 arch/arm/boot/dts/sun6i-a31-i7.dts                 |  19 +-
 arch/arm/boot/dts/sun6i-a31-m9.dts                 |  19 +-
 arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts   |  19 +-
 arch/arm/boot/dts/sun6i-a31.dtsi                   |  98 +++-----
 arch/arm/boot/dts/sun6i-a31s-primo81.dts           |  20 +-
 arch/arm/boot/dts/sun6i-a31s-sina31s.dts           |  13 +-
 arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts   |  29 +--
 .../dts/sun6i-a31s-yones-toptech-bs1078-v2.dts     |   9 +-
 .../boot/dts/sun6i-reference-design-tablet.dtsi    |  14 +-
 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts   |  27 +-
 arch/arm/boot/dts/sun7i-a20-bananapi.dts           |  26 +-
 arch/arm/boot/dts/sun7i-a20-bananapro.dts          |  37 +--
 arch/arm/boot/dts/sun7i-a20-cubieboard2.dts        |  13 +-
 arch/arm/boot/dts/sun7i-a20-cubietruck.dts         |  38 +--
 arch/arm/boot/dts/sun7i-a20-hummingbird.dts        |  24 +-
 arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts          |  26 +-
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts         |   7 +-
 arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts          |  30 +--
 arch/arm/boot/dts/sun7i-a20-m3.dts                 |   6 +-
 arch/arm/boot/dts/sun7i-a20-mk808c.dts             |  12 +-
 arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts     |  32 +--
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts     |  27 +-
 .../boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts    |   6 +-
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts    |  33 +--
 arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts    |  28 +--
 arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts      |  45 ++--
 arch/arm/boot/dts/sun7i-a20-orangepi.dts           |  38 ++-
 arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts      |  25 +-
 arch/arm/boot/dts/sun7i-a20-pcduino3.dts           |  21 +-
 arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts     |  25 +-
 arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts   |  13 +-
 arch/arm/boot/dts/sun7i-a20.dtsi                   | 277 ++++++++-------------
 arch/arm/boot/dts/sun8i-a23-a33.dtsi               |  99 +++-----
 arch/arm/boot/dts/sun8i-a23-evb.dts                |   7 +-
 .../boot/dts/sun8i-a23-polaroid-mid2407pxe03.dts   |   8 +-
 .../boot/dts/sun8i-a23-polaroid-mid2809pxe04.dts   |   8 +-
 arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts     |   9 +-
 arch/arm/boot/dts/sun8i-a33-olinuxino.dts          |  18 +-
 arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts     |  11 +-
 arch/arm/boot/dts/sun8i-a33.dtsi                   |   6 +-
 arch/arm/boot/dts/sun8i-a83t.dtsi                  |  21 +-
 arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts    |  18 +-
 arch/arm/boot/dts/sun8i-h3-nanopi.dtsi             |  18 +-
 arch/arm/boot/dts/sun8i-h3-orangepi-2.dts          |  26 +-
 arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts       |  18 +-
 arch/arm/boot/dts/sun8i-h3-orangepi-one.dts        |  18 +-
 arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts    |   4 +-
 arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts         |  18 +-
 arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts       |  10 +-
 arch/arm/boot/dts/sun8i-h3.dtsi                    | 104 +++-----
 arch/arm/boot/dts/sun8i-q8-common.dtsi             |   9 +-
 arch/arm/boot/dts/sun8i-r16-parrot.dts             |  36 ++-
 .../boot/dts/sun8i-reference-design-tablet.dtsi    |  26 +-
 arch/arm/boot/dts/sun9i-a80-cubieboard4.dts        |  23 +-
 arch/arm/boot/dts/sun9i-a80-optimus.dts            |  41 ++-
 arch/arm/boot/dts/sun9i-a80.dtsi                   |  61 ++---
 arch/arm/boot/dts/sunxi-common-regulators.dtsi     |  24 +-
 99 files changed, 1081 insertions(+), 1783 deletions(-)

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161226/d0e3042f/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] Allwinner conversion to generic pin properties
  2016-12-26  7:42 [GIT PULL] Allwinner conversion to generic pin properties Maxime Ripard
@ 2017-01-10  3:21 ` Olof Johansson
  2017-01-10 17:34   ` Maxime Ripard
  2017-01-19 18:35   ` Maxime Ripard
  0 siblings, 2 replies; 6+ messages in thread
From: Olof Johansson @ 2017-01-10  3:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Mon, Dec 26, 2016 at 08:42:14AM +0100, Maxime Ripard wrote:
> Hi Arnd, Olof,
> 
> Like we discussed it last time, here is a pull request with the
> convertion patches to the generic pin properties for 4.10.
> 
> Thanks,
> Maxime
> 
> The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:
> 
>   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)
> 
> are available in the git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-generic-pinconf-for-4.10
> 
> for you to fetch changes up to 1edcd36fcb48fe841bcc62eda36c105037d9583c:
> 
>   ARM: sunxi: Convert pinctrl nodes to generic bindings (2016-12-26 08:27:11 +0100)
> 
> ----------------------------------------------------------------
> Allwinner conversion to generic pin muxing properties
> 
> Here is a list of patches that converts the current DT to the generic pin
> control and muxing properties, now that the pinctrl driver supports it.

I dropped the ball on this over the holidays for a few reasons, none of them
good. Unfortunately we're at -rc3+ now, so I've queued this up in next/dt for
v4.11 at this point. Hope that's alright.

You might want to use your branch as a base for new DT contents for
v4.11 in case it ends up being conflict-heavy, which would work fine at our
end.


Regards,

-Olof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] Allwinner conversion to generic pin properties
  2017-01-10  3:21 ` Olof Johansson
@ 2017-01-10 17:34   ` Maxime Ripard
  2017-01-19 18:35   ` Maxime Ripard
  1 sibling, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2017-01-10 17:34 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof,

On Mon, Jan 09, 2017 at 07:21:20PM -0800, Olof Johansson wrote:
> Hi,
> 
> On Mon, Dec 26, 2016 at 08:42:14AM +0100, Maxime Ripard wrote:
> > Hi Arnd, Olof,
> > 
> > Like we discussed it last time, here is a pull request with the
> > convertion patches to the generic pin properties for 4.10.
> > 
> > Thanks,
> > Maxime
> > 
> > The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:
> > 
> >   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)
> > 
> > are available in the git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-generic-pinconf-for-4.10
> > 
> > for you to fetch changes up to 1edcd36fcb48fe841bcc62eda36c105037d9583c:
> > 
> >   ARM: sunxi: Convert pinctrl nodes to generic bindings (2016-12-26 08:27:11 +0100)
> > 
> > ----------------------------------------------------------------
> > Allwinner conversion to generic pin muxing properties
> > 
> > Here is a list of patches that converts the current DT to the generic pin
> > control and muxing properties, now that the pinctrl driver supports it.
> 
> I dropped the ball on this over the holidays for a few reasons, none of them
> good. Unfortunately we're at -rc3+ now, so I've queued this up in next/dt for
> v4.11 at this point. Hope that's alright.

It is, there's no rush.

> You might want to use your branch as a base for new DT contents for
> v4.11 in case it ends up being conflict-heavy, which would work fine at our
> end.

There might be one minor (and trivial) conflict with one of the fix
I'll send your way, but that pretty much it. All the other patches
were based on this one already.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170110/4ffabc83/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] Allwinner conversion to generic pin properties
  2017-01-10  3:21 ` Olof Johansson
  2017-01-10 17:34   ` Maxime Ripard
@ 2017-01-19 18:35   ` Maxime Ripard
  2017-01-19 19:05     ` Olof Johansson
  1 sibling, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2017-01-19 18:35 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof,

On Mon, Jan 09, 2017 at 07:21:20PM -0800, Olof Johansson wrote:
> On Mon, Dec 26, 2016 at 08:42:14AM +0100, Maxime Ripard wrote:
> > Hi Arnd, Olof,
> > 
> > Like we discussed it last time, here is a pull request with the
> > convertion patches to the generic pin properties for 4.10.
> > 
> > Thanks,
> > Maxime
> > 
> > The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:
> > 
> >   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)
> > 
> > are available in the git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-generic-pinconf-for-4.10
> > 
> > for you to fetch changes up to 1edcd36fcb48fe841bcc62eda36c105037d9583c:
> > 
> >   ARM: sunxi: Convert pinctrl nodes to generic bindings (2016-12-26 08:27:11 +0100)
> > 
> > ----------------------------------------------------------------
> > Allwinner conversion to generic pin muxing properties
> > 
> > Here is a list of patches that converts the current DT to the generic pin
> > control and muxing properties, now that the pinctrl driver supports it.
> 
> I dropped the ball on this over the holidays for a few reasons, none of them
> good. Unfortunately we're at -rc3+ now, so I've queued this up in next/dt for
> v4.11 at this point. Hope that's alright.
> 
> You might want to use your branch as a base for new DT contents for
> v4.11 in case it ends up being conflict-heavy, which would work fine at our
> end.

We might have conflicts with this unfortunately.

It turns out that we fixed an issue where the pinctrl driver in 4.10
is now honoring the case where we list our pull-ups as disabled, while
it used to be ignored (which was the bug).

However, some boards were listing improperly in their DT that their
pull-ups were disabled, while they actually needed it, which means
that now the driver will disable them, and things get broken (mostly
MMC for now, but I expect other devices to be broken too).

We have two ways of fixing this.

Option 1 is applying a patch that will enable the pull ups on the MMC
devices (because it's ok to do so) that was queued with 4.11 and will
conflict heavily with this PR.

The other option would be to queue the two first patches of that PR as
fixes that will reintroduce the previous behaviour (or at least, the
one the boards expects). I'm guessing in that case, the merge will
just work (since it's the exact same commits anyway), and we fix all
the devices and not just MMC. This has not been confirmed to work at
the moment though, but should be very soon.

What do you think?
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170119/dc253827/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] Allwinner conversion to generic pin properties
  2017-01-19 18:35   ` Maxime Ripard
@ 2017-01-19 19:05     ` Olof Johansson
  2017-01-20 21:06       ` Maxime Ripard
  0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2017-01-19 19:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jan 19, 2017 at 10:35 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Olof,
>
> On Mon, Jan 09, 2017 at 07:21:20PM -0800, Olof Johansson wrote:
>> On Mon, Dec 26, 2016 at 08:42:14AM +0100, Maxime Ripard wrote:
>> > Hi Arnd, Olof,
>> >
>> > Like we discussed it last time, here is a pull request with the
>> > convertion patches to the generic pin properties for 4.10.
>> >
>> > Thanks,
>> > Maxime
>> >
>> > The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:
>> >
>> >   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)
>> >
>> > are available in the git repository at:
>> >
>> >   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-generic-pinconf-for-4.10
>> >
>> > for you to fetch changes up to 1edcd36fcb48fe841bcc62eda36c105037d9583c:
>> >
>> >   ARM: sunxi: Convert pinctrl nodes to generic bindings (2016-12-26 08:27:11 +0100)
>> >
>> > ----------------------------------------------------------------
>> > Allwinner conversion to generic pin muxing properties
>> >
>> > Here is a list of patches that converts the current DT to the generic pin
>> > control and muxing properties, now that the pinctrl driver supports it.
>>
>> I dropped the ball on this over the holidays for a few reasons, none of them
>> good. Unfortunately we're at -rc3+ now, so I've queued this up in next/dt for
>> v4.11 at this point. Hope that's alright.
>>
>> You might want to use your branch as a base for new DT contents for
>> v4.11 in case it ends up being conflict-heavy, which would work fine at our
>> end.
>
> We might have conflicts with this unfortunately.
>
> It turns out that we fixed an issue where the pinctrl driver in 4.10
> is now honoring the case where we list our pull-ups as disabled, while
> it used to be ignored (which was the bug).
>
> However, some boards were listing improperly in their DT that their
> pull-ups were disabled, while they actually needed it, which means
> that now the driver will disable them, and things get broken (mostly
> MMC for now, but I expect other devices to be broken too).
>
> We have two ways of fixing this.
>
> Option 1 is applying a patch that will enable the pull ups on the MMC
> devices (because it's ok to do so) that was queued with 4.11 and will
> conflict heavily with this PR.
>
> The other option would be to queue the two first patches of that PR as
> fixes that will reintroduce the previous behaviour (or at least, the
> one the boards expects). I'm guessing in that case, the merge will
> just work (since it's the exact same commits anyway), and we fix all
> the devices and not just MMC. This has not been confirmed to work at
> the moment though, but should be very soon.

Isn't the third and easiest option to revert back the old behavior on
the pinctrl driver for 4.10? Sounds like that could (possibly) be just
a one-line change somewhere?

Then, for 4.11, bring it back once the DT contents is fixed up.


-Olof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] Allwinner conversion to generic pin properties
  2017-01-19 19:05     ` Olof Johansson
@ 2017-01-20 21:06       ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2017-01-20 21:06 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Olof,

On Thu, Jan 19, 2017 at 11:05:36AM -0800, Olof Johansson wrote:
> On Thu, Jan 19, 2017 at 10:35 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi Olof,
> >
> > On Mon, Jan 09, 2017 at 07:21:20PM -0800, Olof Johansson wrote:
> >> On Mon, Dec 26, 2016 at 08:42:14AM +0100, Maxime Ripard wrote:
> >> > Hi Arnd, Olof,
> >> >
> >> > Like we discussed it last time, here is a pull request with the
> >> > convertion patches to the generic pin properties for 4.10.
> >> >
> >> > Thanks,
> >> > Maxime
> >> >
> >> > The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:
> >> >
> >> >   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)
> >> >
> >> > are available in the git repository at:
> >> >
> >> >   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git tags/sunxi-generic-pinconf-for-4.10
> >> >
> >> > for you to fetch changes up to 1edcd36fcb48fe841bcc62eda36c105037d9583c:
> >> >
> >> >   ARM: sunxi: Convert pinctrl nodes to generic bindings (2016-12-26 08:27:11 +0100)
> >> >
> >> > ----------------------------------------------------------------
> >> > Allwinner conversion to generic pin muxing properties
> >> >
> >> > Here is a list of patches that converts the current DT to the generic pin
> >> > control and muxing properties, now that the pinctrl driver supports it.
> >>
> >> I dropped the ball on this over the holidays for a few reasons, none of them
> >> good. Unfortunately we're at -rc3+ now, so I've queued this up in next/dt for
> >> v4.11 at this point. Hope that's alright.
> >>
> >> You might want to use your branch as a base for new DT contents for
> >> v4.11 in case it ends up being conflict-heavy, which would work fine at our
> >> end.
> >
> > We might have conflicts with this unfortunately.
> >
> > It turns out that we fixed an issue where the pinctrl driver in 4.10
> > is now honoring the case where we list our pull-ups as disabled, while
> > it used to be ignored (which was the bug).
> >
> > However, some boards were listing improperly in their DT that their
> > pull-ups were disabled, while they actually needed it, which means
> > that now the driver will disable them, and things get broken (mostly
> > MMC for now, but I expect other devices to be broken too).
> >
> > We have two ways of fixing this.
> >
> > Option 1 is applying a patch that will enable the pull ups on the MMC
> > devices (because it's ok to do so) that was queued with 4.11 and will
> > conflict heavily with this PR.
> >
> > The other option would be to queue the two first patches of that PR as
> > fixes that will reintroduce the previous behaviour (or at least, the
> > one the boards expects). I'm guessing in that case, the merge will
> > just work (since it's the exact same commits anyway), and we fix all
> > the devices and not just MMC. This has not been confirmed to work at
> > the moment though, but should be very soon.
> 
> Isn't the third and easiest option to revert back the old behavior on
> the pinctrl driver for 4.10? Sounds like that could (possibly) be just
> a one-line change somewhere?
> 
> Then, for 4.11, bring it back once the DT contents is fixed up.

Ah, yes, that would work too.

I'll send a revert.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170120/add559f1/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-01-20 21:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-26  7:42 [GIT PULL] Allwinner conversion to generic pin properties Maxime Ripard
2017-01-10  3:21 ` Olof Johansson
2017-01-10 17:34   ` Maxime Ripard
2017-01-19 18:35   ` Maxime Ripard
2017-01-19 19:05     ` Olof Johansson
2017-01-20 21:06       ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).