linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: add missing printk newlines
Date: Tue, 10 Jan 2017 12:36:48 +0000	[thread overview]
Message-ID: <20170110123648.GE21598@arm.com> (raw)
In-Reply-To: <1483971216-11781-1-git-send-email-mark.rutland@arm.com>

On Mon, Jan 09, 2017 at 02:13:36PM +0000, Mark Rutland wrote:
> A few printk calls in arm64 omit a trailing newline, even though there
> is no subsequent KERN_CONT printk associated with them, and we actually
> want a newline.
> 
> This can result in unrelated lines being appended, rather than appearing
> on a new line. Additionally, timestamp prefixes may appear in-line. This
> makes the logs harder to read than necessary.
> 
> Avoid this by adding a trailing newline.
> 
> These were found with a shortlist generated by:
> 
> $ git grep 'pr\(intk\|_.*\)(.*)' -- arch/arm64 | grep -v pr_fmt | grep -v '\\n"'
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> CC: James Morse <james.morse@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> ---
>  arch/arm64/kernel/armv8_deprecated.c | 2 +-
>  arch/arm64/kernel/hibernate.c        | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)

Applied for 4.11.

Will

      reply	other threads:[~2017-01-10 12:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 14:13 [PATCH] arm64: add missing printk newlines Mark Rutland
2017-01-10 12:36 ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110123648.GE21598@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).