From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Remove useless UAO IPI and describe how this gets enabled
Date: Tue, 10 Jan 2017 12:38:29 +0000 [thread overview]
Message-ID: <20170110123828.GG21598@arm.com> (raw)
In-Reply-To: <20170109181402.12883-1-james.morse@arm.com>
On Mon, Jan 09, 2017 at 06:14:02PM +0000, James Morse wrote:
> Since its introduction, the UAO enable call was broken, and useless.
> commit 2a6dcb2b5f3e ("arm64: cpufeature: Schedule enable() calls instead
> of calling them via IPI"), fixed the framework so that these calls
> are scheduled, so that they can modify PSTATE.
>
> Now it is just useless. Remove it. UAO is enabled by the code patching
> which causes get_user() and friends to use the 'ldtr' family of
> instructions. This relies on the PSTATE.UAO bit being set to match
> addr_limit, which we do in uao_thread_switch() called via __switch_to().
>
> All that is needed to enable UAO is patch the code, and call schedule().
> __apply_alternatives_multi_stop() calls stop_machine() when it modifies
> the kernel text to enable the alternatives, (including the UAO code in
> uao_thread_switch()). Once stop_machine() has finished __switch_to() is
> called to reschedule the original task, this causes PSTATE.UAO to be set
> appropriately. An explicit enable() call is not needed.
>
> Reported-by: Vladimir Murzin <vladimir.murzin@arm.com>
> Signed-off-by: James Morse <james.morse@arm.com>
>
> ==
> Sorry, I forgot about this cleanup after the last round of PAN fixes.
> ---
> arch/arm64/include/asm/processor.h | 1 -
> arch/arm64/kernel/cpufeature.c | 5 ++++-
> arch/arm64/mm/fault.c | 14 --------------
> 3 files changed, 4 insertions(+), 16 deletions(-)
Applied for 4.11.
Will
prev parent reply other threads:[~2017-01-10 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 18:14 [PATCH] arm64: Remove useless UAO IPI and describe how this gets enabled James Morse
2017-01-10 12:38 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110123828.GG21598@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).