From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling
Date: Tue, 10 Jan 2017 20:59:43 +0200 [thread overview]
Message-ID: <20170110185943.qxwnzjg6zzy4zbki@kozik-lap> (raw)
In-Reply-To: <23cf318d-b83f-55e6-e980-13133f0ceb8b@osg.samsung.com>
On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote:
> On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote:
> > I also think that regardless of what is decided on making susp_clk
> > non-optional for some Exynos SoCs we should probably remove the debug
> > message as it doesn't bring useful information and may be confusing.
> >
> > Shuah, can you take care of this?
>
> Yes. This message as it reads now is not only confusing, but also can
> lead users to think something is wrong.
>
> I can get rid of it or I could change it from info to debug and change
> it to read:
>
> "Optional Suspend clock isn't found. Diver operation isn't impacted"
It is even more confusing. If the clock is required (by binding, by
hardware) - make it an error. If it is completely not important - do not
print anything. If it is optional but helpful (enabling clock gives
someything) then print something... but it is not that case.
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-01-10 18:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170110120605epcas1p1c26f7f90fca4765ab9cc339c51d11347@epcas1p1.samsung.com>
2017-01-10 2:21 ` [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling Shuah Khan
2017-01-10 11:20 ` Sergei Shtylyov
2017-01-10 14:38 ` Shuah Khan
2017-01-10 12:05 ` Bartlomiej Zolnierkiewicz
2017-01-10 14:16 ` Shuah Khan
2017-01-10 14:36 ` Shuah Khan
2017-01-10 16:05 ` Bartlomiej Zolnierkiewicz
2017-01-10 16:28 ` Shuah Khan
2017-01-10 17:09 ` Bartlomiej Zolnierkiewicz
2017-01-10 17:49 ` vivek.gautam at codeaurora.org
2017-01-10 18:25 ` Krzysztof Kozlowski
2017-01-11 2:43 ` pankaj.dubey
2017-01-10 17:53 ` Anand Moon
2017-01-10 18:03 ` Bartlomiej Zolnierkiewicz
2017-01-10 18:23 ` Bartlomiej Zolnierkiewicz
2017-01-10 18:37 ` Shuah Khan
2017-01-10 18:59 ` Krzysztof Kozlowski [this message]
2017-01-10 19:20 ` Shuah Khan
2017-01-10 18:36 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110185943.qxwnzjg6zzy4zbki@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox