public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/62] watchdog: digicolor_wdt: Convert to use device managed functions and other improvements
Date: Thu, 12 Jan 2017 13:47:09 +0200	[thread overview]
Message-ID: <20170112114708.3d4chjtu3fibb7px@tarshish> (raw)
In-Reply-To: <1484091325-9199-17-git-send-email-linux@roeck-us.net>

Hi Guenter,

On Tue, Jan 10, 2017 at 03:34:33PM -0800, Guenter Roeck wrote:
> Use device managed functions to simplify error handling, reduce
> source code size, improve readability, and reduce the likelyhood of bugs.
> Other improvements as listed below.
> 
> The conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts used
> to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
> 
> - Replace 'goto l; ... l: return e;' with 'return e;'
> - Replace 'val = e; return val;' with 'return e;'
> - Drop assignments to otherwise unused variables
> - Replace 'if (e) { return expr; }' with 'if (e) return expr;'
> - Drop remove function
> - Replace of_iomap() with platform_get_resource() followed by
>   devm_ioremap_resource()
> - Drop platform_set_drvdata()
> - Replace &pdev->dev with dev if 'struct device *dev' is a declared
>   variable
> - Use devm_watchdog_register_driver() to register watchdog device
> - Replace shutdown function with call to watchdog_stop_on_reboot()
> 
> Cc: Baruch Siach <baruch@tkos.co.il>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Baruch Siach <baruch@tkos.co.il>
Tested-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2017-01-12 11:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1484091325-9199-1-git-send-email-linux@roeck-us.net>
2017-01-10 23:34 ` [PATCH 05/62] watchdog: bcm2835_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2017-01-14  6:27   ` Eric Anholt
2017-01-10 23:34 ` [PATCH 10/62] watchdog: coh901327_wdt: Convert to use device managed functions Guenter Roeck
2017-01-11 15:48   ` Linus Walleij
2017-01-10 23:34 ` [PATCH 16/62] watchdog: digicolor_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2017-01-12 11:47   ` Baruch Siach [this message]
2017-01-10 23:34 ` [PATCH 27/62] watchdog: lpc18xx_wdt: " Guenter Roeck
     [not found] ` <1484095516-12720-1-git-send-email-linux@roeck-us.net>
2017-01-11  0:44   ` [PATCH 32/62] watchdog: meson_gxbb_wdt: " Guenter Roeck
2017-01-11  8:42     ` Neil Armstrong
2017-01-11 18:44     ` Kevin Hilman
2017-01-11  0:44   ` [PATCH 33/62] watchdog: meson_wdt: " Guenter Roeck
2017-01-11 18:45     ` Kevin Hilman
2017-01-11  0:44   ` [PATCH 37/62] watchdog: mtk_wdt: " Guenter Roeck
2017-01-11  0:44   ` [PATCH 39/62] watchdog: of_xilinx_wdt: Convert to use device managed functions Guenter Roeck
2017-01-11  0:44   ` [PATCH 44/62] watchdog: pnx4008_wdt: " Guenter Roeck
2017-01-12  0:13     ` Vladimir Zapolskiy
2017-01-11  2:09 ` [PATCH 52/62] watchdog: sirfsoc_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2017-01-11  2:09   ` [PATCH 53/62] watchdog: st_lpc_wdt: Convert to use device managed functions Guenter Roeck
2017-01-11  2:09   ` [PATCH 55/62] watchdog: sunxi_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2017-01-11 12:15     ` Maxime Ripard
2017-01-11  2:09   ` [PATCH 56/62] watchdog: tangox_wdt: Convert to use device managed functions Guenter Roeck
2017-01-11  9:07     ` Marc Gonzalez
2017-01-11 10:52       ` Guenter Roeck
2017-01-11 12:31         ` Marc Gonzalez
2017-01-11 14:25           ` Guenter Roeck
2017-01-11 14:43             ` Måns Rullgård
2017-01-11 15:28             ` Marc Gonzalez
2017-01-11 17:51               ` Guenter Roeck
2017-01-12  9:44                 ` Marc Gonzalez
2017-01-12  9:57                   ` Uwe Kleine-König
2017-01-12 11:24                   ` Måns Rullgård
2017-01-12 12:15                     ` Marc Gonzalez
2017-01-11 14:39           ` Uwe Kleine-König
2017-01-11 14:50             ` Vladimir Zapolskiy
2017-01-11 17:28             ` Guenter Roeck
2017-01-13  5:17             ` Guenter Roeck
2017-01-12  0:12         ` Andy Shevchenko
2017-01-12  1:29           ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170112114708.3d4chjtu3fibb7px@tarshish \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox