From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/mm: use phys_addr_t
Date: Fri, 13 Jan 2017 11:22:05 +0000 [thread overview]
Message-ID: <20170113112205.GA26804@leverpostej> (raw)
In-Reply-To: <1484287175-14342-1-git-send-email-miles.chen@mediatek.com>
On Fri, Jan 13, 2017 at 01:59:35PM +0800, miles.chen at mediatek.com wrote:
> From: Miles Chen <miles.chen@mediatek.com>
>
> Use phys_addr_t instead of unsigned long for the
> return value of __pa(), make code easy to understand.
>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
This looks sensible to me. It's consistent with the types these
variables are compared against, and with the types of function
parameters these are passed as.
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> arch/arm64/mm/mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index 17243e4..7eb7c21 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -359,8 +359,8 @@ static void create_mapping_late(phys_addr_t phys, unsigned long virt,
>
> static void __init __map_memblock(pgd_t *pgd, phys_addr_t start, phys_addr_t end)
> {
> - unsigned long kernel_start = __pa(_text);
> - unsigned long kernel_end = __pa(__init_begin);
> + phys_addr_t kernel_start = __pa(_text);
> + phys_addr_t kernel_end = __pa(__init_begin);
>
> /*
> * Take care not to create a writable alias for the
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-01-13 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 5:59 [PATCH] arm64/mm: use phys_addr_t miles.chen at mediatek.com
2017-01-13 11:18 ` Catalin Marinas
2017-01-13 11:22 ` Mark Rutland [this message]
2017-01-13 11:27 ` Ard Biesheuvel
2017-01-13 11:45 ` Mark Rutland
2017-01-13 12:06 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113112205.GA26804@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).