From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm64: mm: Fix NOMAP page initialization
Date: Tue, 17 Jan 2017 19:16:56 +0000 [thread overview]
Message-ID: <20170117191656.GS27328@arm.com> (raw)
In-Reply-To: <20170117100015.GG5020@rric.localdomain>
On Tue, Jan 17, 2017 at 11:00:15AM +0100, Robert Richter wrote:
> On 13.01.17 14:15:00, Robert Richter wrote:
> > On 13.01.17 09:19:04, Will Deacon wrote:
> > > On Thu, Jan 12, 2017 at 07:58:25PM +0100, Robert Richter wrote:
> > > > On 12.01.17 16:05:36, Will Deacon wrote:
> > > > > On Mon, Jan 09, 2017 at 12:53:20PM +0100, Robert Richter wrote:
> > > >
> > > > > > Kernel compile times (3 runs each):
> > > > > >
> > > > > > pfn_valid_within():
> > > > > >
> > > > > > real 6m4.088s
> > > > > > user 372m57.607s
> > > > > > sys 16m55.158s
> > > > > >
> > > > > > real 6m1.532s
> > > > > > user 372m48.453s
> > > > > > sys 16m50.370s
> > > > > >
> > > > > > real 6m4.061s
> > > > > > user 373m18.753s
> > > > > > sys 16m57.027s
> > > > >
> > > > > Did you reboot the machine between each build here, or only when changing
> > > > > kernel? If the latter, do you see variations in kernel build time by simply
> > > > > rebooting the same Image?
> > > >
> > > > I built it in a loop on the shell, so no reboots between builds. Note
> > > > that I was building the kernel in /dev/shm to not access harddisks. I
> > > > think build times should be comparable then since there is no fs
> > > > caching.
> > >
> > > I guess I'm really asking what the standard deviation is if you *do* reboot
> > > between builds, using the same kernel. It's hard to tell whether the numbers
> > > are due to the patches, or just because of noise incurred by the way things
> > > happen to initialise.
> >
> > Ok, I am going to test this.
>
> See below the data for a test with reboots between every 3 builds (9
> builds per kernel). Though some deviation can be seen between reboots
> there is a trend.
I can't really see the trend given that, for system time, your
pfn_valid_within results have a variance of ~9 and the early_pfn_valid
results have a variance of ~92. Given that the variance seems to come
about due to the reboots, I think we need more numbers to establish whether
the data sets end up largely overlapping or if they really are disjoint.
Will
next prev parent reply other threads:[~2017-01-17 19:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 16:54 [PATCH v3] arm64: mm: Fix NOMAP page initialization Robert Richter
2017-01-04 13:56 ` Ard Biesheuvel
2017-01-05 2:03 ` Hanjun Guo
2017-01-06 1:07 ` Hanjun Guo
2017-01-06 5:22 ` Prakash B
2017-01-09 5:09 ` Hanjun Guo
2017-01-09 6:15 ` Prakash B
2017-01-06 8:37 ` Ard Biesheuvel
2017-01-09 5:14 ` Hanjun Guo
2017-01-09 11:53 ` Robert Richter
2017-01-12 16:05 ` Will Deacon
2017-01-12 18:58 ` Robert Richter
2017-01-13 9:19 ` Will Deacon
2017-01-13 13:15 ` Robert Richter
2017-01-17 10:00 ` Robert Richter
2017-01-17 19:16 ` Will Deacon [this message]
2017-02-03 15:14 ` Robert Richter
2017-02-03 18:16 ` Will Deacon
2017-01-05 11:03 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117191656.GS27328@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).