From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 23/33] Input: xilinx_ps2 - Use 'dev' instead of dereferencing it and other changes
Date: Wed, 18 Jan 2017 11:17:12 -0800 [thread overview]
Message-ID: <20170118191712.GA33920@dtor-ws> (raw)
In-Reply-To: <1484761614-12225-24-git-send-email-linux@roeck-us.net>
On Wed, Jan 18, 2017 at 09:46:44AM -0800, Guenter Roeck wrote:
> Use local variable 'dev' instead of dereferencing it several times.
>
> This conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts
> used to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
>
> - Use local variable 'struct device *dev' consistently
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied, thank you.
> ---
> drivers/input/serio/xilinx_ps2.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
> index 5223cbf94262..14c40892ed82 100644
> --- a/drivers/input/serio/xilinx_ps2.c
> +++ b/drivers/input/serio/xilinx_ps2.c
> @@ -243,18 +243,17 @@ static int xps2_of_probe(struct platform_device *ofdev)
> unsigned int irq;
> int error;
>
> - dev_info(dev, "Device Tree Probing \'%s\'\n",
> - ofdev->dev.of_node->name);
> + dev_info(dev, "Device Tree Probing \'%s\'\n", dev->of_node->name);
>
> /* Get iospace for the device */
> - error = of_address_to_resource(ofdev->dev.of_node, 0, &r_mem);
> + error = of_address_to_resource(dev->of_node, 0, &r_mem);
> if (error) {
> dev_err(dev, "invalid address\n");
> return error;
> }
>
> /* Get IRQ for the device */
> - irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
> + irq = irq_of_parse_and_map(dev->of_node, 0);
> if (!irq) {
> dev_err(dev, "no IRQ found\n");
> return -ENODEV;
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2017-01-18 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1484761614-12225-1-git-send-email-linux@roeck-us.net>
2017-01-18 17:46 ` [PATCH 09/33] Input: sun4i-lradc-keys - Drop unnecessary call to platform_set_drvdata and other changes Guenter Roeck
2017-02-02 7:45 ` Chen-Yu Tsai
2017-01-18 17:46 ` [PATCH 23/33] Input: xilinx_ps2 - Use 'dev' instead of dereferencing it " Guenter Roeck
2017-01-18 19:17 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118191712.GA33920@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).