From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC
Date: Thu, 19 Jan 2017 14:40:16 +0000 [thread overview]
Message-ID: <20170119144016.GF11176@leverpostej> (raw)
In-Reply-To: <1484736811-24002-2-git-send-email-marc.zyngier@arm.com>
On Wed, Jan 18, 2017 at 10:53:30AM +0000, Marc Zyngier wrote:
> The joys of copy/paste: the example of a virtualization capable GIC
> in the DT binding was wrong, and propagated to dozens of platforms.
Could you please mention what's wrong (i.e. GICC is impossibly small in
the example).
>
> Oh well. Let's fix the source of the crap before tackling individual
> offenders.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> index 5393e2a..a3d51ed 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
> @@ -107,11 +107,11 @@ Required properties:
> Example:
>
> interrupt-controller at 2c001000 {
> - compatible = "arm,cortex-a15-gic";
> + compatible = "arm,gic-400";
I'm happy with this change in the spirit of making this more generally
applicable, even if it's not a bug as such. Please mention this as a
related cleanup in the commit message.
With those fixed up:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> #interrupt-cells = <3>;
> interrupt-controller;
> reg = <0x2c001000 0x1000>,
> - <0x2c002000 0x1000>,
> + <0x2c002000 0x2000>,
> <0x2c004000 0x2000>,
> <0x2c006000 0x2000>;
> interrupts = <1 9 0xf04>;
> --
> 2.1.4
>
next prev parent reply other threads:[~2017-01-19 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 10:53 [PATCH 0/2] ARM: DTS: Fix broken GICv2 register maps Marc Zyngier
2017-01-18 10:53 ` [PATCH 1/2] dt-bindings: arm, gic: Fix binding example for a virt-capable GIC Marc Zyngier
2017-01-19 14:40 ` Mark Rutland [this message]
2017-01-18 10:53 ` [PATCH 2/2] ARM: DTS: Fix register map for " Marc Zyngier
2017-01-18 11:25 ` Heiko Stübner
2017-01-18 11:29 ` Matthias Brugger
2017-01-18 11:57 ` Robin Murphy
2017-01-18 13:25 ` Marc Zyngier
2017-01-18 12:49 ` Antoine Tenart
2017-01-18 13:23 ` Maxime Ripard
2017-01-18 14:09 ` Krzysztof Kozlowski
2017-01-18 15:16 ` Javier Martinez Canillas
2017-01-18 15:26 ` Marc Zyngier
2017-01-18 16:39 ` Santosh Shilimkar
2017-01-23 9:58 ` Shawn Guo
2017-01-18 12:34 ` [PATCH 0/2] ARM: DTS: Fix broken GICv2 register maps Arnd Bergmann
2017-01-18 13:07 ` Marc Zyngier
2017-01-19 17:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119144016.GF11176@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).