public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU
Date: Thu, 19 Jan 2017 16:39:50 +0100	[thread overview]
Message-ID: <20170119153950.gosrmbm7jesxljyj@lukather> (raw)
In-Reply-To: <5926181484672894@web12g.yandex.ru>

On Wed, Jan 18, 2017 at 01:08:14AM +0800, Icenowy Zheng wrote:
> 
> 
> 17.01.2017, 17:05, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > Hi,
> >
> > On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote:
> >> ?V3s has a similar but cut-down CCU to H3.
> >>
> >> ?Add support for it.
> >>
> >> ?Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >> ?---
> >
> > Output from checkpatch:
> > total: 5 errors, 2 warnings, 3 checks, 857 lines checked
> 
> I remembered some errors' code is directly derived from ccu-sun8i-h3.c,
> so I generated a patch file for "clk: sunxi-ng: Add H3 clocks" and run
> checkpatch on it:
> total: 4 errors, 5 warnings, 1159 lines checked
> 
> Should I still get all errors fixed?

Yes, please.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170119/190589d5/attachment.sig>

  reply	other threads:[~2017-01-19 15:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 18:01 [PATCH v2 1/4] arm: sunxi: add support for V3s SoC Icenowy Zheng
2017-01-16 18:01 ` [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU Icenowy Zheng
2017-01-17  9:04   ` Maxime Ripard
2017-01-17 17:08     ` Icenowy Zheng
2017-01-19 15:39       ` Maxime Ripard [this message]
2017-01-16 18:01 ` [PATCH v2 3/4] ARM: dts: sunxi: add dtsi file for V3s SoC Icenowy Zheng
2017-01-16 18:01 ` [PATCH v2 4/4] ARM: dts: sunxi: add support for Lichee Pi Zero board Icenowy Zheng
2017-01-17  9:05 ` [PATCH v2 1/4] arm: sunxi: add support for V3s SoC Maxime Ripard
2017-01-17 16:52   ` Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170119153950.gosrmbm7jesxljyj@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox