* [PATCH v3 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
` (10 subsequent siblings)
11 siblings, 1 reply; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state. While here also explicitly specify the phy-mode instead of
relying on the default-value from meson-gx.dtsi.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index c59403adb387..6b5579522587 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -152,6 +152,11 @@
pinctrl-0 = <ð_rgmii_pins>;
pinctrl-names = "default";
phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
mdio {
compatible = "snps,dwmac-mdio";
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
@ 2017-01-20 16:23 ` Neil Armstrong
0 siblings, 0 replies; 78+ messages in thread
From: Neil Armstrong @ 2017-01-20 16:23 UTC (permalink / raw)
To: linux-arm-kernel
On 01/20/2017 04:22 PM, Martin Blumenstingl wrote:
> This resets the ethernet PHY during boot to get the PHY into a "clean"
> state. While here also explicitly specify the phy-mode instead of
> relying on the default-value from meson-gx.dtsi.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index c59403adb387..6b5579522587 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -152,6 +152,11 @@
> pinctrl-0 = <ð_rgmii_pins>;
> pinctrl-names = "default";
> phy-handle = <ð_phy0>;
> + phy-mode = "rgmii";
> +
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0 10000 1000000>;
> + snps,reset-active-low;
>
> mdio {
> compatible = "snps,dwmac-mdio";
>
On Odroid-c2 rev 0.2 :
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:18 ` Andrew Lunn
` (2 more replies)
2017-01-20 15:22 ` [PATCH v3 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
` (9 subsequent siblings)
11 siblings, 3 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
index 03e3d76626dd..fa0f84cfeaa9 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
@@ -51,6 +51,30 @@
model = "Amlogic Meson GXBB P200 Development Board";
};
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ compatible = "ethernet-phy-id0022.1620",
+ "ethernet-phy-ieee802.3-c22";
+ reg = <3>;
+ };
+ };
+};
+
&i2c_B {
status = "okay";
pinctrl-0 = <&i2c_b_pins>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
@ 2017-01-20 16:18 ` Andrew Lunn
2017-01-20 16:21 ` Andrew Lunn
2017-01-20 16:23 ` Neil Armstrong
2 siblings, 0 replies; 78+ messages in thread
From: Andrew Lunn @ 2017-01-20 16:18 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 20, 2017 at 04:22:25PM +0100, Martin Blumenstingl wrote:
> This resets the ethernet PHY during boot to get the PHY into a "clean"
> state.
> While here also specify the phy-handle of the ethmac node to make the
> PHY configuration similar to the one we have on GXL devices. This will
> allow us to specify OF-properties for the PHY itself.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> index 03e3d76626dd..fa0f84cfeaa9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> @@ -51,6 +51,30 @@
> model = "Amlogic Meson GXBB P200 Development Board";
> };
>
> +ðmac {
> + status = "okay";
> + pinctrl-0 = <ð_rgmii_pins>;
> + pinctrl-names = "default";
> + phy-handle = <ð_phy0>;
> + phy-mode = "rgmii";
> +
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0 10000 1000000>;
> + snps,reset-active-low;
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eth_phy0: ethernet-phy at 0 {
Hi Martin
ethernet-phy at 3, because of the reg property.
> + compatible = "ethernet-phy-id0022.1620",
> + "ethernet-phy-ieee802.3-c22";
> + reg = <3>;
Andrew
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-01-20 16:18 ` Andrew Lunn
@ 2017-01-20 16:21 ` Andrew Lunn
2017-01-20 17:07 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2 siblings, 1 reply; 78+ messages in thread
From: Andrew Lunn @ 2017-01-20 16:21 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 20, 2017 at 04:22:25PM +0100, Martin Blumenstingl wrote:
> This resets the ethernet PHY during boot to get the PHY into a "clean"
> state.
> While here also specify the phy-handle of the ethmac node to make the
> PHY configuration similar to the one we have on GXL devices. This will
> allow us to specify OF-properties for the PHY itself.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> index 03e3d76626dd..fa0f84cfeaa9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> @@ -51,6 +51,30 @@
> model = "Amlogic Meson GXBB P200 Development Board";
> };
>
> +ðmac {
> + status = "okay";
> + pinctrl-0 = <ð_rgmii_pins>;
> + pinctrl-names = "default";
> + phy-handle = <ð_phy0>;
> + phy-mode = "rgmii";
> +
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0 10000 1000000>;
> + snps,reset-active-low;
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eth_phy0: ethernet-phy at 0 {
> + compatible = "ethernet-phy-id0022.1620",
Hi Martin
You don't need to specify the PHY ID. You really only need this when
the PHY is reporting no ID, or a wrong ID. In fact, if a new revision
of the board is made, with a different PHY, you might have a problem,
the wrong PHY driver is loaded.
Andrew
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-20 16:21 ` Andrew Lunn
@ 2017-01-20 17:07 ` Martin Blumenstingl
2017-01-20 17:46 ` Andrew Lunn
0 siblings, 1 reply; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 17:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrew,
On Fri, Jan 20, 2017 at 5:21 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Fri, Jan 20, 2017 at 04:22:25PM +0100, Martin Blumenstingl wrote:
>> This resets the ethernet PHY during boot to get the PHY into a "clean"
>> state.
>> While here also specify the phy-handle of the ethmac node to make the
>> PHY configuration similar to the one we have on GXL devices. This will
>> allow us to specify OF-properties for the PHY itself.
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
>> index 03e3d76626dd..fa0f84cfeaa9 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
>> @@ -51,6 +51,30 @@
>> model = "Amlogic Meson GXBB P200 Development Board";
>> };
>>
>> +ðmac {
>> + status = "okay";
>> + pinctrl-0 = <ð_rgmii_pins>;
>> + pinctrl-names = "default";
>> + phy-handle = <ð_phy0>;
>> + phy-mode = "rgmii";
>> +
>> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
>> + snps,reset-delays-us = <0 10000 1000000>;
>> + snps,reset-active-low;
>> +
>> + mdio {
>> + compatible = "snps,dwmac-mdio";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + eth_phy0: ethernet-phy at 0 {
>> + compatible = "ethernet-phy-id0022.1620",
>
> Hi Martin
>
> You don't need to specify the PHY ID. You really only need this when
> the PHY is reporting no ID, or a wrong ID. In fact, if a new revision
> of the board is made, with a different PHY, you might have a problem,
> the wrong PHY driver is loaded.
>
> Andrew
I though that this is good practice - the documentation doesn't say
that it should only be added in specific cases: [0]
my intention behind adding the PHY ID was to make it easier to see
which devices uses which PHY. this is especially useful for devices
with RTL8211F PHY (basically all devices with RGMII PHY except the
P200) as these may need similar fixes than [1]
regarding your other mail: you're absolutely right that ethernet-phy at 0
should be ethernet-phy at 3.
[0] http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/net/phy.txt
[1] https://patchwork.kernel.org/patch/9528915/
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-20 17:07 ` Martin Blumenstingl
@ 2017-01-20 17:46 ` Andrew Lunn
2017-01-22 16:48 ` Martin Blumenstingl
0 siblings, 1 reply; 78+ messages in thread
From: Andrew Lunn @ 2017-01-20 17:46 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 20, 2017 at 06:07:20PM +0100, Martin Blumenstingl wrote:
> I though that this is good practice - the documentation doesn't say
> that it should only be added in specific cases: [0]
Agreed, the text should be better, listing when it is appropriate to
use.
> my intention behind adding the PHY ID was to make it easier to see
> which devices uses which PHY. this is especially useful for devices
> with RTL8211F PHY (basically all devices with RGMII PHY except the
> P200) as these may need similar fixes than [1]
I would not say it is wrong to list the PHY ID, it just has
consequences if the PHY ever changes.
Andrew
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-20 17:46 ` Andrew Lunn
@ 2017-01-22 16:48 ` Martin Blumenstingl
0 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 16:48 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 20, 2017 at 6:46 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Fri, Jan 20, 2017 at 06:07:20PM +0100, Martin Blumenstingl wrote:
>> I though that this is good practice - the documentation doesn't say
>> that it should only be added in specific cases: [0]
>
> Agreed, the text should be better, listing when it is appropriate to
> use.
>
>> my intention behind adding the PHY ID was to make it easier to see
>> which devices uses which PHY. this is especially useful for devices
>> with RTL8211F PHY (basically all devices with RGMII PHY except the
>> P200) as these may need similar fixes than [1]
>
> I would not say it is wrong to list the PHY ID, it just has
> consequences if the PHY ever changes.
thanks for pointing this out again, I'll re-spin this series and
remove the PHY's "compatible" property from all patches.
I also sent a patch which hopefully makes the documentation a bit more
clear: [0]
Regards,
Martin
[0] http://marc.info/?l=linux-netdev&m=148510331812986&w=2
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-01-20 16:18 ` Andrew Lunn
2017-01-20 16:21 ` Andrew Lunn
@ 2017-01-20 16:23 ` Neil Armstrong
2 siblings, 0 replies; 78+ messages in thread
From: Neil Armstrong @ 2017-01-20 16:23 UTC (permalink / raw)
To: linux-arm-kernel
On 01/20/2017 04:22 PM, Martin Blumenstingl wrote:
> This resets the ethernet PHY during boot to get the PHY into a "clean"
> state.
> While here also specify the phy-handle of the ethmac node to make the
> PHY configuration similar to the one we have on GXL devices. This will
> allow us to specify OF-properties for the PHY itself.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> index 03e3d76626dd..fa0f84cfeaa9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> @@ -51,6 +51,30 @@
> model = "Amlogic Meson GXBB P200 Development Board";
> };
>
> +ðmac {
> + status = "okay";
> + pinctrl-0 = <ð_rgmii_pins>;
> + pinctrl-names = "default";
> + phy-handle = <ð_phy0>;
> + phy-mode = "rgmii";
> +
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0 10000 1000000>;
> + snps,reset-active-low;
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eth_phy0: ethernet-phy at 0 {
> + compatible = "ethernet-phy-id0022.1620",
> + "ethernet-phy-ieee802.3-c22";
> + reg = <3>;
> + };
> + };
> +};
> +
> &i2c_B {
> status = "okay";
> pinctrl-0 = <&i2c_b_pins>;
>
On Amlogic p200 :
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v3 3/9] ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
` (8 subsequent siblings)
11 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 86709929fd20..358ab5159bd5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -128,6 +128,24 @@
status = "okay";
pinctrl-0 = <ð_rgmii_pins>;
pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ compatible = "ethernet-phy-id001c.c916",
+ "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+ };
};
&usb0_phy {
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (2 preceding siblings ...)
2017-01-20 15:22 ` [PATCH v3 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
` (7 subsequent siblings)
11 siblings, 1 reply; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
index 4cbd626a9e88..c7e3ea008566 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
@@ -164,7 +164,24 @@
status = "okay";
pinctrl-0 = <ð_rmii_pins>;
pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
phy-mode = "rmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ compatible = "ethernet-phy-id0243.0c54",
+ "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+ };
};
&ir {
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
@ 2017-01-20 16:23 ` Neil Armstrong
0 siblings, 0 replies; 78+ messages in thread
From: Neil Armstrong @ 2017-01-20 16:23 UTC (permalink / raw)
To: linux-arm-kernel
On 01/20/2017 04:22 PM, Martin Blumenstingl wrote:
> This resets the ethernet PHY during boot to get the PHY into a "clean"
> state.
> While here also specify the phy-handle of the ethmac node to make the
> PHY configuration similar to the one we have on GXL devices. This will
> allow us to specify OF-properties for the PHY itself.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
> index 4cbd626a9e88..c7e3ea008566 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
> @@ -164,7 +164,24 @@
> status = "okay";
> pinctrl-0 = <ð_rmii_pins>;
> pinctrl-names = "default";
> + phy-handle = <ð_phy0>;
> phy-mode = "rmii";
> +
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0 10000 1000000>;
> + snps,reset-active-low;
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eth_phy0: ethernet-phy at 0 {
> + compatible = "ethernet-phy-id0243.0c54",
> + "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> + };
> };
>
> &ir {
>
On Nexbox A95X (S905) :
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v3 5/9] ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (3 preceding siblings ...)
2017-01-20 15:22 ` [PATCH v3 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
` (6 subsequent siblings)
11 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
.../boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
index 56f855901262..47fe4e444f33 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
@@ -64,3 +64,27 @@
status = "disabled";
};
};
+
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ compatible = "ethernet-phy-id001c.c916",
+ "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+ };
+};
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 6/9] ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (4 preceding siblings ...)
2017-01-20 15:22 ` [PATCH v3 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
` (5 subsequent siblings)
11 siblings, 1 reply; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
.../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
index ea79fdd2c248..9a8e2f492b97 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
@@ -87,6 +87,30 @@
};
};
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ compatible = "ethernet-phy-id001c.c916",
+ "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ };
+ };
+};
+
&i2c_A {
status = "okay";
pinctrl-0 = <&i2c_a_pins>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 6/9] ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
2017-01-20 15:22 ` [PATCH v3 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
@ 2017-01-20 16:23 ` Neil Armstrong
0 siblings, 0 replies; 78+ messages in thread
From: Neil Armstrong @ 2017-01-20 16:23 UTC (permalink / raw)
To: linux-arm-kernel
On 01/20/2017 04:22 PM, Martin Blumenstingl wrote:
> This resets the ethernet PHY during boot to get the PHY into a "clean"
> state.
> While here also specify the phy-handle of the ethmac node to make the
> PHY configuration similar to the one we have on GXL devices. This will
> allow us to specify OF-properties for the PHY itself.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> .../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> index ea79fdd2c248..9a8e2f492b97 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> @@ -87,6 +87,30 @@
> };
> };
>
> +ðmac {
> + status = "okay";
> + pinctrl-0 = <ð_rgmii_pins>;
> + pinctrl-names = "default";
> + phy-handle = <ð_phy0>;
> + phy-mode = "rgmii";
> +
> + snps,reset-gpio = <&gpio GPIOZ_14 0>;
> + snps,reset-delays-us = <0 10000 1000000>;
> + snps,reset-active-low;
> +
> + mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eth_phy0: ethernet-phy at 0 {
> + compatible = "ethernet-phy-id001c.c916",
> + "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> + };
> +};
> +
> &i2c_A {
> status = "okay";
> pinctrl-0 = <&i2c_a_pins>;
>
On Wetek Play 2 :
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v3 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (5 preceding siblings ...)
2017-01-20 15:22 ` [PATCH v3 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
` (4 subsequent siblings)
11 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
Amlogic's own .dts specifies that the P201 board uses a RMII PHY (with
the reset GPIO being GPIOZ_14).
However our P201 board .dts simply inherits the phy-mode setting from
from meson-gx.dtsi where it defaults to RGMII mode.
Remove all ethernet settings from meson-gxbb-p20x.dtsi as it only
specifies the RGMII pins which are only valid for the P200 board.
Instead we add the ethmac node to the meson-gxbb-p201.dts and configure
the pinctrl property and the phy-mode for an RMII PHY.
An MDIO node (which would also specify the PHY) is not added since we
don't know which PHY is being used (and thus which PHY address would
have to be used).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts | 11 +++++++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 6 ------
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
index 39bb037a3e47..ae3194663d64 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
@@ -50,3 +50,14 @@
compatible = "amlogic,p201", "amlogic,meson-gxbb";
model = "Amlogic Meson GXBB P201 Development Board";
};
+
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rmii_pins>;
+ pinctrl-names = "default";
+ phy-mode = "rmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
index 4a96e0f6f926..17ebe46e48d4 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
@@ -144,12 +144,6 @@
pinctrl-names = "default";
};
-ðmac {
- status = "okay";
- pinctrl-0 = <ð_rgmii_pins>;
- pinctrl-names = "default";
-};
-
&ir {
status = "okay";
pinctrl-0 = <&remote_input_ao_pins>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (6 preceding siblings ...)
2017-01-20 15:22 ` [PATCH v3 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:34 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
` (3 subsequent siblings)
11 siblings, 1 reply; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
This adds the amlogic,tx-delay-ns property with the old (hardcoded)
default value of 2ns to all boards which are using an RGMII ethernet
PHY.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
8 files changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 6b5579522587..e63ed98d6c25 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -154,6 +154,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
index fa0f84cfeaa9..6c7e914e9bd9 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
@@ -58,6 +58,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 358ab5159bd5..4301ad860a76 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -131,6 +131,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
index 47fe4e444f33..f6d8c70a26a2 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
@@ -72,6 +72,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
index 9a8e2f492b97..1a222ce60a30 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
@@ -94,6 +94,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
index f66939cacd37..7663d6775823 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
@@ -59,6 +59,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
/* External PHY reset is shared with internal PHY Led signals */
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
index 5a337d339df1..a0bc746adb42 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
@@ -162,6 +162,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
index 5dbc66088355..e6ac39b712b7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
@@ -59,6 +59,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
/* External PHY reset is shared with internal PHY Led signals */
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration
2017-01-20 15:22 ` [PATCH v3 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
@ 2017-01-20 16:34 ` Neil Armstrong
0 siblings, 0 replies; 78+ messages in thread
From: Neil Armstrong @ 2017-01-20 16:34 UTC (permalink / raw)
To: linux-arm-kernel
On 01/20/2017 04:22 PM, Martin Blumenstingl wrote:
> This adds the amlogic,tx-delay-ns property with the old (hardcoded)
> default value of 2ns to all boards which are using an RGMII ethernet
> PHY.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
> 8 files changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 6b5579522587..e63ed98d6c25 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -154,6 +154,8 @@
> phy-handle = <ð_phy0>;
> phy-mode = "rgmii";
>
> + amlogic,tx-delay-ns = <2>;
> +
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> index fa0f84cfeaa9..6c7e914e9bd9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> @@ -58,6 +58,8 @@
> phy-handle = <ð_phy0>;
> phy-mode = "rgmii";
>
> + amlogic,tx-delay-ns = <2>;
> +
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
> index 358ab5159bd5..4301ad860a76 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
> @@ -131,6 +131,8 @@
> phy-handle = <ð_phy0>;
> phy-mode = "rgmii";
>
> + amlogic,tx-delay-ns = <2>;
> +
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
> index 47fe4e444f33..f6d8c70a26a2 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
> @@ -72,6 +72,8 @@
> phy-handle = <ð_phy0>;
> phy-mode = "rgmii";
>
> + amlogic,tx-delay-ns = <2>;
> +
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> index 9a8e2f492b97..1a222ce60a30 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> @@ -94,6 +94,8 @@
> phy-handle = <ð_phy0>;
> phy-mode = "rgmii";
>
> + amlogic,tx-delay-ns = <2>;
> +
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
> index f66939cacd37..7663d6775823 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
> @@ -59,6 +59,8 @@
> /* Select external PHY by default */
> phy-handle = <&external_phy>;
>
> + amlogic,tx-delay-ns = <2>;
> +
> /* External PHY reset is shared with internal PHY Led signals */
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
> index 5a337d339df1..a0bc746adb42 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
> @@ -162,6 +162,8 @@
> /* Select external PHY by default */
> phy-handle = <&external_phy>;
>
> + amlogic,tx-delay-ns = <2>;
> +
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
> index 5dbc66088355..e6ac39b712b7 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
> @@ -59,6 +59,8 @@
> /* Select external PHY by default */
> phy-handle = <&external_phy>;
>
> + amlogic,tx-delay-ns = <2>;
> +
> /* External PHY reset is shared with internal PHY Led signals */
> snps,reset-gpio = <&gpio GPIOZ_14 0>;
> snps,reset-delays-us = <0 10000 1000000>;
>
On :
- Odroid-C2 rev 0.2
- P200
- Wetek Play 2
- Amlogic P230
- Nexbox A1
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v3 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (7 preceding siblings ...)
2017-01-20 15:22 ` [PATCH v3 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
@ 2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:27 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
` (2 subsequent siblings)
11 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:22 UTC (permalink / raw)
To: linux-arm-kernel
The ethmac node has to be configured for each board due to different
pinctrl nodes for RGMII/RMII. Thus the phy-mode should be specified at
the same place (= in the board .dts), making it easier to read the board
.dts file (because the phy-mode is stated explicitly, without requiring
developers to read all "parent" .dtsi as well).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index c1291007b37c..85bce028c76e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -395,7 +395,6 @@
0x0 0xc8834540 0x0 0x4>;
interrupts = <0 8 1>;
interrupt-names = "macirq";
- phy-mode = "rgmii";
status = "disabled";
};
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (8 preceding siblings ...)
2017-01-20 15:22 ` [PATCH v3 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
@ 2017-01-20 15:27 ` Jerome Brunet
2017-01-20 15:32 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
11 siblings, 0 replies; 78+ messages in thread
From: Jerome Brunet @ 2017-01-20 15:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2017-01-20 at 16:22 +0100, Martin Blumenstingl wrote:
> This series adds the reset GPIOs for the (external) ethernet PHYs on
> all
> GXBB boards.
> Additionally it provides a ethernet PHY node which can be used to
> specify
> PHY-specific properties (this may be required if more boards require
> the
> "eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board
> .dts
> consistent I chose to add the PHY node also for boards which don't
> have a
> RTL8211F PHY.
>
> Patch #7 from this series also removes ethernet support for the P200
> board because it was broken anyways and nobody seems to have a board
> available for testing. This was the outcome of the discussion from
> [0]
>
> Patch #8 was taken from (older versions of) my other series (see
> [1]):
> "[PATCH net-next v3 0/2] stmmac: dwmac-meson8b: configurable
> RGMII TX delay".
> The binding changes for amlogic,tx-delay-ns were ACK'ed already.
>
> Changes since v2:
> - fixed patch #2 to really update the P200 board (as it's the P200
> which
> ? actually uses a Micrel KSZ9031 RGMII PHY). Thanks to Neil Armstrong
> for
> ? spotting this huge mistake!
> - instead of dropping ethernet support for P201 we simply re-
> configure it
> ? to RMII mode (replaces patch #7) without a MDIO node (which keeps
> PHY
> ? auto-scanning enabled). This got Neil Armstrong's ACK off-list
> already
>
> Changes since v1:
> - do not move the MDIO bus to meson-gx as this disables PHY auto-
> scanning
> ? in the stmmac driver (this drops patch #1 from v1)
> - add the ethernet PHY reset GPIO for nexbox a95x which was forgotten
> in
> ? v1
> - add the ethernet PHY reset GPIO for boards which were added since
> v1
> ? (wetek hub and wetek play2)
> - rebased to apply against the current v4.11/dt64 branch
> - new in v2 (patch #7): disabled ethernet support for the P200 board
> (see
> ? the commit description for more information). this patch is
> optional
> - new in v2 (patch #9): removed the phy-mode property from meson-gx
> (see
> ? the commit description for more information). this patch is
> optional
>
>
> [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/0
> 02053.html
> [1] http://lists.infradead.org/pipermail/linux-amlogic/2016-December/
> 001834.html
>
> Martin Blumenstingl (9):
> ? ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset
> GPIO
> ? ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset
> GPIO
> ? ARM64: dts: meson-gxbb-p201: fix ethernet support
> ? ARM64: dts: amlogic: add the ethernet TX delay configuration
> ? ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
>
> ?arch/arm64/boot/dts/amlogic/meson-gx.dtsi??????????|??1 -
> ?.../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts????| 17
> ++++++++++++++
> ?.../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts |??7 ++++++
> ?arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts????| 26
> ++++++++++++++++++++++
> ?arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts????| 11 +++++++++
> ?arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi???|??6 -----
> ?.../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi??????| 20
> +++++++++++++++++
> ?.../boot/dts/amlogic/meson-gxbb-wetek-hub.dts??????| 26
> ++++++++++++++++++++++
> ?.../boot/dts/amlogic/meson-gxbb-wetek-play2.dts????| 26
> ++++++++++++++++++++++
> ?.../boot/dts/amlogic/meson-gxl-s905d-p230.dts??????|??2 ++
> ?.../arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts |??2 ++
> ?arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts?????|??2 ++
> ?12 files changed, 139 insertions(+), 7 deletions(-)
Looks good.
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (9 preceding siblings ...)
2017-01-20 15:27 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
@ 2017-01-20 15:32 ` Martin Blumenstingl
2017-01-20 19:46 ` Kevin Hilman
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
11 siblings, 1 reply; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-20 15:32 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 20, 2017 at 4:22 PM, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
> This series adds the reset GPIOs for the (external) ethernet PHYs on all
> GXBB boards.
> Additionally it provides a ethernet PHY node which can be used to specify
> PHY-specific properties (this may be required if more boards require the
> "eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board .dts
> consistent I chose to add the PHY node also for boards which don't have a
> RTL8211F PHY.
>
> Patch #7 from this series also removes ethernet support for the P200
> board because it was broken anyways and nobody seems to have a board
> available for testing. This was the outcome of the discussion from [0]
>
> Patch #8 was taken from (older versions of) my other series (see [1]):
> "[PATCH net-next v3 0/2] stmmac: dwmac-meson8b: configurable
> RGMII TX delay".
> The binding changes for amlogic,tx-delay-ns were ACK'ed already.
>
> Changes since v2:
> - fixed patch #2 to really update the P200 board (as it's the P200 which
> actually uses a Micrel KSZ9031 RGMII PHY). Thanks to Neil Armstrong for
> spotting this huge mistake!
> - instead of dropping ethernet support for P201 we simply re-configure it
> to RMII mode (replaces patch #7) without a MDIO node (which keeps PHY
> auto-scanning enabled). This got Neil Armstrong's ACK off-list already
>
> Changes since v1:
> - do not move the MDIO bus to meson-gx as this disables PHY auto-scanning
> in the stmmac driver (this drops patch #1 from v1)
> - add the ethernet PHY reset GPIO for nexbox a95x which was forgotten in
> v1
> - add the ethernet PHY reset GPIO for boards which were added since v1
> (wetek hub and wetek play2)
> - rebased to apply against the current v4.11/dt64 branch
> - new in v2 (patch #7): disabled ethernet support for the P200 board (see
> the commit description for more information). this patch is optional
> - new in v2 (patch #9): removed the phy-mode property from meson-gx (see
> the commit description for more information). this patch is optional
>
>
> [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/002053.html
> [1] http://lists.infradead.org/pipermail/linux-amlogic/2016-December/001834.html
>
> Martin Blumenstingl (9):
> ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
> ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
> ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
> ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
> ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
> ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
> ARM64: dts: meson-gxbb-p201: fix ethernet support
> ARM64: dts: amlogic: add the ethernet TX delay configuration
> ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
>
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 -
> .../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 17 ++++++++++++++
> .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 ++++++
> arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 26 ++++++++++++++++++++++
> arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts | 11 +++++++++
> arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 6 -----
> .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 20 +++++++++++++++++
> .../boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 26 ++++++++++++++++++++++
> .../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 26 ++++++++++++++++++++++
> .../boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
> .../arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
> arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
> 12 files changed, 139 insertions(+), 7 deletions(-)
I totally forgot to mention:
this applies to Kevin's v4.11/dt64 branch with Jerome's Odroid-C2
ethernet fix [0] applied on top of it
[0] https://git.kernel.org/cgit/linux/kernel/git/khilman/linux-amlogic.git/commit/?h=v4.11/integ&id=5a2288a68582ad3f1b42ed63ae5a3ca54e000965
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-01-20 15:32 ` Martin Blumenstingl
@ 2017-01-20 19:46 ` Kevin Hilman
0 siblings, 0 replies; 78+ messages in thread
From: Kevin Hilman @ 2017-01-20 19:46 UTC (permalink / raw)
To: linux-arm-kernel
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> On Fri, Jan 20, 2017 at 4:22 PM, Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> wrote:
>> This series adds the reset GPIOs for the (external) ethernet PHYs on all
>> GXBB boards.
>> Additionally it provides a ethernet PHY node which can be used to specify
>> PHY-specific properties (this may be required if more boards require the
>> "eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board .dts
>> consistent I chose to add the PHY node also for boards which don't have a
>> RTL8211F PHY.
>>
>> Patch #7 from this series also removes ethernet support for the P200
>> board because it was broken anyways and nobody seems to have a board
>> available for testing. This was the outcome of the discussion from [0]
>>
>> Patch #8 was taken from (older versions of) my other series (see [1]):
>> "[PATCH net-next v3 0/2] stmmac: dwmac-meson8b: configurable
>> RGMII TX delay".
>> The binding changes for amlogic,tx-delay-ns were ACK'ed already.
>>
>> Changes since v2:
>> - fixed patch #2 to really update the P200 board (as it's the P200 which
>> actually uses a Micrel KSZ9031 RGMII PHY). Thanks to Neil Armstrong for
>> spotting this huge mistake!
>> - instead of dropping ethernet support for P201 we simply re-configure it
>> to RMII mode (replaces patch #7) without a MDIO node (which keeps PHY
>> auto-scanning enabled). This got Neil Armstrong's ACK off-list already
>>
>> Changes since v1:
>> - do not move the MDIO bus to meson-gx as this disables PHY auto-scanning
>> in the stmmac driver (this drops patch #1 from v1)
>> - add the ethernet PHY reset GPIO for nexbox a95x which was forgotten in
>> v1
>> - add the ethernet PHY reset GPIO for boards which were added since v1
>> (wetek hub and wetek play2)
>> - rebased to apply against the current v4.11/dt64 branch
>> - new in v2 (patch #7): disabled ethernet support for the P200 board (see
>> the commit description for more information). this patch is optional
>> - new in v2 (patch #9): removed the phy-mode property from meson-gx (see
>> the commit description for more information). this patch is optional
>>
>>
>> [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/002053.html
>> [1] http://lists.infradead.org/pipermail/linux-amlogic/2016-December/001834.html
>>
>> Martin Blumenstingl (9):
>> ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
>> ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
>> ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
>> ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
>> ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
>> ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
>> ARM64: dts: meson-gxbb-p201: fix ethernet support
>> ARM64: dts: amlogic: add the ethernet TX delay configuration
>> ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
>>
>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 -
>> .../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 17 ++++++++++++++
>> .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 ++++++
>> arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 26 ++++++++++++++++++++++
>> arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts | 11 +++++++++
>> arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 6 -----
>> .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 20 +++++++++++++++++
>> .../boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 26 ++++++++++++++++++++++
>> .../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 26 ++++++++++++++++++++++
>> .../boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
>> .../arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
>> arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
>> 12 files changed, 139 insertions(+), 7 deletions(-)
> I totally forgot to mention:
> this applies to Kevin's v4.11/dt64 branch with Jerome's Odroid-C2
> ethernet fix [0] applied on top of it
So when Jerome's fix lands in mainline (probably by -rc5, maybe -rc6)
I'll rebase the dt64 branch on that and apply this series.
Kevin
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
` (10 preceding siblings ...)
2017-01-20 15:32 ` Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
` (10 more replies)
11 siblings, 11 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This series adds the reset GPIOs for the (external) ethernet PHYs on all
GXBB boards.
Additionally it provides a ethernet PHY node which can be used to specify
PHY-specific properties (this may be required if more boards require the
"eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board .dts
consistent I chose to add the PHY node also for boards which don't have a
RTL8211F PHY.
Patch #7 from this series also removes ethernet support for the P200
board because it was broken anyways and nobody seems to have a board
available for testing. This was the outcome of the discussion from [0]
Patch #8 was taken from (older versions of) my other series (see [1]):
"[PATCH net-next v3 0/2] stmmac: dwmac-meson8b: configurable
RGMII TX delay".
The binding changes for amlogic,tx-delay-ns were ACK'ed already.
NOTE: This applies on top of Jerome's Odroid-C2 EEE patch [3] and Andreas
F?rber's series "ARM64: meson: DT cleanups"
Changes since v3:
- removed "compatible" property from all PHY nodes because that would
force the kernel to choose the driver for the PHY with the ID from the
.dts (instead of the actual PHY ID) - see [2] for more information
(thanks to Andrew Lunn for spotting this). instead the PHY IDs (and
names) are added as a comment inside the corresponding .dts files.
- rebased to apply on top of Andreas F?rber's "ARM64: meson: DT cleanups"
series
Changes since v2:
- fixed patch #2 to really update the P200 board (as it's the P200 which
actually uses a Micrel KSZ9031 RGMII PHY). Thanks to Neil Armstrong for
spotting this huge mistake!
- instead of dropping ethernet support for P201 we simply re-configure it
to RMII mode (replaces patch #7) without a MDIO node (which keeps PHY
auto-scanning enabled). This got Neil Armstrong's ACK off-list already
Changes since v1:
- do not move the MDIO bus to meson-gx as this disables PHY auto-scanning
in the stmmac driver (this drops patch #1 from v1)
- add the ethernet PHY reset GPIO for nexbox a95x which was forgotten in
v1
- add the ethernet PHY reset GPIO for boards which were added since v1
(wetek hub and wetek play2)
- rebased to apply against the current v4.11/dt64 branch
- new in v2 (patch #7): disabled ethernet support for the P200 board (see
the commit description for more information). this patch is optional
- new in v2 (patch #9): removed the phy-mode property from meson-gx (see
the commit description for more information). this patch is optional
[0] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/002053.html
[1] http://lists.infradead.org/pipermail/linux-amlogic/2016-December/001834.html
[2] http://marc.info/?l=linux-netdev&m=148510331812986&w=2
[3] https://git.kernel.org/cgit/linux/kernel/git/khilman/linux-amlogic.git/commit/?h=v4.11/integ&id=5a2288a68582ad3f1b42ed63ae5a3ca54e000965
Martin Blumenstingl (9):
ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-p201: fix ethernet support
ARM64: dts: amlogic: add the ethernet TX delay configuration
ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 -
.../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 16 ++++++++++++++
.../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 ++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 25 ++++++++++++++++++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts | 11 ++++++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 6 ------
.../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 20 +++++++++++++++++
.../boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 25 ++++++++++++++++++++++
.../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 25 ++++++++++++++++++++++
.../boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
.../arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
12 files changed, 135 insertions(+), 7 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v4 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
` (9 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state. While here also explicitly specify the phy-mode instead of
relying on the default-value from meson-gx.dtsi.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 045699616b0f..dc469cd63bb7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -142,6 +142,11 @@
pinctrl-0 = <ð_rgmii_pins>;
pinctrl-names = "default";
phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
mdio {
compatible = "snps,dwmac-mdio";
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
` (8 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
index 03e3d76626dd..666dd1f32f55 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
@@ -51,6 +51,29 @@
model = "Amlogic Meson GXBB P200 Development Board";
};
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 3 {
+ /* Micrel KSZ9031 (0x00221620) */
+ reg = <3>;
+ };
+ };
+};
+
&i2c_B {
status = "okay";
pinctrl-0 = <&i2c_b_pins>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 3/9] ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
` (7 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 81024886d232..9bb9cf765076 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -115,6 +115,24 @@
status = "okay";
pinctrl-0 = <ð_rgmii_pins>;
pinctrl-names = "default";
+
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* Realtek RTL8211F (0x001cc916) */
+ reg = <0>;
+ };
+ };
};
&ir {
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (2 preceding siblings ...)
2017-01-22 18:10 ` [PATCH v4 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
` (6 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
index e642bfd5eec5..cdd2f3107432 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
@@ -164,7 +164,23 @@
status = "okay";
pinctrl-0 = <ð_rmii_pins>;
pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
phy-mode = "rmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* IC Plus IP101GR (0x02430c54) */
+ reg = <0>;
+ };
+ };
};
&ir {
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 5/9] ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (3 preceding siblings ...)
2017-01-22 18:10 ` [PATCH v4 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
` (5 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
.../boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
index 6e35265dc2fc..ad9eb3efa3ec 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
@@ -64,3 +64,26 @@
&cvbs_connector {
status = "disabled";
};
+
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* Realtek RTL8211F (0x001cc916) */
+ reg = <0>;
+ };
+ };
+};
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 6/9] ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (4 preceding siblings ...)
2017-01-22 18:10 ` [PATCH v4 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
` (4 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
index ea79fdd2c248..c1392ed8dd4c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
@@ -87,6 +87,29 @@
};
};
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* Realtek RTL8211F (0x001cc916) */
+ reg = <0>;
+ };
+ };
+};
+
&i2c_A {
status = "okay";
pinctrl-0 = <&i2c_a_pins>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (5 preceding siblings ...)
2017-01-22 18:10 ` [PATCH v4 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
` (3 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
Amlogic's own .dts specifies that the P201 board uses a RMII PHY (with
the reset GPIO being GPIOZ_14).
However our P201 board .dts simply inherits the phy-mode setting from
from meson-gx.dtsi where it defaults to RGMII mode.
Remove all ethernet settings from meson-gxbb-p20x.dtsi as it only
specifies the RGMII pins which are only valid for the P200 board.
Instead we add the ethmac node to the meson-gxbb-p201.dts and configure
the pinctrl property and the phy-mode for an RMII PHY.
An MDIO node (which would also specify the PHY) is not added since we
don't know which PHY is being used (and thus which PHY address would
have to be used).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts | 11 +++++++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 6 ------
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
index 39bb037a3e47..ae3194663d64 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
@@ -50,3 +50,14 @@
compatible = "amlogic,p201", "amlogic,meson-gxbb";
model = "Amlogic Meson GXBB P201 Development Board";
};
+
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rmii_pins>;
+ pinctrl-names = "default";
+ phy-mode = "rmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
index b6f9d051439c..f10e532557b1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
@@ -143,12 +143,6 @@
};
};
-ðmac {
- status = "okay";
- pinctrl-0 = <ð_rgmii_pins>;
- pinctrl-names = "default";
-};
-
&ir {
status = "okay";
pinctrl-0 = <&remote_input_ao_pins>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (6 preceding siblings ...)
2017-01-22 18:10 ` [PATCH v4 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
` (2 subsequent siblings)
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
This adds the amlogic,tx-delay-ns property with the old (hardcoded)
default value of 2ns to all boards which are using an RGMII ethernet
PHY.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
8 files changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index dc469cd63bb7..c951e950131c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -148,6 +148,8 @@
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
+ amlogic,tx-delay-ns = <2>;
+
mdio {
compatible = "snps,dwmac-mdio";
#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
index 666dd1f32f55..a931111152ea 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
@@ -58,6 +58,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 9bb9cf765076..068b385dc05d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -119,6 +119,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
index ad9eb3efa3ec..c683663d6a8c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
@@ -72,6 +72,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
index c1392ed8dd4c..00e92d5e3d3c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
@@ -94,6 +94,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
index f66939cacd37..7663d6775823 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
@@ -59,6 +59,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
/* External PHY reset is shared with internal PHY Led signals */
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
index 804e8de80f37..aa50c923cf36 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
@@ -117,6 +117,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
index 5dbc66088355..e6ac39b712b7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
@@ -59,6 +59,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
/* External PHY reset is shared with internal PHY Led signals */
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (7 preceding siblings ...)
2017-01-22 18:10 ` [PATCH v4 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
@ 2017-01-22 18:10 ` Martin Blumenstingl
2017-01-23 18:55 ` [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay Kevin Hilman
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
10 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-22 18:10 UTC (permalink / raw)
To: linux-arm-kernel
The ethmac node has to be configured for each board due to different
pinctrl nodes for RGMII/RMII. Thus the phy-mode should be specified at
the same place (= in the board .dts), making it easier to read the board
.dts file (because the phy-mode is stated explicitly, without requiring
developers to read all "parent" .dtsi as well).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index 9212fca6eb94..df10d4507ca9 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -377,7 +377,6 @@
0x0 0xc8834540 0x0 0x4>;
interrupts = <0 8 1>;
interrupt-names = "macirq";
- phy-mode = "rgmii";
status = "disabled";
};
--
2.11.0
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (8 preceding siblings ...)
2017-01-22 18:10 ` [PATCH v4 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
@ 2017-01-23 18:55 ` Kevin Hilman
2017-01-23 19:02 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
10 siblings, 1 reply; 78+ messages in thread
From: Kevin Hilman @ 2017-01-23 18:55 UTC (permalink / raw)
To: linux-arm-kernel
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> This series adds the reset GPIOs for the (external) ethernet PHYs on all
> GXBB boards.
> Additionally it provides a ethernet PHY node which can be used to specify
> PHY-specific properties (this may be required if more boards require the
> "eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board .dts
> consistent I chose to add the PHY node also for boards which don't have a
> RTL8211F PHY.
>
> Patch #7 from this series also removes ethernet support for the P200
I think you mean P201 here, right?
Kevin
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-01-23 18:55 ` [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay Kevin Hilman
@ 2017-01-23 19:02 ` Martin Blumenstingl
0 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-01-23 19:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 23, 2017 at 7:55 PM, Kevin Hilman <khilman@baylibre.com> wrote:
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>
>> This series adds the reset GPIOs for the (external) ethernet PHYs on all
>> GXBB boards.
>> Additionally it provides a ethernet PHY node which can be used to specify
>> PHY-specific properties (this may be required if more boards require the
>> "eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board .dts
>> consistent I chose to add the PHY node also for boards which don't have a
>> RTL8211F PHY.
>>
>> Patch #7 from this series also removes ethernet support for the P200
>
> I think you mean P201 here, right?
indeed, that's a left-over of my P200 / P201 mixup in v2 - please ignore this :(
I should have dropped that sentence completely since it's a lie in v3
(v3 states in changes since v2: "instead of dropping ethernet support
for P201 we simply re-configure it to RMII mode")
^ permalink raw reply [flat|nested] 78+ messages in thread
* [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
` (9 preceding siblings ...)
2017-01-23 18:55 ` [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay Kevin Hilman
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
` (9 more replies)
10 siblings, 10 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This series adds the reset GPIOs for the (external) ethernet PHYs on all
GXBB boards.
Additionally it provides a ethernet PHY node which can be used to specify
PHY-specific properties (this may be required if more boards require the
"eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board .dts
consistent I chose to add the PHY node also for boards which don't have a
RTL8211F PHY.
Patch #7 fixes ethernet support on the P201 reference board (this is
untested though due to lack of hardware).
Patch #8 was taken from (older versions of) my other series (see [1]):
"[PATCH net-next v3 0/2] stmmac: dwmac-meson8b: configurable
RGMII TX delay".
The binding changes for amlogic,tx-delay-ns were ACK'ed already.
Changes since v4:
- fixed bogus statement about patch #7 regarding the P200 board in the
cover letter (reword it so it mentions what patch actually does:
fixing ethernet on the P201 board)
- rebased to apply on top of Kevin's v4.11/integ branch since it's
based on v4.10-rc8 which includes Jerome's Odroid-C2 EEE patch
(otherwise patch #1 would have a conflict with that patch)
Changes since v3:
- removed "compatible" property from all PHY nodes because that would
force the kernel to choose the driver for the PHY with the ID from the
.dts (instead of the actual PHY ID) - see [2] for more information
(thanks to Andrew Lunn for spotting this). instead the PHY IDs (and
names) are added as a comment inside the corresponding .dts files.
- rebased to apply on top of Andreas F?rber's "ARM64: meson: DT cleanups"
series
Changes since v2:
- fixed patch #2 to really update the P200 board (as it's the P200 which
actually uses a Micrel KSZ9031 RGMII PHY). Thanks to Neil Armstrong for
spotting this huge mistake!
- instead of dropping ethernet support for P201 we simply re-configure it
to RMII mode (replaces patch #7) without a MDIO node (which keeps PHY
auto-scanning enabled). This got Neil Armstrong's ACK off-list already
Changes since v1:
- do not move the MDIO bus to meson-gx as this disables PHY auto-scanning
in the stmmac driver (this drops patch #1 from v1)
- add the ethernet PHY reset GPIO for nexbox a95x which was forgotten in
v1
- add the ethernet PHY reset GPIO for boards which were added since v1
(wetek hub and wetek play2)
- rebased to apply against the current v4.11/dt64 branch
- new in v2 (patch #7): disabled ethernet support for the P200 board (see
the commit description for more information). this patch is optional
- new in v2 (patch #9): removed the phy-mode property from meson-gx (see
the commit description for more information). this patch is optional
[0] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/002053.html
[1] http://lists.infradead.org/pipermail/linux-amlogic/2016-December/001834.html
[2] http://marc.info/?l=linux-netdev&m=148510331812986&w=2
Martin Blumenstingl (9):
ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
ARM64: dts: meson-gxbb-p201: fix ethernet support
ARM64: dts: amlogic: add the ethernet TX delay configuration
ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 -
.../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 17 ++++++++++++++
.../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 ++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 25 +++++++++++++++++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts | 11 +++++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 6 -----
.../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 21 ++++++++++++++++-
.../boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 26 ++++++++++++++++++++++
.../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 26 ++++++++++++++++++++++
.../boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
.../arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
12 files changed, 138 insertions(+), 8 deletions(-)
--
2.11.1
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v5 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
` (8 subsequent siblings)
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state. While here also explicitly specify the phy-mode instead of
relying on the default-value from meson-gx.dtsi.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index c59403adb387..6b5579522587 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -152,6 +152,11 @@
pinctrl-0 = <ð_rgmii_pins>;
pinctrl-names = "default";
phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
mdio {
compatible = "snps,dwmac-mdio";
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
` (7 subsequent siblings)
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
index fc0e86cb4cde..acb035d119d7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
@@ -96,6 +96,29 @@
};
};
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 3 {
+ /* Micrel KSZ9031 (0x00221620) */
+ reg = <3>;
+ };
+ };
+};
+
&i2c_B {
status = "okay";
pinctrl-0 = <&i2c_b_pins>;
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 3/9] ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
` (6 subsequent siblings)
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index 86709929fd20..aa571970c5e9 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -115,7 +115,6 @@
status = "okay";
pinctrl-0 = <&uart_ao_a_pins>;
pinctrl-names = "default";
-
};
&ir {
@@ -128,6 +127,24 @@
status = "okay";
pinctrl-0 = <ð_rgmii_pins>;
pinctrl-names = "default";
+
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* Realtek RTL8211F (0x001cc916) */
+ reg = <0>;
+ };
+ };
};
&usb0_phy {
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset GPIO
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
` (2 preceding siblings ...)
2017-02-19 21:41 ` [PATCH v5 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
` (5 subsequent siblings)
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
index 4cbd626a9e88..dbfa441f479e 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts
@@ -164,7 +164,24 @@
status = "okay";
pinctrl-0 = <ð_rmii_pins>;
pinctrl-names = "default";
+
+ phy-handle = <ð_phy0>;
phy-mode = "rmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* IC Plus IP101GR (0x02430c54) */
+ reg = <0>;
+ };
+ };
};
&ir {
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 5/9] ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
` (3 preceding siblings ...)
2017-02-19 21:41 ` [PATCH v5 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
` (4 subsequent siblings)
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
.../boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
index 56f855901262..50eb8f06d35b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
@@ -64,3 +64,27 @@
status = "disabled";
};
};
+
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* Realtek RTL8211F (0x001cc916) */
+ reg = <0>;
+ };
+ };
+};
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 6/9] ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset GPIO
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
` (4 preceding siblings ...)
2017-02-19 21:41 ` [PATCH v5 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
` (3 subsequent siblings)
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This resets the ethernet PHY during boot to get the PHY into a "clean"
state.
While here also specify the phy-handle of the ethmac node to make the
PHY configuration similar to the one we have on GXL devices. This will
allow us to specify OF-properties for the PHY itself.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
index ea79fdd2c248..ee86af928722 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
@@ -87,6 +87,30 @@
};
};
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rgmii_pins>;
+ pinctrl-names = "default";
+
+ phy-handle = <ð_phy0>;
+ phy-mode = "rgmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy at 0 {
+ /* Realtek RTL8211F (0x001cc916) */
+ reg = <0>;
+ };
+ };
+};
+
&i2c_A {
status = "okay";
pinctrl-0 = <&i2c_a_pins>;
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
` (5 preceding siblings ...)
2017-02-19 21:41 ` [PATCH v5 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
` (2 subsequent siblings)
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
Amlogic's own .dts specifies that the P201 board uses a RMII PHY (with
the reset GPIO being GPIOZ_14).
However our P201 board .dts simply inherits the phy-mode setting from
from meson-gx.dtsi where it defaults to RGMII mode.
Remove all ethernet settings from meson-gxbb-p20x.dtsi as it only
specifies the RGMII pins which are only valid for the P200 board.
Instead we add the ethmac node to the meson-gxbb-p201.dts and configure
the pinctrl property and the phy-mode for an RMII PHY.
An MDIO node (which would also specify the PHY) is not added since we
don't know which PHY is being used (and thus which PHY address would
have to be used).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts | 11 +++++++++++
arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 6 ------
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
index 39bb037a3e47..ae3194663d64 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
@@ -50,3 +50,14 @@
compatible = "amlogic,p201", "amlogic,meson-gxbb";
model = "Amlogic Meson GXBB P201 Development Board";
};
+
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rmii_pins>;
+ pinctrl-names = "default";
+ phy-mode = "rmii";
+
+ snps,reset-gpio = <&gpio GPIOZ_14 0>;
+ snps,reset-delays-us = <0 10000 1000000>;
+ snps,reset-active-low;
+};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
index 4a96e0f6f926..17ebe46e48d4 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
@@ -144,12 +144,6 @@
pinctrl-names = "default";
};
-ðmac {
- status = "okay";
- pinctrl-0 = <ð_rgmii_pins>;
- pinctrl-names = "default";
-};
-
&ir {
status = "okay";
pinctrl-0 = <&remote_input_ao_pins>;
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
` (6 preceding siblings ...)
2017-02-19 21:41 ` [PATCH v5 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-02-20 9:08 ` [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
This adds the amlogic,tx-delay-ns property with the old (hardcoded)
default value of 2ns to all boards which are using an RGMII ethernet
PHY.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts | 2 ++
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts | 2 ++
8 files changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 6b5579522587..c80d3a913907 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -158,6 +158,8 @@
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
+ amlogic,tx-delay-ns = <2>;
+
mdio {
compatible = "snps,dwmac-mdio";
#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
index acb035d119d7..2054a474e0a9 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
@@ -103,6 +103,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
index aa571970c5e9..aefa66dff72d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
@@ -131,6 +131,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
index 50eb8f06d35b..f057fb48fee5 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dts
@@ -73,6 +73,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
index ee86af928722..743acb5f5d06 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
@@ -95,6 +95,8 @@
phy-handle = <ð_phy0>;
phy-mode = "rgmii";
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
index f66939cacd37..7663d6775823 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts
@@ -59,6 +59,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
/* External PHY reset is shared with internal PHY Led signals */
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
index 5a337d339df1..a0bc746adb42 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
@@ -162,6 +162,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
index 5dbc66088355..e6ac39b712b7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts
@@ -59,6 +59,8 @@
/* Select external PHY by default */
phy-handle = <&external_phy>;
+ amlogic,tx-delay-ns = <2>;
+
/* External PHY reset is shared with internal PHY Led signals */
snps,reset-gpio = <&gpio GPIOZ_14 0>;
snps,reset-delays-us = <0 10000 1000000>;
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
` (7 preceding siblings ...)
2017-02-19 21:41 ` [PATCH v5 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
@ 2017-02-19 21:41 ` Martin Blumenstingl
2017-02-20 9:08 ` [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
9 siblings, 0 replies; 78+ messages in thread
From: Martin Blumenstingl @ 2017-02-19 21:41 UTC (permalink / raw)
To: linux-arm-kernel
The ethmac node has to be configured for each board due to different
pinctrl nodes for RGMII/RMII. Thus the phy-mode should be specified at
the same place (= in the board .dts), making it easier to read the board
.dts file (because the phy-mode is stated explicitly, without requiring
developers to read all "parent" .dtsi as well).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index 5d995f7724af..d544b8f2ffbf 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -410,7 +410,6 @@
0x0 0xc8834540 0x0 0x4>;
interrupts = <0 8 1>;
interrupt-names = "macirq";
- phy-mode = "rgmii";
status = "disabled";
};
--
2.11.1
^ permalink raw reply related [flat|nested] 78+ messages in thread* [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
` (8 preceding siblings ...)
2017-02-19 21:41 ` [PATCH v5 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
@ 2017-02-20 9:08 ` Jerome Brunet
2017-03-02 17:02 ` Kevin Hilman
9 siblings, 1 reply; 78+ messages in thread
From: Jerome Brunet @ 2017-02-20 9:08 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, 2017-02-19 at 22:41 +0100, Martin Blumenstingl wrote:
> This series adds the reset GPIOs for the (external) ethernet PHYs on
> all
> GXBB boards.
> Additionally it provides a ethernet PHY node which can be used to
> specify
> PHY-specific properties (this may be required if more boards require
> the
> "eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board
> .dts
> consistent I chose to add the PHY node also for boards which don't
> have a
> RTL8211F PHY.
>
Looks good to me. For the patchset:
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Martin Blumenstingl (9):
> ? ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-vega-s95: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-nexbox-a95x: add the ethernet PHY's reset
> GPIO
> ? ARM64: dts: meson-gxbb-wetek-hub: add the ethernet PHY's reset GPIO
> ? ARM64: dts: meson-gxbb-wetek-play2: add the ethernet PHY's reset
> GPIO
> ? ARM64: dts: meson-gxbb-p201: fix ethernet support
> ? ARM64: dts: amlogic: add the ethernet TX delay configuration
> ? ARM64: dts: meson-gx: remove the phy-mode property from meson-gx
>
> ?arch/arm64/boot/dts/amlogic/meson-gx.dtsi??????????|??1 -
> ?.../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts????| 17
> ++++++++++++++
> ?.../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts |??7 ++++++
> ?arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts????| 25
> +++++++++++++++++++++
> ?arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts????| 11 +++++++++
> ?arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi???|??6 -----
> ?.../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi??????| 21
> ++++++++++++++++-
> ?.../boot/dts/amlogic/meson-gxbb-wetek-hub.dts??????| 26
> ++++++++++++++++++++++
> ?.../boot/dts/amlogic/meson-gxbb-wetek-play2.dts????| 26
> ++++++++++++++++++++++
> ?.../boot/dts/amlogic/meson-gxl-s905d-p230.dts??????|??2 ++
> ?.../arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts |??2 ++
> ?arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts?????|??2 ++
> ?12 files changed, 138 insertions(+), 8 deletions(-)
>
^ permalink raw reply [flat|nested] 78+ messages in thread* [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay
2017-02-20 9:08 ` [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
@ 2017-03-02 17:02 ` Kevin Hilman
0 siblings, 0 replies; 78+ messages in thread
From: Kevin Hilman @ 2017-03-02 17:02 UTC (permalink / raw)
To: linux-arm-kernel
Jerome Brunet <jbrunet@baylibre.com> writes:
> On Sun, 2017-02-19 at 22:41 +0100, Martin Blumenstingl wrote:
>> This series adds the reset GPIOs for the (external) ethernet PHYs on
>> all
>> GXBB boards.
>> Additionally it provides a ethernet PHY node which can be used to
>> specify
>> PHY-specific properties (this may be required if more boards require
>> the
>> "eee-broken-1000t" for the RTL8211F ethernet PHY). To make all board
>> .dts
>> consistent I chose to add the PHY node also for boards which don't
>> have a
>> RTL8211F PHY.
>>
>
> Looks good to me. For the patchset:
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>
Applying to v4.12/dt64 with Jerome's review.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 78+ messages in thread