* [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init()
@ 2017-01-22 16:41 Wei Yongjun
2017-01-22 18:12 ` Russell King - ARM Linux
2017-02-05 16:32 ` [PATCH -next v2] ARM: hisi: " Wei Yongjun
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2017-01-22 16:41 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return error code -ENODEV from the of_find_compatible_node()
error handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
arch/arm/mach-hisi/platmcpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
index a6c1176..f0fff21 100644
--- a/arch/arm/mach-hisi/platmcpm.c
+++ b/arch/arm/mach-hisi/platmcpm.c
@@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
&hip04_boot_method[0], 4);
if (ret)
goto err;
+
+ ret = -ENODEV;
np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
if (!np_sctl)
goto err;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init()
2017-01-22 16:41 [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() Wei Yongjun
@ 2017-01-22 18:12 ` Russell King - ARM Linux
2017-02-05 16:32 ` [PATCH -next v2] ARM: hisi: " Wei Yongjun
1 sibling, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2017-01-22 18:12 UTC (permalink / raw)
To: linux-arm-kernel
What does this have to do with patch 8641/1
("ARM: 8641/1: treewide: Replace uses of virt_to_phys with __pa_symbol") ?
Your patch also isn't "treewide" either. Confused.
On Sun, Jan 22, 2017 at 04:41:28PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the of_find_compatible_node()
> error handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/arm/mach-hisi/platmcpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index a6c1176..f0fff21 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
> &hip04_boot_method[0], 4);
> if (ret)
> goto err;
> +
> + ret = -ENODEV;
> np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
> if (!np_sctl)
> goto err;
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()
2017-01-22 16:41 [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() Wei Yongjun
2017-01-22 18:12 ` Russell King - ARM Linux
@ 2017-02-05 16:32 ` Wei Yongjun
2017-04-10 15:23 ` Wei Xu
1 sibling, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2017-02-05 16:32 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return error code -ENODEV from the of_find_compatible_node()
error handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: fix file module
---
arch/arm/mach-hisi/platmcpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
index a6c1176..f0fff21 100644
--- a/arch/arm/mach-hisi/platmcpm.c
+++ b/arch/arm/mach-hisi/platmcpm.c
@@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
&hip04_boot_method[0], 4);
if (ret)
goto err;
+
+ ret = -ENODEV;
np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
if (!np_sctl)
goto err;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()
2017-02-05 16:32 ` [PATCH -next v2] ARM: hisi: " Wei Yongjun
@ 2017-04-10 15:23 ` Wei Xu
0 siblings, 0 replies; 4+ messages in thread
From: Wei Xu @ 2017-04-10 15:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi Yongjun,
On 2017/2/5 16:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the of_find_compatible_node()
> error handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks!
Applied to the hisilicon soc tree.
Best Regards,
Wei
> ---
> v1 -> v2: fix file module
> ---
> arch/arm/mach-hisi/platmcpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index a6c1176..f0fff21 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
> &hip04_boot_method[0], 4);
> if (ret)
> goto err;
> +
> + ret = -ENODEV;
> np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
> if (!np_sctl)
> goto err;
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-10 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-22 16:41 [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() Wei Yongjun
2017-01-22 18:12 ` Russell King - ARM Linux
2017-02-05 16:32 ` [PATCH -next v2] ARM: hisi: " Wei Yongjun
2017-04-10 15:23 ` Wei Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).