[PATCH 0/4] ARM/arm64: dts: renesas: Link ARM GIC to clock and clock domain

[PATCH 0/4] ARM/arm64: dts: renesas: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

	Hi Simon, Magnus,

This patch series improves the topology description in DT of the ARM GIC
on Renesas SoCs using the CPG/MSSR bindings (R-Car Gen3 and RZ/G).
It links the GIC to its module clock, and adds it to the SYSC "always
on" PM Domain.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.
As the CPG/MSSR driver, unlike the legacy MSTP driver, is already aware
of critical clocks, this series can be applied right now.

Thanks!

Geert Uytterhoeven (4):
  ARM: dts: r8a7743: Link ARM GIC to clock and clock domain
  ARM: dts: r8a7745: Link ARM GIC to clock and clock domain
  arm64: dts: r8a7795: Link ARM GIC to clock and clock domain
  arm64: dts: r8a7796: Link ARM GIC to clock and clock domain

 arch/arm/boot/dts/r8a7743.dtsi           | 3 +++
 arch/arm/boot/dts/r8a7745.dtsi           | 3 +++
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 3 +++
 4 files changed, 12 insertions(+)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/4] ARM: dts: r8a7743: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock, and add it to the SYSC
"always-on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7743.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 0956125597fdf835..40d2cdede7022ff6 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -60,6 +60,9 @@
 			      <0 0xf1006000 0 0x2000>;
 			interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) |
 						 IRQ_TYPE_LEVEL_HIGH)>;
+			clocks = <&cpg CPG_MOD 408>;
+			clock-names = "clk";
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
 		};
 
 		irqc: interrupt-controller at e61c0000 {
-- 
1.9.1

[PATCH 2/4] ARM: dts: r8a7745: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-SYS module clock, and add it to the SYSC
"always-on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7745.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
index 2f60c3cb91177e0f..a81dcc82e2eadd09 100644
--- a/arch/arm/boot/dts/r8a7745.dtsi
+++ b/arch/arm/boot/dts/r8a7745.dtsi
@@ -60,6 +60,9 @@
 			      <0 0xf1006000 0 0x2000>;
 			interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) |
 						 IRQ_TYPE_LEVEL_HIGH)>;
+			clocks = <&cpg CPG_MOD 408>;
+			clock-names = "clk";
+			power-domains = <&sysc R8A7745_PD_ALWAYS_ON>;
 		};
 
 		irqc: interrupt-controller at e61c0000 {
-- 
1.9.1

[PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-AP module clock, and add it to the SYSC
"always-on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 026a16ac41b422a1..0627df2a0b810c86 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -166,6 +166,9 @@
 			      <0x0 0xf1060000 0 0x20000>;
 			interrupts = <GIC_PPI 9
 					(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+			clocks = <&cpg CPG_MOD 408>;
+			clock-names = "clk";
+			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
 		};
 
 		wdt0: watchdog at e6020000 {
-- 
1.9.1

[PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain

[Ramesh Shanmugasundaram]

Hi Geert,

> Subject: [PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock
> domain
> 
> Link the ARM GIC to the INTC-AP module clock, and add it to the SYSC
> "always-on" PM Domain, so it can be power managed using that clock.
> 
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 026a16ac41b422a1..0627df2a0b810c86 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -166,6 +166,9 @@
>  			      <0x0 0xf1060000 0 0x20000>;
>  			interrupts = <GIC_PPI 9
>  					(GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_HIGH)>;
> +			clocks = <&cpg CPG_MOD 408>;
> +			clock-names = "clk";

Should the module clock be named "fck"?

Thanks,
Ramesh

[PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Hi Ramesh,

On Tue, Jan 17, 2017 at 3:00 PM, Ramesh Shanmugasundaram
<ramesh.shanmugasundaram@bp.renesas.com> wrote:
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -166,6 +166,9 @@
>>                             <0x0 0xf1060000 0 0x20000>;
>>                       interrupts = <GIC_PPI 9
>>                                       (GIC_CPU_MASK_SIMPLE(4) |
>> IRQ_TYPE_LEVEL_HIGH)>;
>> +                     clocks = <&cpg CPG_MOD 408>;
>> +                     clock-names = "clk";
>
> Should the module clock be named "fck"?

Not according to
Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt.

P.S. If you use "git blame", you may think I'm cheating, but naming was
     ased on the actual Technical Reference Manuals ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 4/4] arm64: dts: r8a7796: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-AP module clock, and add it to the SYSC
"always-on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index eb446d9666213720..6591c76613687b40 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -101,6 +101,9 @@
 			      <0x0 0xf1060000 0 0x20000>;
 			interrupts = <GIC_PPI 9
 					(GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_HIGH)>;
+			clocks = <&cpg CPG_MOD 408>;
+			clock-names = "clk";
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
 		};
 
 		timer {
-- 
1.9.1

[PATCH 0/4] ARM/arm64: dts: renesas: Link ARM GIC to clock and clock domain

[Simon Horman]

On Tue, Jan 17, 2017 at 01:49:16PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series improves the topology description in DT of the ARM GIC
> on Renesas SoCs using the CPG/MSSR bindings (R-Car Gen3 and RZ/G).
> It links the GIC to its module clock, and adds it to the SYSC "always
> on" PM Domain.
> 
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.
> As the CPG/MSSR driver, unlike the legacy MSTP driver, is already aware
> of critical clocks, this series can be applied right now.

Hi Geert,

does the note above imply that "[PATCH 0/2] clk: renesas: Use
CLK_IS_CRITICAL to handle critical clocks" is a dependency of this series?

[PATCH 0/4] ARM/arm64: dts: renesas: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Hi Simon,

On Mon, Jan 23, 2017 at 10:23 AM, Simon Horman <horms@verge.net.au> wrote:
> On Tue, Jan 17, 2017 at 01:49:16PM +0100, Geert Uytterhoeven wrote:
>> This patch series improves the topology description in DT of the ARM GIC
>> on Renesas SoCs using the CPG/MSSR bindings (R-Car Gen3 and RZ/G).
>> It links the GIC to its module clock, and adds it to the SYSC "always
>> on" PM Domain.
>>
>> Note that currently the GIC-400 driver doesn't support module clocks nor
>> Runtime PM, so this must be handled as a critical clock.
>> As the CPG/MSSR driver, unlike the legacy MSTP driver, is already aware
>> of critical clocks, this series can be applied right now.
>
> does the note above imply that "[PATCH 0/2] clk: renesas: Use
> CLK_IS_CRITICAL to handle critical clocks" is a dependency of this series?

No, the note says (using different wording) that there is no such dependency.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 0/4] ARM/arm64: dts: renesas: Link ARM GIC to clock and clock domain

[Simon Horman]

On Mon, Jan 23, 2017 at 10:26:34AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Jan 23, 2017 at 10:23 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Jan 17, 2017 at 01:49:16PM +0100, Geert Uytterhoeven wrote:
> >> This patch series improves the topology description in DT of the ARM GIC
> >> on Renesas SoCs using the CPG/MSSR bindings (R-Car Gen3 and RZ/G).
> >> It links the GIC to its module clock, and adds it to the SYSC "always
> >> on" PM Domain.
> >>
> >> Note that currently the GIC-400 driver doesn't support module clocks nor
> >> Runtime PM, so this must be handled as a critical clock.
> >> As the CPG/MSSR driver, unlike the legacy MSTP driver, is already aware
> >> of critical clocks, this series can be applied right now.
> >
> > does the note above imply that "[PATCH 0/2] clk: renesas: Use
> > CLK_IS_CRITICAL to handle critical clocks" is a dependency of this series?
> 
> No, the note says (using different wording) that there is no such dependency.

Thanks, I see that now.
I have queued up these changes.