* [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
@ 2017-01-11 13:50 David Engraf
2017-01-17 9:13 ` Daniel Lezcano
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: David Engraf @ 2017-01-11 13:50 UTC (permalink / raw)
To: linux-arm-kernel
On newer boards the TC can be read as single 32 bit value without locking.
Thus the clock can be used as reference for sched_clock which is much more
accurate than the jiffies implementation.
Tested on a Atmel SAMA5D2 board.
Signed-off-by: David Engraf <david.engraf@sysgo.com>
---
drivers/clocksource/tcb_clksrc.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c
index d4ca996..745844e 100644
--- a/drivers/clocksource/tcb_clksrc.c
+++ b/drivers/clocksource/tcb_clksrc.c
@@ -10,6 +10,7 @@
#include <linux/io.h>
#include <linux/platform_device.h>
#include <linux/atmel_tc.h>
+#include <linux/sched_clock.h>
/*
@@ -56,11 +57,16 @@ static u64 tc_get_cycles(struct clocksource *cs)
return (upper << 16) | lower;
}
-static u64 tc_get_cycles32(struct clocksource *cs)
+static u32 tc_get_cv32(void)
{
return __raw_readl(tcaddr + ATMEL_TC_REG(0, CV));
}
+static u64 tc_get_cycles32(struct clocksource *cs)
+{
+ return tc_get_cv32();
+}
+
static struct clocksource clksrc = {
.name = "tcb_clksrc",
.rating = 200,
@@ -69,6 +75,11 @@ static struct clocksource clksrc = {
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
};
+static u64 notrace tc_read_sched_clock(void)
+{
+ return tc_get_cv32();
+}
+
#ifdef CONFIG_GENERIC_CLOCKEVENTS
struct tc_clkevt_device {
@@ -339,6 +350,9 @@ static int __init tcb_clksrc_init(void)
clksrc.read = tc_get_cycles32;
/* setup ony channel 0 */
tcb_setup_single_chan(tc, best_divisor_idx);
+
+ /* register sched_clock on chips with single 32 bit counter */
+ sched_clock_register(tc_read_sched_clock, 32, divided_rate);
} else {
/* tclib will give us three clocks no matter what the
* underlying platform supports.
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
2017-01-11 13:50 [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock David Engraf
@ 2017-01-17 9:13 ` Daniel Lezcano
2017-01-17 9:29 ` David Engraf
2017-01-17 9:42 ` Mason
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Daniel Lezcano @ 2017-01-17 9:13 UTC (permalink / raw)
To: linux-arm-kernel
On 11/01/2017 14:50, David Engraf wrote:
> On newer boards the TC can be read as single 32 bit value without locking.
> Thus the clock can be used as reference for sched_clock which is much more
> accurate than the jiffies implementation.
>
> Tested on a Atmel SAMA5D2 board.
Is this change backward compatible ?
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
> ---
> drivers/clocksource/tcb_clksrc.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c
> index d4ca996..745844e 100644
> --- a/drivers/clocksource/tcb_clksrc.c
> +++ b/drivers/clocksource/tcb_clksrc.c
> @@ -10,6 +10,7 @@
> #include <linux/io.h>
> #include <linux/platform_device.h>
> #include <linux/atmel_tc.h>
> +#include <linux/sched_clock.h>
>
>
> /*
> @@ -56,11 +57,16 @@ static u64 tc_get_cycles(struct clocksource *cs)
> return (upper << 16) | lower;
> }
>
> -static u64 tc_get_cycles32(struct clocksource *cs)
> +static u32 tc_get_cv32(void)
> {
> return __raw_readl(tcaddr + ATMEL_TC_REG(0, CV));
> }
>
> +static u64 tc_get_cycles32(struct clocksource *cs)
> +{
> + return tc_get_cv32();
> +}
> +
> static struct clocksource clksrc = {
> .name = "tcb_clksrc",
> .rating = 200,
> @@ -69,6 +75,11 @@ static struct clocksource clksrc = {
> .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> };
>
> +static u64 notrace tc_read_sched_clock(void)
> +{
> + return tc_get_cv32();
> +}
> +
> #ifdef CONFIG_GENERIC_CLOCKEVENTS
>
> struct tc_clkevt_device {
> @@ -339,6 +350,9 @@ static int __init tcb_clksrc_init(void)
> clksrc.read = tc_get_cycles32;
> /* setup ony channel 0 */
> tcb_setup_single_chan(tc, best_divisor_idx);
> +
> + /* register sched_clock on chips with single 32 bit counter */
> + sched_clock_register(tc_read_sched_clock, 32, divided_rate);
> } else {
> /* tclib will give us three clocks no matter what the
> * underlying platform supports.
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
2017-01-17 9:13 ` Daniel Lezcano
@ 2017-01-17 9:29 ` David Engraf
0 siblings, 0 replies; 7+ messages in thread
From: David Engraf @ 2017-01-17 9:29 UTC (permalink / raw)
To: linux-arm-kernel
Am 17.01.2017 um 10:13 schrieb Daniel Lezcano:
> On 11/01/2017 14:50, David Engraf wrote:
>> On newer boards the TC can be read as single 32 bit value without locking.
>> Thus the clock can be used as reference for sched_clock which is much more
>> accurate than the jiffies implementation.
>>
>> Tested on a Atmel SAMA5D2 board.
>
> Is this change backward compatible ?
The way how the driver reads the clock hasn't been changed. I've only
introduced the call to sched_clock_register() which will use this clock
for the scheduler as long as no better clock is already used. So I don't
see a backward compatibility problem.
Best regards
- David
>
>> Signed-off-by: David Engraf <david.engraf@sysgo.com>
>> ---
>> drivers/clocksource/tcb_clksrc.c | 16 +++++++++++++++-
>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c
>> index d4ca996..745844e 100644
>> --- a/drivers/clocksource/tcb_clksrc.c
>> +++ b/drivers/clocksource/tcb_clksrc.c
>> @@ -10,6 +10,7 @@
>> #include <linux/io.h>
>> #include <linux/platform_device.h>
>> #include <linux/atmel_tc.h>
>> +#include <linux/sched_clock.h>
>>
>>
>> /*
>> @@ -56,11 +57,16 @@ static u64 tc_get_cycles(struct clocksource *cs)
>> return (upper << 16) | lower;
>> }
>>
>> -static u64 tc_get_cycles32(struct clocksource *cs)
>> +static u32 tc_get_cv32(void)
>> {
>> return __raw_readl(tcaddr + ATMEL_TC_REG(0, CV));
>> }
>>
>> +static u64 tc_get_cycles32(struct clocksource *cs)
>> +{
>> + return tc_get_cv32();
>> +}
>> +
>> static struct clocksource clksrc = {
>> .name = "tcb_clksrc",
>> .rating = 200,
>> @@ -69,6 +75,11 @@ static struct clocksource clksrc = {
>> .flags = CLOCK_SOURCE_IS_CONTINUOUS,
>> };
>>
>> +static u64 notrace tc_read_sched_clock(void)
>> +{
>> + return tc_get_cv32();
>> +}
>> +
>> #ifdef CONFIG_GENERIC_CLOCKEVENTS
>>
>> struct tc_clkevt_device {
>> @@ -339,6 +350,9 @@ static int __init tcb_clksrc_init(void)
>> clksrc.read = tc_get_cycles32;
>> /* setup ony channel 0 */
>> tcb_setup_single_chan(tc, best_divisor_idx);
>> +
>> + /* register sched_clock on chips with single 32 bit counter */
>> + sched_clock_register(tc_read_sched_clock, 32, divided_rate);
>> } else {
>> /* tclib will give us three clocks no matter what the
>> * underlying platform supports.
>>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
2017-01-11 13:50 [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock David Engraf
2017-01-17 9:13 ` Daniel Lezcano
@ 2017-01-17 9:42 ` Mason
2017-01-23 13:59 ` Daniel Lezcano
2017-01-24 13:39 ` Nicolas Ferre
3 siblings, 0 replies; 7+ messages in thread
From: Mason @ 2017-01-17 9:42 UTC (permalink / raw)
To: linux-arm-kernel
On 11/01/2017 14:50, David Engraf wrote:
> Subject: [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
I was puzzled by the TCB acronym :-)
Trusted Computing Base
Task Control Block
Transfer Control Block
Test Control Board
In fact, it (probably) stands for Timer Counter Block, which makes
sense for a clksrc patch.
Regards.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
2017-01-11 13:50 [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock David Engraf
2017-01-17 9:13 ` Daniel Lezcano
2017-01-17 9:42 ` Mason
@ 2017-01-23 13:59 ` Daniel Lezcano
2017-01-24 13:39 ` Nicolas Ferre
2017-01-24 13:39 ` Nicolas Ferre
3 siblings, 1 reply; 7+ messages in thread
From: Daniel Lezcano @ 2017-01-23 13:59 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 11, 2017 at 02:50:59PM +0100, David Engraf wrote:
> On newer boards the TC can be read as single 32 bit value without locking.
> Thus the clock can be used as reference for sched_clock which is much more
> accurate than the jiffies implementation.
>
> Tested on a Atmel SAMA5D2 board.
>
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
> ---
Nicolas,
if you agree I will take this change.
-- Daniel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
2017-01-23 13:59 ` Daniel Lezcano
@ 2017-01-24 13:39 ` Nicolas Ferre
0 siblings, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2017-01-24 13:39 UTC (permalink / raw)
To: linux-arm-kernel
Le 23/01/2017 ? 14:59, Daniel Lezcano a ?crit :
> On Wed, Jan 11, 2017 at 02:50:59PM +0100, David Engraf wrote:
>> On newer boards the TC can be read as single 32 bit value without locking.
>> Thus the clock can be used as reference for sched_clock which is much more
>> accurate than the jiffies implementation.
>>
>> Tested on a Atmel SAMA5D2 board.
>>
>> Signed-off-by: David Engraf <david.engraf@sysgo.com>
>> ---
>
> Nicolas,
>
> if you agree I will take this change.
Absolutely. I've just added the Ack.
Thanks for the head-up. Bye,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock
2017-01-11 13:50 [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock David Engraf
` (2 preceding siblings ...)
2017-01-23 13:59 ` Daniel Lezcano
@ 2017-01-24 13:39 ` Nicolas Ferre
3 siblings, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2017-01-24 13:39 UTC (permalink / raw)
To: linux-arm-kernel
Le 11/01/2017 ? 14:50, David Engraf a ?crit :
> On newer boards the TC can be read as single 32 bit value without locking.
> Thus the clock can be used as reference for sched_clock which is much more
> accurate than the jiffies implementation.
>
> Tested on a Atmel SAMA5D2 board.
>
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks,
> ---
> drivers/clocksource/tcb_clksrc.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c
> index d4ca996..745844e 100644
> --- a/drivers/clocksource/tcb_clksrc.c
> +++ b/drivers/clocksource/tcb_clksrc.c
> @@ -10,6 +10,7 @@
> #include <linux/io.h>
> #include <linux/platform_device.h>
> #include <linux/atmel_tc.h>
> +#include <linux/sched_clock.h>
>
>
> /*
> @@ -56,11 +57,16 @@ static u64 tc_get_cycles(struct clocksource *cs)
> return (upper << 16) | lower;
> }
>
> -static u64 tc_get_cycles32(struct clocksource *cs)
> +static u32 tc_get_cv32(void)
> {
> return __raw_readl(tcaddr + ATMEL_TC_REG(0, CV));
> }
>
> +static u64 tc_get_cycles32(struct clocksource *cs)
> +{
> + return tc_get_cv32();
> +}
> +
> static struct clocksource clksrc = {
> .name = "tcb_clksrc",
> .rating = 200,
> @@ -69,6 +75,11 @@ static struct clocksource clksrc = {
> .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> };
>
> +static u64 notrace tc_read_sched_clock(void)
> +{
> + return tc_get_cv32();
> +}
> +
> #ifdef CONFIG_GENERIC_CLOCKEVENTS
>
> struct tc_clkevt_device {
> @@ -339,6 +350,9 @@ static int __init tcb_clksrc_init(void)
> clksrc.read = tc_get_cycles32;
> /* setup ony channel 0 */
> tcb_setup_single_chan(tc, best_divisor_idx);
> +
> + /* register sched_clock on chips with single 32 bit counter */
> + sched_clock_register(tc_read_sched_clock, 32, divided_rate);
> } else {
> /* tclib will give us three clocks no matter what the
> * underlying platform supports.
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-24 13:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-11 13:50 [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock David Engraf
2017-01-17 9:13 ` Daniel Lezcano
2017-01-17 9:29 ` David Engraf
2017-01-17 9:42 ` Mason
2017-01-23 13:59 ` Daniel Lezcano
2017-01-24 13:39 ` Nicolas Ferre
2017-01-24 13:39 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).