* [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator
@ 2017-01-19 14:21 Lucas Stach
2017-01-19 14:21 ` [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5 Lucas Stach
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Lucas Stach @ 2017-01-19 14:21 UTC (permalink / raw)
To: linux-arm-kernel
The regulation bound of this regulator are 2.1V to 2.875V, the
wrong DT values cause the driver to miscalculate the effective
voltage.
This isn't really an issue right now, as nobody actively changes
the regulator voltage, but better fix it now.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 53e6e63cbb02..9313b9af2da8 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -661,8 +661,8 @@
anatop-vol-bit-shift = <8>;
anatop-vol-bit-width = <5>;
anatop-min-bit-val = <0>;
- anatop-min-voltage = <2000000>;
- anatop-max-voltage = <2750000>;
+ anatop-min-voltage = <2100000>;
+ anatop-max-voltage = <2875000>;
};
reg_arm: regulator-vddcore {
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5
2017-01-19 14:21 [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Lucas Stach
@ 2017-01-19 14:21 ` Lucas Stach
2017-01-19 14:42 ` Philipp Zabel
2017-01-19 14:41 ` [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Philipp Zabel
2017-01-24 6:43 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Lucas Stach @ 2017-01-19 14:21 UTC (permalink / raw)
To: linux-arm-kernel
Fix the min/max voltage constraints for the anatop 1p1 and 2p5
regulator to match the typical operating range mentioned in the
datasheet.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 9313b9af2da8..e9ba244cda54 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -626,8 +626,8 @@
regulator-1p1 {
compatible = "fsl,anatop-regulator";
regulator-name = "vdd1p1";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <1375000>;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1200000>;
regulator-always-on;
anatop-reg-offset = <0x110>;
anatop-vol-bit-shift = <8>;
@@ -654,7 +654,7 @@
regulator-2p5 {
compatible = "fsl,anatop-regulator";
regulator-name = "vdd2p5";
- regulator-min-microvolt = <2000000>;
+ regulator-min-microvolt = <2250000>;
regulator-max-microvolt = <2750000>;
regulator-always-on;
anatop-reg-offset = <0x130>;
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5
2017-01-19 14:21 ` [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5 Lucas Stach
@ 2017-01-19 14:42 ` Philipp Zabel
0 siblings, 0 replies; 5+ messages in thread
From: Philipp Zabel @ 2017-01-19 14:42 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2017-01-19 at 15:21 +0100, Lucas Stach wrote:
> Fix the min/max voltage constraints for the anatop 1p1 and 2p5
> regulator to match the typical operating range mentioned in the
> datasheet.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 9313b9af2da8..e9ba244cda54 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -626,8 +626,8 @@
> regulator-1p1 {
> compatible = "fsl,anatop-regulator";
> regulator-name = "vdd1p1";
> - regulator-min-microvolt = <800000>;
> - regulator-max-microvolt = <1375000>;
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1200000>;
> regulator-always-on;
> anatop-reg-offset = <0x110>;
> anatop-vol-bit-shift = <8>;
> @@ -654,7 +654,7 @@
> regulator-2p5 {
> compatible = "fsl,anatop-regulator";
> regulator-name = "vdd2p5";
> - regulator-min-microvolt = <2000000>;
> + regulator-min-microvolt = <2250000>;
> regulator-max-microvolt = <2750000>;
> regulator-always-on;
> anatop-reg-offset = <0x130>;
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator
2017-01-19 14:21 [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Lucas Stach
2017-01-19 14:21 ` [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5 Lucas Stach
@ 2017-01-19 14:41 ` Philipp Zabel
2017-01-24 6:43 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Philipp Zabel @ 2017-01-19 14:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2017-01-19 at 15:21 +0100, Lucas Stach wrote:
> The regulation bound of this regulator are 2.1V to 2.875V, the
> wrong DT values cause the driver to miscalculate the effective
> voltage.
As easily checked with
$ grep vdd2p5 /sys/kernel/debug/regulator/regulator_summary
- vdd2p5 0 0 0 2400mV 0mA 2000mV 2750mV
+ vdd2p5 0 0 0 2500mV 0mA 2000mV 2750mV
> This isn't really an issue right now, as nobody actively changes
> the regulator voltage, but better fix it now.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 53e6e63cbb02..9313b9af2da8 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -661,8 +661,8 @@
> anatop-vol-bit-shift = <8>;
> anatop-vol-bit-width = <5>;
> anatop-min-bit-val = <0>;
> - anatop-min-voltage = <2000000>;
> - anatop-max-voltage = <2750000>;
> + anatop-min-voltage = <2100000>;
> + anatop-max-voltage = <2875000>;
> };
>
> reg_arm: regulator-vddcore {
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator
2017-01-19 14:21 [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Lucas Stach
2017-01-19 14:21 ` [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5 Lucas Stach
2017-01-19 14:41 ` [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Philipp Zabel
@ 2017-01-24 6:43 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2017-01-24 6:43 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 19, 2017 at 03:21:33PM +0100, Lucas Stach wrote:
> The regulation bound of this regulator are 2.1V to 2.875V, the
> wrong DT values cause the driver to miscalculate the effective
> voltage.
>
> This isn't really an issue right now, as nobody actively changes
> the regulator voltage, but better fix it now.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied both, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-24 6:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 14:21 [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Lucas Stach
2017-01-19 14:21 ` [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5 Lucas Stach
2017-01-19 14:42 ` Philipp Zabel
2017-01-19 14:41 ` [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Philipp Zabel
2017-01-24 6:43 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).