* [PATCH] perf: xgene: Include module.h
@ 2017-01-25 23:46 Stephen Boyd
2017-01-26 2:13 ` Tai Tri Nguyen
2017-01-26 3:29 ` Tai Tri Nguyen
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Boyd @ 2017-01-25 23:46 UTC (permalink / raw)
To: linux-arm-kernel
I ran into a build error when I disabled CONFIG_ACPI and tried to
compile this driver:
drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
^
drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
Include module.h for the MODULE_DEVICE_TABLE macro that's
implicitly included through ACPI.
Cc: Tai Nguyen <ttnguyen@apm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/perf/xgene_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index a8ac4bcef2c0..fb3281962a6d 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -20,6 +20,7 @@
*/
#include <linux/acpi.h>
+#include <linux/module.h>
#include <linux/clk.h>
#include <linux/cpumask.h>
#include <linux/interrupt.h>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] perf: xgene: Include module.h
2017-01-25 23:46 [PATCH] perf: xgene: Include module.h Stephen Boyd
@ 2017-01-26 2:13 ` Tai Tri Nguyen
2017-01-26 2:16 ` Tai Tri Nguyen
2017-01-26 3:29 ` Tai Tri Nguyen
1 sibling, 1 reply; 5+ messages in thread
From: Tai Tri Nguyen @ 2017-01-26 2:13 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stephen,
On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> I ran into a build error when I disabled CONFIG_ACPI and tried to
> compile this driver:
I tried kernel 4.9 and couldn't reproduce the issue.
What is the kernel version you are seeing the compilation issue?
Regards
Tai
>
> drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
> MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
> ^
> drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
>
> Include module.h for the MODULE_DEVICE_TABLE macro that's
> implicitly included through ACPI.
>
> Cc: Tai Nguyen <ttnguyen@apm.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/perf/xgene_pmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> index a8ac4bcef2c0..fb3281962a6d 100644
> --- a/drivers/perf/xgene_pmu.c
> +++ b/drivers/perf/xgene_pmu.c
> @@ -20,6 +20,7 @@
> */
>
> #include <linux/acpi.h>
> +#include <linux/module.h>
> #include <linux/clk.h>
> #include <linux/cpumask.h>
> #include <linux/interrupt.h>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Tai
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] perf: xgene: Include module.h
2017-01-26 2:13 ` Tai Tri Nguyen
@ 2017-01-26 2:16 ` Tai Tri Nguyen
0 siblings, 0 replies; 5+ messages in thread
From: Tai Tri Nguyen @ 2017-01-26 2:16 UTC (permalink / raw)
To: linux-arm-kernel
My bad, I can reproduce the issue now.
Thanks
Tai
On Wed, Jan 25, 2017 at 6:13 PM, Tai Tri Nguyen <ttnguyen@apm.com> wrote:
> Hi Stephen,
>
> On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> I ran into a build error when I disabled CONFIG_ACPI and tried to
>> compile this driver:
>
> I tried kernel 4.9 and couldn't reproduce the issue.
> What is the kernel version you are seeing the compilation issue?
>
> Regards
> Tai
>
>>
>> drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
>> MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
>> ^
>> drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
>>
>> Include module.h for the MODULE_DEVICE_TABLE macro that's
>> implicitly included through ACPI.
>>
>> Cc: Tai Nguyen <ttnguyen@apm.com>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>> drivers/perf/xgene_pmu.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
>> index a8ac4bcef2c0..fb3281962a6d 100644
>> --- a/drivers/perf/xgene_pmu.c
>> +++ b/drivers/perf/xgene_pmu.c
>> @@ -20,6 +20,7 @@
>> */
>>
>> #include <linux/acpi.h>
>> +#include <linux/module.h>
>> #include <linux/clk.h>
>> #include <linux/cpumask.h>
>> #include <linux/interrupt.h>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
>
>
> --
> Tai
--
Tai
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] perf: xgene: Include module.h
2017-01-25 23:46 [PATCH] perf: xgene: Include module.h Stephen Boyd
2017-01-26 2:13 ` Tai Tri Nguyen
@ 2017-01-26 3:29 ` Tai Tri Nguyen
2017-01-26 12:21 ` Will Deacon
1 sibling, 1 reply; 5+ messages in thread
From: Tai Tri Nguyen @ 2017-01-26 3:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stephen,
On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> I ran into a build error when I disabled CONFIG_ACPI and tried to
> compile this driver:
>
> drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
> MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
> ^
> drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
>
> Include module.h for the MODULE_DEVICE_TABLE macro that's
> implicitly included through ACPI.
>
> Cc: Tai Nguyen <ttnguyen@apm.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/perf/xgene_pmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> index a8ac4bcef2c0..fb3281962a6d 100644
> --- a/drivers/perf/xgene_pmu.c
> +++ b/drivers/perf/xgene_pmu.c
> @@ -20,6 +20,7 @@
> */
>
> #include <linux/acpi.h>
> +#include <linux/module.h>
Please fix alphabetic order of the include file.
Tested-by: Tai Nguyen <ttnguyen@apm.com>
> #include <linux/clk.h>
> #include <linux/cpumask.h>
> #include <linux/interrupt.h>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Tai
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] perf: xgene: Include module.h
2017-01-26 3:29 ` Tai Tri Nguyen
@ 2017-01-26 12:21 ` Will Deacon
0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2017-01-26 12:21 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 25, 2017 at 07:29:30PM -0800, Tai Tri Nguyen wrote:
> On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > I ran into a build error when I disabled CONFIG_ACPI and tried to
> > compile this driver:
> >
> > drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
> > MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
> > ^
> > drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> >
> > Include module.h for the MODULE_DEVICE_TABLE macro that's
> > implicitly included through ACPI.
> >
> > Cc: Tai Nguyen <ttnguyen@apm.com>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > drivers/perf/xgene_pmu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> > index a8ac4bcef2c0..fb3281962a6d 100644
> > --- a/drivers/perf/xgene_pmu.c
> > +++ b/drivers/perf/xgene_pmu.c
> > @@ -20,6 +20,7 @@
> > */
> >
> > #include <linux/acpi.h>
> > +#include <linux/module.h>
>
> Please fix alphabetic order of the include file.
>
> Tested-by: Tai Nguyen <ttnguyen@apm.com>
I've picked this up with the includes put in the correct order.
Thanks,
Will
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-26 12:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-25 23:46 [PATCH] perf: xgene: Include module.h Stephen Boyd
2017-01-26 2:13 ` Tai Tri Nguyen
2017-01-26 2:16 ` Tai Tri Nguyen
2017-01-26 3:29 ` Tai Tri Nguyen
2017-01-26 12:21 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).