* [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER [not found] <20170126220504.4796-1-andrew.smirnov@gmail.com> @ 2017-01-26 22:05 ` Andrey Smirnov 2017-01-27 9:54 ` Lucas Stach 0 siblings, 1 reply; 4+ messages in thread From: Andrey Smirnov @ 2017-01-26 22:05 UTC (permalink / raw) To: linux-arm-kernel Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow 'imx_gpc_driver' to be probed in addition to irqchip initialized by imx_gpc_init(). Cc: yurovsky at gmail.com Cc: Shawn Guo <shawnguo@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: linux-arm-kernel at lists.infradead.org Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/mach-imx/gpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c index 1dc2a34..8f0d19b 100644 --- a/arch/arm/mach-imx/gpc.c +++ b/arch/arm/mach-imx/gpc.c @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node, return 0; } -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); void __init imx_gpc_check_dt(void) { -- 2.9.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER 2017-01-26 22:05 ` [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER Andrey Smirnov @ 2017-01-27 9:54 ` Lucas Stach 2017-01-27 18:16 ` Andrey Smirnov 0 siblings, 1 reply; 4+ messages in thread From: Lucas Stach @ 2017-01-27 9:54 UTC (permalink / raw) To: linux-arm-kernel Hi Andrey, Am Donnerstag, den 26.01.2017, 14:05 -0800 schrieb Andrey Smirnov: > Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow > 'imx_gpc_driver' to be probed in addition to irqchip initialized by > imx_gpc_init(). > > Cc: yurovsky at gmail.com > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: linux-arm-kernel at lists.infradead.org > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > arch/arm/mach-imx/gpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c > index 1dc2a34..8f0d19b 100644 > --- a/arch/arm/mach-imx/gpc.c > +++ b/arch/arm/mach-imx/gpc.c > @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node, > > return 0; > } > -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); > +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); > > void __init imx_gpc_check_dt(void) > { I don't see the other patches from the series on the list, so commenting here: You might want to take a look at my GPC rework series, it has a much nicer binding for the power domains, that you might want to use for the GPCv2 also. Additionally I think the power domain stuff doesn't belong into the irqchip driver, but rather in a separate driver in drivers/soc like it is done in my series. I'll send out an updated version of this series today and you might consider basing your GPCv2 on top of that. Regards, Lucas ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER 2017-01-27 9:54 ` Lucas Stach @ 2017-01-27 18:16 ` Andrey Smirnov 0 siblings, 0 replies; 4+ messages in thread From: Andrey Smirnov @ 2017-01-27 18:16 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 27, 2017 at 1:54 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Hi Andrey, > > Am Donnerstag, den 26.01.2017, 14:05 -0800 schrieb Andrey Smirnov: >> Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow >> 'imx_gpc_driver' to be probed in addition to irqchip initialized by >> imx_gpc_init(). >> >> Cc: yurovsky at gmail.com >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Jason Cooper <jason@lakedaemon.net> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: linux-arm-kernel at lists.infradead.org >> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >> --- >> arch/arm/mach-imx/gpc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c >> index 1dc2a34..8f0d19b 100644 >> --- a/arch/arm/mach-imx/gpc.c >> +++ b/arch/arm/mach-imx/gpc.c >> @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node, >> >> return 0; >> } >> -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); >> +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); >> >> void __init imx_gpc_check_dt(void) >> { > > I don't see the other patches from the series on the list, so commenting > here: You might want to take a look at my GPC rework series, it has a > much nicer binding for the power domains, that you might want to use for > the GPCv2 also. I messed up distribution list of my original patches, sorry. OK, I'll take a look. > > Additionally I think the power domain stuff doesn't belong into the > irqchip driver, but rather in a separate driver in drivers/soc like it > is done in my series. > > I'll send out an updated version of this series today and you might > consider basing your GPCv2 on top of that. Please CC me on it if you haven't sent the patches already. Thanks, Andrey Smirnov ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20170126215609.4272-1-andrew.smirnov@gmail.com>]
* [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER [not found] <20170126215609.4272-1-andrew.smirnov@gmail.com> @ 2017-01-26 21:56 ` Andrey Smirnov 0 siblings, 0 replies; 4+ messages in thread From: Andrey Smirnov @ 2017-01-26 21:56 UTC (permalink / raw) To: linux-arm-kernel Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow 'imx_gpc_driver' to be probed in addition to irqchip initialized by imx_gpc_init(). Cc: yurovsky at gmail.com Cc: Shawn Guo <shawnguo@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: linux-arm-kernel at lists.infradead.org Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/mach-imx/gpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c index 1dc2a34..8f0d19b 100644 --- a/arch/arm/mach-imx/gpc.c +++ b/arch/arm/mach-imx/gpc.c @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node, return 0; } -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init); void __init imx_gpc_check_dt(void) { -- 2.9.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-27 18:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170126220504.4796-1-andrew.smirnov@gmail.com>
2017-01-26 22:05 ` [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER Andrey Smirnov
2017-01-27 9:54 ` Lucas Stach
2017-01-27 18:16 ` Andrey Smirnov
[not found] <20170126215609.4272-1-andrew.smirnov@gmail.com>
2017-01-26 21:56 ` Andrey Smirnov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).