Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: sunxi-ng: Call divider_round_rate if we only have a single parent
Date: Fri, 27 Jan 2017 11:03:56 +0100	[thread overview]
Message-ID: <20170127100356.leltnpslzjuhzjwc@lukather> (raw)
In-Reply-To: <CAGb2v67pdKYW5jaa1jA5+QbEV50iPNt-9Z7MNE90P+vUYVocNQ@mail.gmail.com>

On Fri, Jan 27, 2017 at 11:30:05AM +0800, Chen-Yu Tsai wrote:
> On Fri, Jan 27, 2017 at 8:12 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 01/24, Maxime Ripard wrote:
> >> The divider_get_val function that is used in our determine_rate callback
> >> doesn't try to change the parent rate at all, while clk_divider_bestdiv,
> >> used in divider_round_rate, does.
> >>
> >> If we have a single parent, call divider_round_rate.
> 
> I guess my "clk: sunxi-ng: mux: Get closest parent rate possible with
> CLK_SET_RATE_PARENT" patch somewhat takes care of the multi-parent
> case?

It looks like it does yes :)

> Still, the underlying clock type doesn't get to specify what
> is considers to be the best parent rate.
> 
> >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >> ---
> >
> > Acked-by: Stephen Boyd <sboyd@codeaurora.org>
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Merged the two patches with Stephen and your Acked-bY.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170127/706e077e/attachment.sig>

      reply	other threads:[~2017-01-27 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24  9:41 [PATCH 1/2] clk: sunxi-ng: Call divider_round_rate if we only have a single parent Maxime Ripard
2017-01-24  9:41 ` [PATCH 2/2] clk: sunxi-ng: a33: Set CLK_SET_RATE_PARENT for the GPU Maxime Ripard
2017-01-27  0:12   ` Stephen Boyd
2017-01-27  3:01     ` Chen-Yu Tsai
2017-01-27  0:12 ` [PATCH 1/2] clk: sunxi-ng: Call divider_round_rate if we only have a single parent Stephen Boyd
2017-01-27  3:30   ` Chen-Yu Tsai
2017-01-27 10:03     ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170127100356.leltnpslzjuhzjwc@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox