* [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. [not found] <CGME20170127111947epcas2p14f5ea86f0069142be02339754fda4a55@epcas2p1.samsung.com> @ 2017-01-27 11:19 ` Shailendra Verma 2017-01-27 12:44 ` Corentin Labbe 0 siblings, 1 reply; 3+ messages in thread From: Shailendra Verma @ 2017-01-27 11:19 UTC (permalink / raw) To: linux-arm-kernel of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma <shailendra.v@samsung.com> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 4a62ffd..4495b7b 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev) int i; match = of_match_device(of_mtk_match, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } soc = (struct mtk_soc_data *)match->data; eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. 2017-01-27 11:19 ` [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence Shailendra Verma @ 2017-01-27 12:44 ` Corentin Labbe 2017-01-27 16:26 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Corentin Labbe @ 2017-01-27 12:44 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 27, 2017 at 04:49:40PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma <shailendra.v@samsung.com> > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 4a62ffd..4495b7b 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev) > int i; > > match = of_match_device(of_mtk_match, &pdev->dev); > + if (!match) { > + dev_err(&pdev->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > soc = (struct mtk_soc_data *)match->data; > > eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL); > -- Hello You could use of_device_get_match_data() and simplifiy code Regards Corentin Labbe ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. 2017-01-27 12:44 ` Corentin Labbe @ 2017-01-27 16:26 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2017-01-27 16:26 UTC (permalink / raw) To: linux-arm-kernel From: Corentin Labbe <clabbe.montjoie@gmail.com> Date: Fri, 27 Jan 2017 13:44:49 +0100 > On Fri, Jan 27, 2017 at 04:49:40PM +0530, Shailendra Verma wrote: >> of_match_device could return NULL, and so can cause a NULL >> pointer dereference later. >> >> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com> >> --- >> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c >> index 4a62ffd..4495b7b 100644 >> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c >> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c >> @@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev) >> int i; >> >> match = of_match_device(of_mtk_match, &pdev->dev); >> + if (!match) { >> + dev_err(&pdev->dev, "Error: No device match found\n"); >> + return -ENODEV; >> + } >> soc = (struct mtk_soc_data *)match->data; >> >> eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL); >> -- > > Hello > > You could use of_device_get_match_data() and simplifiy code Agreed. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-27 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170127111947epcas2p14f5ea86f0069142be02339754fda4a55@epcas2p1.samsung.com>
2017-01-27 11:19 ` [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence Shailendra Verma
2017-01-27 12:44 ` Corentin Labbe
2017-01-27 16:26 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).