From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Tue, 31 Jan 2017 14:17:24 +0530 Subject: [PATCH V2 07/12] PM / OPP: Update OPP users to put reference In-Reply-To: <20170131071721epcms1p6a4da8e0add4547573d40bbbb55d37b74@epcms1p6> References: <20170131071721epcms1p6a4da8e0add4547573d40bbbb55d37b74@epcms1p6> Message-ID: <20170131084724.GB7458@vireshk-i7> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31-01-17, 07:17, MyungJoo Ham wrote: > > This patch updates dev_pm_opp_find_freq_*() routines to get a reference > > to the OPPs returned by them. > > > > Also updates the users of dev_pm_opp_find_freq_*() routines to call > > dev_pm_opp_put() after they are done using the OPPs. > > > > As it is guaranteed the that OPPs wouldn't get freed while being used, > > the RCU read side locking present with the users isn't required anymore. > > Drop it as well. > > > > This patch also updates all users of devfreq_recommended_opp() which was > > returning an OPP received from the OPP core. > > > > Note that some of the OPP core routines have gained > > rcu_read_{lock|unlock}() calls, as those still use RCU specific APIs > > within them. > > > > Signed-off-by: Viresh Kumar > > Reviewed-by: Chanwoo Choi [Devfreq] > > This patch gets a lot of fails during application. > > For devfreq-side, I've got: > error: drivers/devfreq/devfreq.c: patch does not apply > error: patch failed: drivers/devfreq/exynos-bus.c:103 > error: drivers/devfreq/exynos-bus.c: patch does not apply > error: patch failed: drivers/devfreq/governor_passive.c:59 > error: drivers/devfreq/governor_passive.c: patch does not apply > error: patch failed: drivers/devfreq/rk3399_dmc.c:91 > error: drivers/devfreq/rk3399_dmc.c: patch does not apply > error: patch failed: drivers/devfreq/tegra-devfreq.c:487 > error: drivers/devfreq/tegra-devfreq.c: patch does not apply > > With the condition that you are going to properly rebase the patch, > you may add "Reviewed-by" from me. > (the code itself looks fine.) This is already applied by Rafael and was based over his tree only. -- viresh