From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Tue, 31 Jan 2017 14:14:41 -0500 Subject: [PATCH v3 20/24] drm/rockchip: vop: test for P{H,V}SYNC In-Reply-To: <20170129132444.25251-21-john@metanate.com> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-21-john@metanate.com> Message-ID: <20170131191441.GD20076@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jan 29, 2017 at 01:24:40PM +0000, John Keeping wrote: > When connected to the MIPI DSI output, we need to use N{H,V}SYNC for the > internal connection but these flags are meaningless for DSI panels. > Switch the test so that we do not set the P{H,V}SYNC bits unless the > mode requires it. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Mark Yao > --- > v3: > - Add Mark's Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index c7eba305c488..67aefc6d4e9a 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -933,8 +933,8 @@ static void vop_crtc_enable(struct drm_crtc *crtc) > } > > pin_pol = 0x8; > - pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1; > - pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1); > + pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) ? 1 : 0; > + pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) ? (1 << 1) : 0; > VOP_CTRL_SET(vop, pin_pol, pin_pol); > > switch (s->output_type) { > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS