From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/dma: Remove bogus dma_supported() implementation
Date: Mon, 6 Feb 2017 13:14:31 +0100 [thread overview]
Message-ID: <20170206121431.GB25981@8bytes.org> (raw)
In-Reply-To: <143b03c101e727cb156b26a907c8d7e390eb9114.1485971565.git.robin.murphy@arm.com>
On Wed, Feb 01, 2017 at 05:53:04PM +0000, Robin Murphy wrote:
> Back when this was first written, dma_supported() was somewhat of a
> murky mess, with subtly different interpretations being relied upon in
> various places. The "does device X support DMA to address range Y?"
> uses assuming Y to be physical addresses, which motivated the current
> iommu_dma_supported() implementation and are alluded to in the comment
> therein, have since been cleaned up, leaving only the far less ambiguous
> "can device X drive address bits Y" usage internal to DMA API mask
> setting. As such, there is no reason to keep a slightly misleading
> callback which does nothing but duplicate the current default behaviour;
> we already constrain IOVA allocations to the iommu_domain aperture where
> necessary, so let's leave DMA mask business to architecture-specific
> code where it belongs.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Applied, thanks
prev parent reply other threads:[~2017-02-06 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 17:53 [PATCH] iommu/dma: Remove bogus dma_supported() implementation Robin Murphy
2017-02-06 12:14 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206121431.GB25981@8bytes.org \
--to=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).