linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i
@ 2017-02-02 14:33 Arnd Bergmann
  2017-02-06  3:43 ` Chen-Yu Tsai
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-02-02 14:33 UTC (permalink / raw)
  To: linux-arm-kernel

We get a link error when CCU_MULT is not set with the
newly added driver:

drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'

Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 67659091860d..695bbf9ef428 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -67,6 +67,7 @@ config SUN50I_A64_CCU
 config SUN5I_CCU
 	bool "Support for the Allwinner sun5i family CCM"
 	select SUNXI_CCU_DIV
+	select SUNXI_CCU_MULT
 	select SUNXI_CCU_NK
 	select SUNXI_CCU_NKM
 	select SUNXI_CCU_NM
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i
  2017-02-02 14:33 [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Arnd Bergmann
@ 2017-02-06  3:43 ` Chen-Yu Tsai
  2017-02-06 10:52 ` Maxime Ripard
  2017-02-06 22:49 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2017-02-06  3:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Feb 2, 2017 at 10:33 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> We get a link error when CCU_MULT is not set with the
> newly added driver:
>
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'
>
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Chen-Yu Tsai <wens@csie.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i
  2017-02-02 14:33 [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Arnd Bergmann
  2017-02-06  3:43 ` Chen-Yu Tsai
@ 2017-02-06 10:52 ` Maxime Ripard
  2017-02-06 22:49 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2017-02-06 10:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Feb 02, 2017 at 03:33:57PM +0100, Arnd Bergmann wrote:
> We get a link error when CCU_MULT is not set with the
> newly added driver:
> 
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'
> 
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Mike, Stephen, can you apply it directly?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170206/26e9fa96/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i
  2017-02-02 14:33 [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Arnd Bergmann
  2017-02-06  3:43 ` Chen-Yu Tsai
  2017-02-06 10:52 ` Maxime Ripard
@ 2017-02-06 22:49 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2017-02-06 22:49 UTC (permalink / raw)
  To: linux-arm-kernel

On 02/02, Arnd Bergmann wrote:
> We get a link error when CCU_MULT is not set with the
> newly added driver:
> 
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'
> 
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-06 22:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-02 14:33 [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Arnd Bergmann
2017-02-06  3:43 ` Chen-Yu Tsai
2017-02-06 10:52 ` Maxime Ripard
2017-02-06 22:49 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).