* [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue
@ 2017-02-07 7:34 He Kuang
2017-02-07 7:34 ` [PATCH v4 2/2] perf tools: Add missing newline in debug messages He Kuang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: He Kuang @ 2017-02-07 7:34 UTC (permalink / raw)
To: linux-arm-kernel
Since HAVE_KPROBES can be enabled in arm64, this patch introduces
regs_query_register_offset() to convert register name to offset for
arm64, so the BPF prologue feature is ready to use.
Signed-off-by: He Kuang <hekuang@huawei.com>
---
tools/perf/arch/arm64/Makefile | 1 +
tools/perf/arch/arm64/util/dwarf-regs.c | 15 ++++++++++++++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
index 18b1351..eebe1ec 100644
--- a/tools/perf/arch/arm64/Makefile
+++ b/tools/perf/arch/arm64/Makefile
@@ -2,3 +2,4 @@ ifndef NO_DWARF
PERF_HAVE_DWARF_REGS := 1
endif
PERF_HAVE_JITDUMP := 1
+PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET := 1
diff --git a/tools/perf/arch/arm64/util/dwarf-regs.c b/tools/perf/arch/arm64/util/dwarf-regs.c
index d49efeb..068b618 100644
--- a/tools/perf/arch/arm64/util/dwarf-regs.c
+++ b/tools/perf/arch/arm64/util/dwarf-regs.c
@@ -10,17 +10,20 @@
#include <stddef.h>
#include <dwarf-regs.h>
+#include <linux/ptrace.h> /* for struct user_pt_regs */
+#include "util.h"
struct pt_regs_dwarfnum {
const char *name;
unsigned int dwarfnum;
};
-#define STR(s) #s
#define REG_DWARFNUM_NAME(r, num) {.name = r, .dwarfnum = num}
#define GPR_DWARFNUM_NAME(num) \
{.name = STR(%x##num), .dwarfnum = num}
#define REG_DWARFNUM_END {.name = NULL, .dwarfnum = 0}
+#define DWARFNUM2OFFSET(index) \
+ (index * sizeof((struct user_pt_regs *)0)->regs[0])
/*
* Reference:
@@ -78,3 +81,13 @@ const char *get_arch_regstr(unsigned int n)
return roff->name;
return NULL;
}
+
+int regs_query_register_offset(const char *name)
+{
+ const struct pt_regs_dwarfnum *roff;
+
+ for (roff = regdwarfnum_table; roff->name != NULL; roff++)
+ if (!strcmp(roff->name, name))
+ return DWARFNUM2OFFSET(roff->dwarfnum);
+ return -EINVAL;
+}
--
1.8.5.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v4 2/2] perf tools: Add missing newline in debug messages
2017-02-07 7:34 [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue He Kuang
@ 2017-02-07 7:34 ` He Kuang
2017-02-07 12:12 ` [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue Will Deacon
2017-02-07 13:43 ` Masami Hiramatsu
2 siblings, 0 replies; 5+ messages in thread
From: He Kuang @ 2017-02-07 7:34 UTC (permalink / raw)
To: linux-arm-kernel
These two debug messages are missing the trailing newline.
Signed-off-by: He Kuang <hekuang@huawei.com>
---
tools/perf/util/bpf-loader.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c
index 36c8611..bc6bc70 100644
--- a/tools/perf/util/bpf-loader.c
+++ b/tools/perf/util/bpf-loader.c
@@ -670,13 +670,13 @@ int bpf__probe(struct bpf_object *obj)
err = convert_perf_probe_events(pev, 1);
if (err < 0) {
- pr_debug("bpf_probe: failed to convert perf probe events");
+ pr_debug("bpf_probe: failed to convert perf probe events\n");
goto out;
}
err = apply_perf_probe_events(pev, 1);
if (err < 0) {
- pr_debug("bpf_probe: failed to apply perf probe events");
+ pr_debug("bpf_probe: failed to apply perf probe events\n");
goto out;
}
--
1.8.5.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue
2017-02-07 7:34 [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue He Kuang
2017-02-07 7:34 ` [PATCH v4 2/2] perf tools: Add missing newline in debug messages He Kuang
@ 2017-02-07 12:12 ` Will Deacon
2017-02-07 15:02 ` Arnaldo Carvalho de Melo
2017-02-07 13:43 ` Masami Hiramatsu
2 siblings, 1 reply; 5+ messages in thread
From: Will Deacon @ 2017-02-07 12:12 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Feb 07, 2017 at 07:34:11AM +0000, He Kuang wrote:
> Since HAVE_KPROBES can be enabled in arm64, this patch introduces
> regs_query_register_offset() to convert register name to offset for
> arm64, so the BPF prologue feature is ready to use.
>
> Signed-off-by: He Kuang <hekuang@huawei.com>
> ---
> tools/perf/arch/arm64/Makefile | 1 +
> tools/perf/arch/arm64/util/dwarf-regs.c | 15 ++++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
Thanks, looks ok to me now:
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue
2017-02-07 12:12 ` [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue Will Deacon
@ 2017-02-07 15:02 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-02-07 15:02 UTC (permalink / raw)
To: linux-arm-kernel
Em Tue, Feb 07, 2017 at 12:12:33PM +0000, Will Deacon escreveu:
> On Tue, Feb 07, 2017 at 07:34:11AM +0000, He Kuang wrote:
> > Since HAVE_KPROBES can be enabled in arm64, this patch introduces
> > regs_query_register_offset() to convert register name to offset for
> > arm64, so the BPF prologue feature is ready to use.
> >
> > Signed-off-by: He Kuang <hekuang@huawei.com>
> > ---
> > tools/perf/arch/arm64/Makefile | 1 +
> > tools/perf/arch/arm64/util/dwarf-regs.c | 15 ++++++++++++++-
> > 2 files changed, 15 insertions(+), 1 deletion(-)
>
> Thanks, looks ok to me now:
>
> Reviewed-by: Will Deacon <will.deacon@arm.com>
Thanks, applied with your and Masami's tags.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue
2017-02-07 7:34 [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue He Kuang
2017-02-07 7:34 ` [PATCH v4 2/2] perf tools: Add missing newline in debug messages He Kuang
2017-02-07 12:12 ` [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue Will Deacon
@ 2017-02-07 13:43 ` Masami Hiramatsu
2 siblings, 0 replies; 5+ messages in thread
From: Masami Hiramatsu @ 2017-02-07 13:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 7 Feb 2017 07:34:11 +0000
He Kuang <hekuang@huawei.com> wrote:
> Since HAVE_KPROBES can be enabled in arm64, this patch introduces
> regs_query_register_offset() to convert register name to offset for
> arm64, so the BPF prologue feature is ready to use.
>
Ok, looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Signed-off-by: He Kuang <hekuang@huawei.com>
> ---
> tools/perf/arch/arm64/Makefile | 1 +
> tools/perf/arch/arm64/util/dwarf-regs.c | 15 ++++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
> index 18b1351..eebe1ec 100644
> --- a/tools/perf/arch/arm64/Makefile
> +++ b/tools/perf/arch/arm64/Makefile
> @@ -2,3 +2,4 @@ ifndef NO_DWARF
> PERF_HAVE_DWARF_REGS := 1
> endif
> PERF_HAVE_JITDUMP := 1
> +PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET := 1
> diff --git a/tools/perf/arch/arm64/util/dwarf-regs.c b/tools/perf/arch/arm64/util/dwarf-regs.c
> index d49efeb..068b618 100644
> --- a/tools/perf/arch/arm64/util/dwarf-regs.c
> +++ b/tools/perf/arch/arm64/util/dwarf-regs.c
> @@ -10,17 +10,20 @@
>
> #include <stddef.h>
> #include <dwarf-regs.h>
> +#include <linux/ptrace.h> /* for struct user_pt_regs */
> +#include "util.h"
>
> struct pt_regs_dwarfnum {
> const char *name;
> unsigned int dwarfnum;
> };
>
> -#define STR(s) #s
> #define REG_DWARFNUM_NAME(r, num) {.name = r, .dwarfnum = num}
> #define GPR_DWARFNUM_NAME(num) \
> {.name = STR(%x##num), .dwarfnum = num}
> #define REG_DWARFNUM_END {.name = NULL, .dwarfnum = 0}
> +#define DWARFNUM2OFFSET(index) \
> + (index * sizeof((struct user_pt_regs *)0)->regs[0])
>
> /*
> * Reference:
> @@ -78,3 +81,13 @@ const char *get_arch_regstr(unsigned int n)
> return roff->name;
> return NULL;
> }
> +
> +int regs_query_register_offset(const char *name)
> +{
> + const struct pt_regs_dwarfnum *roff;
> +
> + for (roff = regdwarfnum_table; roff->name != NULL; roff++)
> + if (!strcmp(roff->name, name))
> + return DWARFNUM2OFFSET(roff->dwarfnum);
> + return -EINVAL;
> +}
> --
> 1.8.5.2
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-07 15:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-07 7:34 [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue He Kuang
2017-02-07 7:34 ` [PATCH v4 2/2] perf tools: Add missing newline in debug messages He Kuang
2017-02-07 12:12 ` [PATCH v4 1/2] perf tools arm64: Add support for generating bpf prologue Will Deacon
2017-02-07 15:02 ` Arnaldo Carvalho de Melo
2017-02-07 13:43 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).