[PATCH v2 2/3] gpiolib: gpiod_hog remove separate name argument

Linus Walleij
2015-09-21T23:28:48Z

On Sun, Aug 30, 2015 at 12:44 AM, Markus Pargmann <mpa@pengutronix.de> wrote:

> The gpio name is now stored in the gpio descriptor, so we can simply use
> that instead of an argument to the function.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

Several problems with this patch:

- Does not apply to v4.3-rc1
- Fixed that but noted that it just alters the call to gpiod_hog()
in of_gpiochip_scan_hogs(), there is a local const char *name that
should be removed too.
- Looking at of_get_gpio_hog() it is unclear to me that .name
is set in the gpio_desc as desired. Please check this.

Crucial code looks like this:

if (name && of_property_read_string(np, "line-name", name))
*name = np->name;

i.e. is the line-name really propagated to gpiod->name?
Are you sure you have tested this with a DTS using line-name
and verified that it propagates properly?

Yours,
Linus Walleij