Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/8] mfd: exynos-lpass: Add missing remove() function
Date: Wed, 8 Feb 2017 10:57:43 +0000	[thread overview]
Message-ID: <20170208105743.wgq4o6ev6ybvwbgz@dell> (raw)
In-Reply-To: <1485419634-28331-8-git-send-email-m.szyprowski@samsung.com>

On Thu, 26 Jan 2017, Marek Szyprowski wrote:

> Disable device on driver remove and release allocated regmap.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/mfd/exynos-lpass.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
  
> diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
> index be264988bdc9..9dbbedad916f 100644
> --- a/drivers/mfd/exynos-lpass.c
> +++ b/drivers/mfd/exynos-lpass.c
> @@ -137,6 +137,16 @@ static int exynos_lpass_probe(struct platform_device *pdev)
>  	return of_platform_populate(dev->of_node, NULL, NULL, dev);
>  }
>  
> +static int exynos_lpass_remove(struct platform_device *pdev)
> +{
> +	struct exynos_lpass *lpass = platform_get_drvdata(pdev);
> +
> +	exynos_lpass_disable(lpass);
> +	regmap_exit(lpass->top);
> +
> +	return 0;
> +}
> +
>  static int __maybe_unused exynos_lpass_suspend(struct device *dev)
>  {
>  	struct exynos_lpass *lpass = dev_get_drvdata(dev);
> @@ -171,6 +181,7 @@ static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend,
>  		.of_match_table	= exynos_lpass_of_match,
>  	},
>  	.probe	= exynos_lpass_probe,
> +	.remove	= exynos_lpass_remove,
>  };
>  module_platform_driver(exynos_lpass_driver);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2017-02-08 10:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170126083401eucas1p20b4794fe46ccf2189bf734f0d8e3c536@eucas1p2.samsung.com>
2017-01-26  8:33 ` [PATCH v2 0/8] Pad retentions support for Exynos5433 Marek Szyprowski
2017-01-26  8:33   ` [PATCH v2 1/8] soc: samsung: pmu: Add dummy support for Exynos5433 SoC Marek Szyprowski
2017-01-26 19:57     ` Krzysztof Kozlowski
2017-01-26  8:33   ` [PATCH v2 2/8] pinctrl: samsung: Ensure that pad retention is disabled on driver init Marek Szyprowski
2017-01-26  8:33   ` [PATCH v2 3/8] pinctrl: samsung: Add support for pad retention control for Exynos5433 SoCs Marek Szyprowski
2017-01-26 19:48     ` Krzysztof Kozlowski
2017-01-27 18:02       ` Krzysztof Kozlowski
2017-01-30 10:39         ` Marek Szyprowski
2017-01-26 19:57     ` Krzysztof Kozlowski
2017-01-26  8:33   ` [PATCH v2 4/8] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module Marek Szyprowski
2017-01-26 20:08     ` Krzysztof Kozlowski
2017-01-26  8:33   ` [PATCH v2 5/8] mfd: exynos-lpass: Remove pad retention control Marek Szyprowski
2017-01-26  9:36     ` Sylwester Nawrocki
2017-02-01 13:24     ` Rob Herring
2017-02-08 10:56     ` Lee Jones
2017-01-26  8:33   ` [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks Marek Szyprowski
2017-01-26 20:09     ` Krzysztof Kozlowski
2017-02-01 13:24     ` Rob Herring
2017-02-08 10:57     ` Lee Jones
2017-01-26  8:33   ` [PATCH v2 7/8] mfd: exynos-lpass: Add missing remove() function Marek Szyprowski
2017-01-26 20:11     ` Krzysztof Kozlowski
2017-02-08 10:57     ` Lee Jones [this message]
2017-01-26  8:33   ` [PATCH v2 8/8] mfd: exynos-lpass: Add runtime PM support Marek Szyprowski
2017-02-08 10:58     ` Lee Jones
2017-01-26  9:50   ` [PATCH v2 0/8] Pad retentions support for Exynos5433 Linus Walleij
2017-01-26 10:37     ` Marek Szyprowski
2017-01-26 14:32     ` Krzysztof Kozlowski
2017-01-26 15:47       ` Linus Walleij
2017-01-27 19:46   ` Krzysztof Kozlowski
2017-01-30  9:57     ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208105743.wgq4o6ev6ybvwbgz@dell \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox