From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency
Date: Thu, 9 Feb 2017 18:22:11 +0100 [thread overview]
Message-ID: <20170209172211.GF29882@lunn.ch> (raw)
In-Reply-To: <20170209150834.1158193-1-arnd@arndb.de>
On Thu, Feb 09, 2017 at 04:08:11PM +0100, Arnd Bergmann wrote:
> The newly introduced mdiobus_register_board_info() function is only available
> as part of PHYLIB, so we get a link error when we call that from a board while
> phylib is disabled:
>
> arch/arm/plat-orion/common.o: In function `orion_ge00_switch_init':
> common.c:(.init.text+0x6a4): undefined reference to `mdiobus_register_board_info'
>
> This adds a workaround that is made up of three parts:
>
> - in plat-orion, the function for declaring the switch is hidden without
> PHYLIB.
> - in mach-orion5x, the caller conditionally stubs out the call to
> the removed function, so we can still build other orion5x boards
> without PHYLIB
> - For the boards that actually declare the switch, we select PHYLIB
> explicitly from Kconfig if NETDEVICES is set. Without NETDEVICES,
> we cannot enable PHYLIB, but we also wouldn't need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-02-09 17:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 15:08 [PATCH] [net-next] ARM: orion: fix PHYLIB dependency Arnd Bergmann
2017-02-09 15:57 ` Andrew Lunn
2017-02-09 17:14 ` Arnd Bergmann
2017-02-09 17:20 ` Andrew Lunn
2017-02-09 18:14 ` Florian Fainelli
2017-02-09 17:22 ` Andrew Lunn [this message]
2017-02-09 18:22 ` Florian Fainelli
2017-02-10 8:20 ` Arnd Bergmann
2017-02-10 17:42 ` Florian Fainelli
2017-02-10 20:05 ` Arnd Bergmann
2017-02-10 20:57 ` Florian Fainelli
2017-02-10 21:32 ` Arnd Bergmann
2017-02-13 14:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209172211.GF29882@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox