public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: w@1wt.eu (Willy Tarreau)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS
Date: Sun, 12 Feb 2017 01:53:50 +0100	[thread overview]
Message-ID: <20170212005350.GA18612@1wt.eu> (raw)
In-Reply-To: <20170212004031.GA7328@lunn.ch>

Hi Andrew,

On Sun, Feb 12, 2017 at 01:40:31AM +0100, Andrew Lunn wrote:
> > +			serial at 12000 {
> > +				pinctrl-names = "default";
> > +				pinctrl-0 = <&uart0_pins>;
> > +				status = "okay";
> > +			};
> > +
> > +			serial at 12100 {
> > +				/* A PIC16F1829 is connected to uart1 at 115200 bps,
> > +				 * and takes single-character orders :
> > +				 *   "1" : power off
> 
> Hi Willy
> 
> The qnap-poweroff.c driver will support this. You need a new
> compatible string, since 115200 is not the speed the current synology
> devices use.

But won't that squat the I/O address and prevent me from using all the
other codes via the regular serial port ? They are particularly convenient
in fact since they are the only way to access the LEDs, beeper and even
to trigger a reset (even if this last one is less used in software form).

> > +				 *   "2" : short beep
> > +				 *   "3" : long beep
> > +				 *   "4" : turn the power LED ON
> > +				 *   "5" : flash the power LED
> > +				 *   "6" : turn the power LED OFF
> > +				 *   "7" : turn the status LED OFF
> > +				 *   "8" : turn the status LED ON
> > +				 *   "9" : flash the status LED
> > +				 *   "A" : flash the motherboard LED (D8)
> > +				 *   "B" : turn the motherboard LED OFF
> > +				 *   "C" : hard reset
> > +				 */
> > +				pinctrl-names = "default";
> > +				pinctrl-0 = <&uart1_pins>;
> > +				status = "okay";
> > +			};
> 
> > +		gpio-leds {
> > +			compatible = "gpio-leds";
> > +
> > +			/* The greed part is on gpio0.20 which is also used by
> 
> green?

Oops, sorry, thanks for catching.

Willy

  reply	other threads:[~2017-02-12  0:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11  9:24 [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS Willy Tarreau
2017-02-12  0:40 ` Andrew Lunn
2017-02-12  0:53   ` Willy Tarreau [this message]
2017-02-12  1:17     ` Andrew Lunn
2017-02-12  1:24       ` Willy Tarreau
2017-02-12 15:38         ` Andrew Lunn
2017-02-12 15:44           ` Willy Tarreau
2017-02-12 17:27           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170212005350.GA18612@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox