From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bcm2835-audio: Fix checkpatch errors
Date: Sun, 12 Feb 2017 13:16:58 +0100 [thread overview]
Message-ID: <20170212121658.GA19617@kroah.com> (raw)
In-Reply-To: <1486845362-25086-1-git-send-email-manchoyy@gmail.com>
On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote:
> Fix following errors:
>
> ERROR: do not initialise statics to NULL
> +static struct snd_card *g_card = NULL;
>
> ERROR: do not initialise statics to NULL
> +static struct bcm2835_chip *g_chip = NULL;
>
> Signed-off-by: Man Choy <manchoyy@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
> index a84d74d..265fe55 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835.c
> @@ -28,8 +28,8 @@
> * to debug if we run into issues
> */
>
> -static struct snd_card *g_card = NULL;
> -static struct bcm2835_chip *g_chip = NULL;
> +static struct snd_card *g_card;
> +static struct bcm2835_chip *g_chip;
>
> static int snd_bcm2835_free(struct bcm2835_chip *chip)
> {
Someone sent this same fix in before you did, a few days ago. Be sure
to always use the most up-to-date tree.
sorry,
greg k-h
next prev parent reply other threads:[~2017-02-12 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 20:34 [PATCH] bcm2835-audio: Fix checkpatch errors Man Choy
2017-02-12 12:16 ` Greg Kroah-Hartman [this message]
2017-02-13 0:49 ` Man Choy
2017-02-13 12:03 ` Greg Kroah-Hartman
2017-02-14 1:16 ` Man Choy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170212121658.GA19617@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox