From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS
Date: Sun, 12 Feb 2017 18:27:24 +0100 [thread overview]
Message-ID: <20170212182724.4ed100e0@free-electrons.com> (raw)
In-Reply-To: <20170212153855.GA17141@lunn.ch>
Hello,
On Sun, 12 Feb 2017 16:38:55 +0100, Andrew Lunn wrote:
> What you have in v2 and v3 looks good. It could be considered a bit of
> a hack, two nodes for the same hardware block. But they are used at
> different times, normal runtime, and late in the shutdown. So it works
> out O.K.
I don't really mind personally, but IMO this is clearly a hack. It
completely violates the rule that the DT should represent the HW, and
the fact that the DT should be operating system agnostic.
But anyway, there are so many things in the DT that violates those
rules that probably this hack is fine.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-02-12 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 9:24 [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS Willy Tarreau
2017-02-12 0:40 ` Andrew Lunn
2017-02-12 0:53 ` Willy Tarreau
2017-02-12 1:17 ` Andrew Lunn
2017-02-12 1:24 ` Willy Tarreau
2017-02-12 15:38 ` Andrew Lunn
2017-02-12 15:44 ` Willy Tarreau
2017-02-12 17:27 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170212182724.4ed100e0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox