From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] ASoC: zx-i2s: Add the info of pclk to the binding document for zx2967 family
Date: Mon, 13 Feb 2017 21:05:36 +0800	[thread overview]
Message-ID: <20170213130534.GA4151@dragon> (raw)
In-Reply-To: <20170209164645.ztvockrd6jxpybwt@sirena.org.uk>
On Thu, Feb 09, 2017 at 04:46:45PM +0000, Mark Brown wrote:
> On Thu, Feb 09, 2017 at 11:12:57AM +0800, Baoyou Xie wrote:
> 
> > - - compatible : Must be "zte,zx296702-i2s"
> > + - compatible : Must be one of:
> > +	"zte,zx296718-i2s", "zte,zx296702-i2s"
> > +	"zte,zx296702-i2s"
> 
> You've added the new compatible twice here?
It's indeed a bit confusing.  Might be better if we add a couple of
bullet like below.
 - compatible : Must be one of:
	- "zte,zx296718-i2s", "zte,zx296702-i2s";
	- "zte,zx296702-i2s";
In this case, it's more easier for readers to understand that the first
one is for I2S device on SoC ZX296718, while it's compatible with the
I2S on ZX296702.
Shawn
next prev parent reply	other threads:[~2017-02-13 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09  3:12 [PATCH v4 1/3] clk: zte: add i2s clocks for zx296718 Baoyou Xie
2017-02-09  3:12 ` [PATCH v4 2/3] ASoC: zx-i2s: Add the info of pclk to the binding document for zx2967 family Baoyou Xie
2017-02-09 16:46   ` Mark Brown
2017-02-13 13:05     ` Shawn Guo [this message]
2017-02-09 23:46   ` Applied "ASoC: zx-i2s: Add the info of pclk to the binding document for zx2967 family" to the asoc tree Mark Brown
2017-02-09  3:12 ` [PATCH v4 3/3] ASoC: zx-i2s: introduce pclk for zx2967 family Baoyou Xie
2017-02-09  3:22   ` Shawn Guo
2017-02-09  8:19   ` Jun Nie
2017-02-09 23:46   ` Applied "ASoC: zx-i2s: introduce pclk for zx2967 family" to the asoc tree Mark Brown
2017-02-09  3:20 ` [PATCH v4 1/3] clk: zte: add i2s clocks for zx296718 Shawn Guo
2017-02-10 17:17 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20170213130534.GA4151@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).